Maciej Falkowski
550f4dd2ce
accel/ivpu: Add support for Nova Lake's NPU
...
Add support for NPU6 generation that will be present on Nova Lake CPUs.
As with previous generations, it maintains compatibility
so no bigger functional changes apart from removing
deprecated call to soc_cpu_drive() function.
Quiescing TOP_MMIO in SOC_CPU_NOC as part of boot procedure is no longer
needed starting from 60XX. Remove soc_cpu_drive() call from NPU6 onward.
The VPU_CPU_NOC_QREQN, VPU_CPU_NOC_QACCEPTN, and VPU_CPU_NOC_QDENY
registers are deprecated and non-functional on 60XX. They will be
removed in future generations.
Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com >
Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com >
Signed-off-by: Maciej Falkowski <maciej.falkowski@linux.intel.com >
Link: https://lore.kernel.org/r/20251022105348.2237273-1-maciej.falkowski@linux.intel.com
2025-10-23 12:57:11 +02:00
Thomas Zimmermann
b36ca97592
drm/sysfb: Use new CRTC state in begin_fb_access
...
Retrieve the CRTC's new state with drm_atomic_get_new_crtc_state()
in drm_sysfb_plane_helper_begin_fb_access(). The blit function might
be incorrect otherwise.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Fixes: cb71de0925ville.syrjala@linux.intel.com >
Closes: https://lore.kernel.org/dri-devel/aPJrs7_u8KcalNsC@intel.com/
Cc: Thomas Zimmermann <tzimmermann@suse.de >
Cc: Javier Martinez Canillas <javierm@redhat.com >
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com >
Link: https://lore.kernel.org/r/20251020125227.41308-1-tzimmermann@suse.de
2025-10-23 10:36:14 +02:00
José Expósito
f97180f094
drm/vkms: Allow to configure connector status via configfs
...
When a connector is created, add a `status` file to allow to update the
connector status to:
- 1 connector_status_connected
- 2 connector_status_disconnected
- 3 connector_status_unknown
If the device is enabled, updating the status hot-plug or unplugs the
connector.
Tested-by: Mark Yacoub <markyacoub@google.com >
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Reviewed-by: Harry Wentland <harry.wentland@amd.com >
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
Signed-off-by: José Expósito <jose.exposito89@gmail.com >
Link: https://lore.kernel.org/r/20251016175618.10051-17-jose.exposito89@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
2025-10-22 13:19:26 +02:00
José Expósito
466f43885a
drm/vkms: Allow to update the connector status
...
Implement the drm_connector_funcs.detect() callback to update the
connector status by returning the status stored in the configuration.
Tested-by: Mark Yacoub <markyacoub@google.com >
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Reviewed-by: Harry Wentland <harry.wentland@amd.com >
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
Signed-off-by: José Expósito <jose.exposito89@gmail.com >
Link: https://lore.kernel.org/r/20251016175618.10051-16-jose.exposito89@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
2025-10-22 13:19:26 +02:00
José Expósito
6f00987f5c
drm/vkms: Allow to configure connector status
...
Allow to store the connector status in vkms_config_connector and add a
getter and a setter functions as well a KUnit test.
This change only adds the configuration, the connector status is not
used yet.
Tested-by: Mark Yacoub <markyacoub@google.com >
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Reviewed-by: Harry Wentland <harry.wentland@amd.com >
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
Signed-off-by: José Expósito <jose.exposito89@gmail.com >
Link: https://lore.kernel.org/r/20251016175618.10051-15-jose.exposito89@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
2025-10-22 13:19:26 +02:00
José Expósito
085dadb310
drm/vkms: Remove completed task from the TODO list
...
Remove the configfs related TODO items from the "Runtime Configuration"
section.
Tested-by: Mark Yacoub <markyacoub@google.com >
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Reviewed-by: Harry Wentland <harry.wentland@amd.com >
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
Signed-off-by: José Expósito <jose.exposito89@gmail.com >
Link: https://lore.kernel.org/r/20251016175618.10051-14-jose.exposito89@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
2025-10-22 13:19:26 +02:00
José Expósito
8c29107a61
drm/vkms: Allow to configure the default device creation
...
Add a new module param to allow to create or not the default VKMS
instance. Useful when combined with configfs to avoid having additional
VKMS instances.
Tested-by: Mark Yacoub <markyacoub@google.com >
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Reviewed-by: Harry Wentland <harry.wentland@amd.com >
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
Signed-off-by: José Expósito <jose.exposito89@gmail.com >
Link: https://lore.kernel.org/r/20251016175618.10051-13-jose.exposito89@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
2025-10-22 13:19:26 +02:00
Louis Chauvet
64229b846a
drm/vkms: Allow to attach connectors and encoders via configfs
...
Create a default subgroup at
/config/vkms/connectors/connector/possible_encoders that will contain
symbolic links to the possible encoders for the connector.
Tested-by: Mark Yacoub <markyacoub@google.com >
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Reviewed-by: Harry Wentland <harry.wentland@amd.com >
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com >
Co-developed-by: José Expósito <jose.exposito89@gmail.com >
Signed-off-by: José Expósito <jose.exposito89@gmail.com >
Link: https://lore.kernel.org/r/20251016175618.10051-12-jose.exposito89@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
2025-10-22 13:19:26 +02:00
Louis Chauvet
272acbca96
drm/vkms: Allow to configure multiple connectors via configfs
...
Create a default subgroup at
/config/vkms/connectors to allow to create as many connectors as
required.
Tested-by: Mark Yacoub <markyacoub@google.com >
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Reviewed-by: Harry Wentland <harry.wentland@amd.com >
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com >
Co-developed-by: José Expósito <jose.exposito89@gmail.com >
Signed-off-by: José Expósito <jose.exposito89@gmail.com >
Link: https://lore.kernel.org/r/20251016175618.10051-11-jose.exposito89@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
2025-10-22 13:19:25 +02:00
Louis Chauvet
fad1138b23
drm/vkms: Allow to attach encoders and CRTCs via configfs
...
Create a default subgroup at
/config/vkms/encoders/encoder/possible_crtcs that will contain symbolic
links to the possible CRTCs for the encoder.
Tested-by: Mark Yacoub <markyacoub@google.com >
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Reviewed-by: Harry Wentland <harry.wentland@amd.com >
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com >
Co-developed-by: José Expósito <jose.exposito89@gmail.com >
Signed-off-by: José Expósito <jose.exposito89@gmail.com >
Link: https://lore.kernel.org/r/20251016175618.10051-10-jose.exposito89@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
2025-10-22 13:19:25 +02:00
Louis Chauvet
67d8cf92e1
drm/vkms: Allow to configure multiple encoders via configfs
...
Create a default subgroup at /config/vkms/encoders to allow to create as
many encoders as required.
Tested-by: Mark Yacoub <markyacoub@google.com >
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Reviewed-by: Harry Wentland <harry.wentland@amd.com >
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com >
Co-developed-by: José Expósito <jose.exposito89@gmail.com >
Signed-off-by: José Expósito <jose.exposito89@gmail.com >
Link: https://lore.kernel.org/r/20251016175618.10051-9-jose.exposito89@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
2025-10-22 13:19:25 +02:00
Louis Chauvet
95fa73787a
drm/vkms: Allow to attach planes and CRTCs via configfs
...
Create a default subgroup at /config/vkms/planes/plane/possible_crtcs
that will contain symbolic links to the possible CRTCs for the plane.
Tested-by: Mark Yacoub <markyacoub@google.com >
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Reviewed-by: Harry Wentland <harry.wentland@amd.com >
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com >
Co-developed-by: José Expósito <jose.exposito89@gmail.com >
Signed-off-by: José Expósito <jose.exposito89@gmail.com >
Link: https://lore.kernel.org/r/20251016175618.10051-8-jose.exposito89@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
2025-10-22 13:19:25 +02:00
Louis Chauvet
ee5c2c7d4b
drm/vkms: Allow to configure CRTC writeback support via configfs
...
When a CRTC is created, add a `writeback` file to allow to enable or
disable writeback connector support
Tested-by: Mark Yacoub <markyacoub@google.com >
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Reviewed-by: Harry Wentland <harry.wentland@amd.com >
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com >
Co-developed-by: José Expósito <jose.exposito89@gmail.com >
Signed-off-by: José Expósito <jose.exposito89@gmail.com >
Link: https://lore.kernel.org/r/20251016175618.10051-7-jose.exposito89@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
2025-10-22 13:19:25 +02:00
Louis Chauvet
3e4d5b30d2
drm/vkms: Allow to configure multiple CRTCs via configfs
...
Create a default subgroup at /config/vkms/crtcs to allow to create as
many CRTCs as required.
Tested-by: Mark Yacoub <markyacoub@google.com >
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Reviewed-by: Harry Wentland <harry.wentland@amd.com >
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com >
Co-developed-by: José Expósito <jose.exposito89@gmail.com >
Signed-off-by: José Expósito <jose.exposito89@gmail.com >
Link: https://lore.kernel.org/r/20251016175618.10051-6-jose.exposito89@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
2025-10-22 13:19:25 +02:00
Louis Chauvet
187bc30625
drm/vkms: Allow to configure the plane type via configfs
...
When a plane is created, add a `type` file to allow to set the type:
- 0 overlay
- 1 primary
- 2 cursor
Tested-by: Mark Yacoub <markyacoub@google.com >
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Reviewed-by: Harry Wentland <harry.wentland@amd.com >
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com >
Co-developed-by: José Expósito <jose.exposito89@gmail.com >
Signed-off-by: José Expósito <jose.exposito89@gmail.com >
Link: https://lore.kernel.org/r/20251016175618.10051-5-jose.exposito89@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
2025-10-22 13:19:25 +02:00
Louis Chauvet
2f1734ba27
drm/vkms: Allow to configure multiple planes via configfs
...
Create a default subgroup at /config/vkms/planes to allow to create as
many planes as required.
Tested-by: Mark Yacoub <markyacoub@google.com >
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Reviewed-by: Harry Wentland <harry.wentland@amd.com >
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com >
Co-developed-by: José Expósito <jose.exposito89@gmail.com >
Signed-off-by: José Expósito <jose.exposito89@gmail.com >
Link: https://lore.kernel.org/r/20251016175618.10051-4-jose.exposito89@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
2025-10-22 13:19:25 +02:00
Louis Chauvet
13fc9b9745
drm/vkms: Add and remove VKMS instances via configfs
...
Allow to create, enable, disable and destroy VKMS instances using
configfs.
For the moment, it is not possible to add pipeline items, so trying to
enable the device will fail printing an informative error to the log.
Tested-by: Mark Yacoub <markyacoub@google.com >
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Reviewed-by: Harry Wentland <harry.wentland@amd.com >
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com >
Co-developed-by: José Expósito <jose.exposito89@gmail.com >
Signed-off-by: José Expósito <jose.exposito89@gmail.com >
Link: https://lore.kernel.org/r/20251016175618.10051-3-jose.exposito89@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
2025-10-22 13:19:25 +02:00
José Expósito
7965d1c535
drm/vkms: Expose device creation and destruction
...
In preparation for configfs support, expose vkms_create() and
vkms_destroy().
Tested-by: Mark Yacoub <markyacoub@google.com >
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Reviewed-by: Harry Wentland <harry.wentland@amd.com >
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
Co-developed-by: Louis Chauvet <louis.chauvet@bootlin.com >
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com >
Signed-off-by: José Expósito <jose.exposito89@gmail.com >
Link: https://lore.kernel.org/r/20251016175618.10051-2-jose.exposito89@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com >
2025-10-22 13:19:25 +02:00
Marcus Folkesson
7e73cefd2b
drm/sitronix/st7571-i2c: remove unneeded semicolon
...
Fix style issue reported by Kernel test robot.
Reported-by: kernel test robot <lkp@intel.com >
Closes: https://lore.kernel.org/oe-kbuild-all/202510221125.Cg0sM4xJ-lkp@intel.com/
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de >
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com >
Link: https://lore.kernel.org/r/20251022-st7571-semicolon-v1-1-83d322618ff4@gmail.com
2025-10-22 09:56:52 +02:00
Chen-Yu Tsai
caa2f6ee91
MAINTAINERS: Update Chen-Yu's email address
...
The email forwarder I'm using has run into severe problems with Gmail
lately. Switch over to my kernel.org address for kernel development.
Acked-by: Lee Jones <lee@kernel.org >
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com >
Link: https://patch.msgid.link/20251020045603.2573544-1-wens@kernel.org
Signed-off-by: Chen-Yu Tsai <wens@kernel.org >
2025-10-22 15:50:46 +08:00
Marek Vasut
c376a69437
dt-bindings: display: bridge: renesas,dsi-csi2-tx: Allow panel@ subnode
...
This controller can have both bridges and panels connected to it. In
order to describe panels properly in DT, pull in dsi-controller.yaml
and disallow only unevaluatedProperties, because the panel node is
optional. Include example binding with panel.
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org >
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org >
Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com >
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com >
Link: https://lore.kernel.org/r/20250904210147.186728-4-marek.vasut+renesas@mailbox.org
2025-10-22 09:54:28 +03:00
Marek Vasut
c1a7cc00cd
dt-bindings: gpu: img,powervr-rogue: Rework the allOf section
...
Rework the current allOf: section such that all handling of
clocks/clock-names properties happens first, and all handling
of power-domains/power-domain-names happens second.
This allows the allOf section to limit various GPU models to
matching clocks count in the first half, and apply the same
for power-domains count in the second half, without conflating
the two limits together.
This makes addition of GPU models with different clocks and
power-domains count easier. No functional change intended.
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org >
Acked-by: Conor Dooley <conor.dooley@microchip.com >
Reviewed-by: Matt Coster <matt.coster@imgtec.com >
Link: https://lore.kernel.org/r/20251018130147.12831-2-marek.vasut+renesas@mailbox.org
Signed-off-by: Matt Coster <matt.coster@imgtec.com >
2025-10-21 14:22:20 +01:00
Marek Vasut
9471a27480
dt-bindings: gpu: img,powervr-rogue: Drop useless power domains items
...
The power-domains items: list is not very informative, replace it
with plain minItems/maxItems instead.
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org >
Acked-by: Conor Dooley <conor.dooley@microchip.com >
Reviewed-by: Matt Coster <matt.coster@imgtec.com >
Link: https://lore.kernel.org/r/20251018130147.12831-1-marek.vasut+renesas@mailbox.org
Signed-off-by: Matt Coster <matt.coster@imgtec.com >
2025-10-21 14:22:16 +01:00
Lizhi Hou
7ea0468380
accel/amdxdna: Support firmware debug buffer
...
To collect firmware debug information, the userspace application allocates
a AMDXDNA_BO_DEV buffer object through DRM_IOCTL_AMDXDNA_CREATE_BO.
Then it associates the buffer with the hardware context through
DRM_IOCTL_AMDXDNA_CONFIG_HWCTX which requests firmware to bind the buffer
through a mailbox command. The firmware then writes the debug data into
this buffer. The buffer can be mapped into userspace so that
applications can retrieve and analyze the firmware debug information.
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org >
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com >
Link: https://lore.kernel.org/r/20251016203016.819441-1-lizhi.hou@amd.com
2025-10-20 09:07:12 -07:00
Adrián Larumbe
fb4f1cb3e0
MAINTAINERS: Panfrost: Add Steven Price and Adrian Larumbe
...
Recast Steven Price as Panfrost driver maintainer.
Also add Adrian Larumbe in the same role.
Reviewed-by: Steven Price <steven.price@arm.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com >
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com >
Link: https://lore.kernel.org/r/20251019145225.3621989-13-adrian.larumbe@collabora.com
Signed-off-by: Steven Price <steven.price@arm.com >
2025-10-20 16:05:18 +01:00
Adrián Larumbe
32dd00f17c
drm/panfrost: Rename panfrost_job functions to reflect real role
...
panfrost_job_* prefixed functions in panfrost_job.c deal with both
panfrost_job objects and also the more general JM (Job Manager) side of
the device itself. This is confusing.
Reprefix functions that program the JM to panfrosot_jm_* instead.
Reviewed-by: Steven Price <steven.price@arm.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com >
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com >
Link: https://lore.kernel.org/r/20251019145225.3621989-12-adrian.larumbe@collabora.com
Signed-off-by: Steven Price <steven.price@arm.com >
2025-10-20 16:05:18 +01:00
Adrián Larumbe
954c2621c0
drm/panfrost: Remove unused device property
...
The as_in_use_mask device state variable is no longer in use.
Reviewed-by: Steven Price <steven.price@arm.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com >
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com >
Link: https://lore.kernel.org/r/20251019145225.3621989-11-adrian.larumbe@collabora.com
Signed-off-by: Steven Price <steven.price@arm.com >
2025-10-20 16:05:17 +01:00
Adrián Larumbe
84b8cfef4f
drm/panfrost: Add forward declaration and types header
...
This is to make LLVM syntactic analysers happy.
Reviewed-by: Steven Price <steven.price@arm.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com >
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com >
Link: https://lore.kernel.org/r/20251019145225.3621989-10-adrian.larumbe@collabora.com
Signed-off-by: Steven Price <steven.price@arm.com >
2025-10-20 16:05:17 +01:00
Adrián Larumbe
42e7ab3bac
drm/panfrost: Make re-enabling job interrupts at device reset optional
...
Rather than remasking interrupts after a device reset in the main reset
path, allow selecting whether to do this with an additional bool parameter.
To this end, split reenabling job interrupts into two functions, one that
clears the interrupts and another one which unmasks them conditionally.
Reviewed-by: Steven Price <steven.price@arm.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com >
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com >
Link: https://lore.kernel.org/r/20251019145225.3621989-9-adrian.larumbe@collabora.com
Signed-off-by: Steven Price <steven.price@arm.com >
2025-10-20 16:05:17 +01:00
Adrián Larumbe
fc237ec882
drm/panfrost: Don't rework job IRQ enable mask in the enable path
...
Up until now, panfrost_job_enable_interrupts() would always recalculate the
same job IRQ enablement mask, which is effectively a constant.
Replace it with a compile-time constant value, and also in another couple
places where an equivalent expression was being used.
Reviewed-by: Steven Price <steven.price@arm.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com >
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com >
Link: https://lore.kernel.org/r/20251019145225.3621989-8-adrian.larumbe@collabora.com
Signed-off-by: Steven Price <steven.price@arm.com >
2025-10-20 16:05:17 +01:00
Adrián Larumbe
4da352cf8f
drm/panfrost: Handle page mapping failure
...
When mapping the pages of a BO, either a heap type at page fault time or
else a non-heap BO at object creation time, if the ARM page table mapping
function fails, we unmap what had been mapped so far and bail out.
Reviewed-by: Steven Price <steven.price@arm.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com >
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com >
Link: https://lore.kernel.org/r/20251019145225.3621989-7-adrian.larumbe@collabora.com
Signed-off-by: Steven Price <steven.price@arm.com >
2025-10-20 16:05:17 +01:00
Adrián Larumbe
3d7c626716
drm/panfrost: Check sgt to know whether pages are already mapped
...
In the MMU's page fault ISR for a heap object, determine whether the
faulting address belongs to a 2MiB block that was already mapped by
checking its corresponding sgt in the Panfrost BO.
This is done in preparation for a future commit in which the MMU mapping
helper might fail, but the page array is left populated, so this cannot
be used as a check for an early bail-out.
Reviewed-by: Steven Price <steven.price@arm.com >
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com >
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com >
Link: https://lore.kernel.org/r/20251019145225.3621989-6-adrian.larumbe@collabora.com
Signed-off-by: Steven Price <steven.price@arm.com >
2025-10-20 16:05:17 +01:00
Adrián Larumbe
f45f73c68c
drm/panfrost: Handle error when allocating AS number
...
If we reach the beginning of the LRU AS list, then return an error.
Reviewed-by: Steven Price <steven.price@arm.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com >
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com >
Link: https://lore.kernel.org/r/20251019145225.3621989-5-adrian.larumbe@collabora.com
Signed-off-by: Steven Price <steven.price@arm.com >
2025-10-20 16:05:17 +01:00
Adrián Larumbe
616c5b6fe3
drm/panfrost: Handle job HW submit errors
...
Avoid waiting for the DRM scheduler job timedout handler, and instead, let
the DRM scheduler core signal the error fence immediately when HW job
submission fails.
That means we must also decrement the runtime-PM refcnt for the device,
because the job will never be enqueued or inflight.
Reviewed-by: Steven Price <steven.price@arm.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com >
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com >
Link: https://lore.kernel.org/r/20251019145225.3621989-4-adrian.larumbe@collabora.com
Signed-off-by: Steven Price <steven.price@arm.com >
2025-10-20 16:05:16 +01:00
Adrián Larumbe
16dd7e0305
drm/panfrost: Handle inexistent GPU during probe
...
Just in case we're dealing with a yet not recognised device.
Reviewed-by: Steven Price <steven.price@arm.com >
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com >
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Link: https://lore.kernel.org/r/20251019145225.3621989-3-adrian.larumbe@collabora.com
Signed-off-by: Steven Price <steven.price@arm.com >
2025-10-20 16:05:16 +01:00
Adrián Larumbe
5c0c825ae4
drm/panfrost: Replace DRM driver allocation method with newer one
...
Drop the deprecated DRM driver allocation method in favour of
devm_drm_dev_alloc(). Overall just make it the same as in Panthor.
Also discard now superfluous generic and platform device pointers inside
the main panfrost device structure.
Some ancient checkpatch issues unearthed as a result of these changes
were also fixed, like lines too long or double assignment in one line.
Reviewed-by: Steven Price <steven.price@arm.com >
Acked-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com >
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com >
Link: https://lore.kernel.org/r/20251019145225.3621989-2-adrian.larumbe@collabora.com
Signed-off-by: Steven Price <steven.price@arm.com >
2025-10-20 16:05:16 +01:00
Zack McKevitt
ddf70cb6f8
accel/qaic: Fix mismatched types in min()
...
Use min_t() instead of min() to resolve compiler warnings for mismatched
types.
Signed-off-by: Zack McKevitt <zmckevit@qti.qualcomm.com >
Signed-off-by: Youssef Samir <youssef.abdulrahman@oss.qualcomm.com >
Reviewed-by: Carl Vanderlip <carl.vanderlip@oss.qualcomm.com >
Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com >
Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com >
Signed-off-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com >
Link: https://lore.kernel.org/r/20251015153715.184143-1-youssef.abdulrahman@oss.qualcomm.com
2025-10-20 08:38:42 -06:00
Zack McKevitt
9cfe6abee1
accel/qaic: Use check_add_overflow in sahara for 64b types
...
Use check_add_overflow instead of size_add in sahara when
64b types are being added to ensure compatibility with 32b
systems. The size_add function parameters are of size_t, so
64b data types may be truncated when cast to size_t on 32b
systems. When using check_add_overflow, no type casts are made,
making it a more portable option.
Signed-off-by: Zack McKevitt <zmckevit@qti.qualcomm.com >
Signed-off-by: Youssef Samir <youssef.abdulrahman@oss.qualcomm.com >
Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com >
Reviewed-by: Carl Vanderlip <carl.vanderlip@oss.qualcomm.com >
Signed-off-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com >
Link: https://lore.kernel.org/r/20251015165408.213645-1-youssef.abdulrahman@oss.qualcomm.com
2025-10-20 08:30:37 -06:00
Daniel Stone
4e39740d77
drm/rockchip: Use temporary variables
...
Brevity is good.
Signed-off-by: Daniel Stone <daniels@collabora.com >
Signed-off-by: Heiko Stuebner <heiko@sntech.de >
Link: https://lore.kernel.org/r/20251015110042.41273-6-daniels@collabora.com
2025-10-20 15:56:13 +02:00
Daniel Stone
33cbeea62f
drm/rockchip: Rename variables for clarity
...
actual_w and actual_h were the clipped source width, so rename them to
fit the use.
Signed-off-by: Daniel Stone <daniels@collabora.com >
Signed-off-by: Heiko Stuebner <heiko@sntech.de >
Link: https://lore.kernel.org/r/20251015110042.41273-5-daniels@collabora.com
2025-10-20 15:56:12 +02:00
Daniel Stone
70e3f77cb5
drm/rockchip: Return error code for errors
...
Instead of silently disabling small planes, refuse to create them at
all.
Signed-off-by: Daniel Stone <daniels@collabora.com >
Signed-off-by: Heiko Stuebner <heiko@sntech.de >
Link: https://lore.kernel.org/r/20251015110042.41273-4-daniels@collabora.com
2025-10-20 15:56:11 +02:00
Daniel Stone
4bfaa85bb5
drm/rockchip: Declare framebuffer width/height bounds
...
The VOP2 has limitations on its input and output sizes. The clipped
display region must be at least 4px in each dimension for both
framebuffer source and plane destination, and the clipped source region
must be no greater than a per-version limit.
It is never valid for VOP2 to have a framebuffer which is less than four
pixels in either dimension, so declare that as our min width/height,
enforced by AddFB failing if the user tries. It can theoretically be
valid to have a single large framebuffer of which only certain clipped
regions are shown, but this is a very uncommon case. Declaring to
userspace that the framebuffer's maximum width and height is the maximum
source clip helps it make better decisions as to which mode to use,
instead of trying unsupported sizes and having to fall back.
Signed-off-by: Daniel Stone <daniels@collabora.com >
Signed-off-by: Heiko Stuebner <heiko@sntech.de >
Link: https://lore.kernel.org/r/20251015110042.41273-3-daniels@collabora.com
2025-10-20 15:56:10 +02:00
Daniel Stone
f233921d98
drm/rockchip: Demote normal drm_err to debug
...
A plane check failing is a normal and expected condition, as userspace
isn't aware of the specific constraints and will try any and every
combination until one succeeds. Push this down to a debug message, so
users can see it if they want to, but make sure we don't spam the log
during normal operation.
Fixes: 604be85547daniels@collabora.com >
Signed-off-by: Heiko Stuebner <heiko@sntech.de >
Link: https://lore.kernel.org/r/20251015110042.41273-2-daniels@collabora.com
2025-10-20 15:56:09 +02:00
Maxime Ripard
4f5f8baf73
dma-buf: heaps: cma: Create CMA heap for each CMA reserved region
...
Aside from the main CMA region, it can be useful to allow userspace to
allocate from the other CMA reserved regions.
Indeed, those regions can have specific properties that can be useful to
a specific us-case.
For example, one of them platform I've been with has ECC enabled on the
entire memory but for a specific region. Using that region to allocate
framebuffers can be particular beneficial because enabling the ECC has a
performance and memory footprint cost.
Thus, exposing these regions as heaps user-space can allocate from and
import wherever needed allows to cover that use-case.
For now, only shared-dma-pools regions with the reusable property (ie,
backed by CMA) are supported, but eventually we'll want to support other
DMA pools types.
Since we collected all the CMA regions created during boot, we can
simply iterate over all of them to create the heaps.
This has a weird interaction with the recent work on the CMA name, in
particular the backward compatibility code created by commit
854acbe75ftjmercier@google.com >
Signed-off-by: Maxime Ripard <mripard@kernel.org >
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org >
[sumits: rebased the doc to latest]
Link: https://lore.kernel.org/r/20251013-dma-buf-ecc-heap-v8-5-04ce150ea3d9@kernel.org
2025-10-18 21:31:22 +05:30
Maxime Ripard
8f1fc1bf1a
dma: contiguous: Reserve default CMA heap
...
The CMA code, in addition to the reserved-memory regions in the device
tree, will also register a default CMA region if the device tree doesn't
provide any, with its size and position coming from either the kernel
command-line or configuration.
Let's register that one for use to create a heap for it.
Reviewed-by: T.J. Mercier <tjmercier@google.com >
Signed-off-by: Maxime Ripard <mripard@kernel.org >
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com >
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org >
Link: https://lore.kernel.org/r/20251013-dma-buf-ecc-heap-v8-4-04ce150ea3d9@kernel.org
2025-10-18 21:31:21 +05:30
Maxime Ripard
84a593066a
dma: contiguous: Register reusable CMA regions at boot
...
In order to create a CMA dma-buf heap instance for each CMA heap region
in the system, we need to collect all of them during boot.
They are created from two main sources: the reserved-memory regions in
the device tree, and the default CMA region created from the
configuration or command line parameters, if no default region is
provided in the device tree.
Let's collect all the device-tree defined CMA regions flagged as
reusable.
Reviewed-by: T.J. Mercier <tjmercier@google.com >
Signed-off-by: Maxime Ripard <mripard@kernel.org >
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com >
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org >
Link: https://lore.kernel.org/r/20251013-dma-buf-ecc-heap-v8-3-04ce150ea3d9@kernel.org
2025-10-18 21:31:21 +05:30
Maxime Ripard
8b5690d5c9
dma-buf: heaps: cma: Register list of CMA regions at boot
...
In order to create a CMA heap instance for each CMA region found in the
system, we need to register each of these instances.
While it would appear trivial, the CMA regions are created super early
in the kernel boot process, before most of the subsystems are
initialized. Thus, we can't just create an exported function to create a
heap from the CMA region being initialized.
What we can do however is create a two-step process, where we collect
all the CMA regions into an array early on, and then when we initialize
the heaps we iterate over that array and create the heaps from the CMA
regions we collected.
Reviewed-by: T.J. Mercier <tjmercier@google.com >
Signed-off-by: Maxime Ripard <mripard@kernel.org >
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org >
Link: https://lore.kernel.org/r/20251013-dma-buf-ecc-heap-v8-2-04ce150ea3d9@kernel.org
2025-10-18 21:31:21 +05:30
Maxime Ripard
2034134de6
doc: dma-buf: List the heaps by name
...
Since we're going to introduce multiple instances of the CMA heap
driver, there's no single CMA heap anymore.
Let's use the heap name instead to differentiate between all the heaps
available in the system.
While we're at it, let's also rework the backward compatibility part to
make it easier to amend later on.
Reviewed-by: T.J. Mercier <tjmercier@google.com >
Signed-off-by: Maxime Ripard <mripard@kernel.org >
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org >
[sumits: rebased to latest Doc]
Link: https://lore.kernel.org/r/20251013-dma-buf-ecc-heap-v8-1-04ce150ea3d9@kernel.org
2025-10-18 21:31:21 +05:30
Thomas Zimmermann
7910d69376
drm/client: Remove holds_console_lock parameter from suspend/resume
...
No caller of the client resume/suspend helpers holds the console
lock. The last such cases were removed from radeon in the patch
series at [1]. Now remove the related parameter and the TODO items.
v2:
- update placeholders for CONFIG_DRM_CLIENT=n
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Link: https://patchwork.freedesktop.org/series/151624/ # [1]
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com >
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com >
Reviewed-by: Petr Vorel <pvorel@suse.cz >
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com >
Acked-by: Danilo Krummrich <dakr@kernel.org >
Reviewed-by: Lyude Paul <lyude@redhat.com >
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com >
Link: https://lore.kernel.org/r/20251001143709.419736-1-tzimmermann@suse.de
2025-10-18 17:35:09 +02:00
Lizhi Hou
b291e4f1a4
accel/amdxdna: Support getting last hardware error
...
Add new parameter DRM_AMDXDNA_HW_LAST_ASYNC_ERR to get array IOCTL. When
hardware reports an error, the driver save the error information and
timestamp. This new get array parameter retrieves the last error.
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org >
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com >
Link: https://lore.kernel.org/r/20251014234119.628453-1-lizhi.hou@amd.com
2025-10-16 09:32:48 -07:00
