torvalds/linux
3
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-04-08 15:39:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

bcachefs: Fix check_inode_hash_info_matches_root()

Browse Source 
Can't use memcmp() when the struct contains padding.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
This commit is contained in:
Kent Overstreet
2025-01-15 12:17:28 -05:00
parent a4e11cea27
commit ff0b7ed607
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
fs/bcachefs/str_hash.c
View File

@@ -167,10 +167,19 @@ found:;
goto err;
struct bch_hash_info hash2 = bch2_hash_info_init(c, &inode);
if (memcmp(hash_info, &hash2, sizeof(hash2))) {
if (hash_info->type != hash2.type ||
memcmp(&hash_info->siphash_key, &hash2.siphash_key, sizeof(hash2.siphash_key))) {
ret = repair_inode_hash_info(trans, &inode);
if (!ret) {
bch_err(c, "inode hash info mismatch with root, but mismatch not found");
bch_err(c, "inode hash info mismatch with root, but mismatch not found\n"
"%u %llx %llx\n"
"%u %llx %llx",
hash_info->type,
hash_info->siphash_key.k0,
hash_info->siphash_key.k1,
hash2.type,
hash2.siphash_key.k0,
hash2.siphash_key.k1);
ret = -BCH_ERR_fsck_repair_unimplemented;
}
}