torvalds/linux
3
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-03-22 07:27:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

iio: gyro: mpu3050-core: fix pm_runtime error handling

Browse Source 
The return value of pm_runtime_get_sync() is not checked, allowing
the driver to access hardware that may fail to resume. The device
usage count is also unconditionally incremented. Use
pm_runtime_resume_and_get() which propagates errors and avoids
incrementing the usage count on failure.

In preenable, add pm_runtime_put_autosuspend() on set_8khz_samplerate()
failure since postdisable does not run when preenable fails.

Fixes: 3904b28efb ("iio: gyro: Add driver for the MPU-3050 gyroscope")
Reviewed-by: Linus Walleij <linusw@kernel.org>
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Antoniu Miclaus
2026-02-16 11:57:56 +02:00
committed by Jonathan Cameron
parent 91f950b4cb
commit acc3949aab
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/iio/gyro/mpu3050-core.c
View File

@@ -322,7 +322,9 @@ static int mpu3050_read_raw(struct iio_dev *indio_dev,
}
case IIO_CHAN_INFO_RAW:
/* Resume device */
pm_runtime_get_sync(mpu3050->dev);
ret = pm_runtime_resume_and_get(mpu3050->dev);
if (ret)
return ret;
mutex_lock(&mpu3050->lock);
ret = mpu3050_set_8khz_samplerate(mpu3050);
@@ -647,14 +649,20 @@ out_trigger_unlock:
static int mpu3050_buffer_preenable(struct iio_dev *indio_dev)
{
struct mpu3050 *mpu3050 = iio_priv(indio_dev);
int ret;
pm_runtime_get_sync(mpu3050->dev);
ret = pm_runtime_resume_and_get(mpu3050->dev);
if (ret)
return ret;
/* Unless we have OUR trigger active, run at full speed */
if (!mpu3050->hw_irq_trigger)
return mpu3050_set_8khz_samplerate(mpu3050);
if (!mpu3050->hw_irq_trigger) {
ret = mpu3050_set_8khz_samplerate(mpu3050);
if (ret)
pm_runtime_put_autosuspend(mpu3050->dev);
}
return 0;
return ret;
}
static int mpu3050_buffer_postdisable(struct iio_dev *indio_dev)