torvalds/linux
3
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-03-22 07:27:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

drm/i915/dmc: Fixup TGL/ADL-S HRR event handler type

Browse Source 
TGL/ADL-S DMC firmware incorrectly uses the undelayed vblank
trigger for the HRR event, when it should be using the delayed
vblank trigger.

Fixed DMC firmware was never relaesed and isntead the Windows
driver just fixes this up by hand. Follow suit.

Not that we actually enable the HRR event currently. But let's
fix up the event ID, just in case someone ever needs to enable
this.

Tested-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20251022100718.24803-3-ville.syrjala@linux.intel.com
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Reviewed-by: Imre Deak <imre.deak@intel.com>
Tested-by: Imre Deak <imre.deak@intel.com>
This commit is contained in:
Ville Syrjälä
2025-10-22 13:07:17 +03:00
parent 4df3b340ff
commit 9c2503beb8
1 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/gpu/drm/i915/display/intel_dmc.c
View File

@@ -577,6 +577,21 @@ static bool fixup_dmc_evt(struct intel_display *display,
return true;
}
/*
* TGL/ADL-S DMC firmware incorrectly uses the undelayed vblank
* event for the HRR handler, when it should be using the delayed
* vblank event instead. Fixed firmware was never released
* so the Windows driver just hacks around it by overriding
* the event ID. Do the same.
*/
if ((display->platform.tigerlake || display->platform.alderlake_s) &&
is_event_handler(display, dmc_id, MAINDMC_EVENT_VBLANK_A, reg_ctl, *data_ctl)) {
*data_ctl &= ~DMC_EVT_CTL_EVENT_ID_MASK;
*data_ctl |= REG_FIELD_PREP(DMC_EVT_CTL_EVENT_ID_MASK,
MAINDMC_EVENT_VBLANK_DELAYED_A);
return true;
}
return false;
}
@@ -598,7 +613,7 @@ static bool disable_dmc_evt(struct intel_display *display,
/* also disable the HRR event on the main DMC on TGL/ADLS */
if ((display->platform.tigerlake || display->platform.alderlake_s) &&
is_event_handler(display, dmc_id, MAINDMC_EVENT_VBLANK_A, reg, data))
is_event_handler(display, dmc_id, MAINDMC_EVENT_VBLANK_DELAYED_A, reg, data))
return true;
return false;