torvalds/linux
3
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-03-22 07:27:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

pidfs: avoid misleading break

Browse Source 
The break would only break out of the scoped_guard() loop, not the
switch statement. It still works correct as is ofc but let's avoid the
confusion.

Reported-by: David Lechner <dlechner@baylibre.com>
Link:: https://lore.kernel.org/cd2153f1-098b-463c-bbc1-5c6ca9ef1f12@baylibre.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Christian Brauner
2026-02-24 12:09:00 +01:00
parent fdcfce9307
commit 4a1ddb0f1c
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
fs/pidfs.c
View File

@@ -577,9 +577,8 @@ static long pidfd_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
struct user_namespace *user_ns;
user_ns = task_cred_xxx(task, user_ns);
if (!ns_ref_get(user_ns))
break;
ns_common = to_ns_common(user_ns);
if (ns_ref_get(user_ns))
ns_common = to_ns_common(user_ns);
}
#endif
break;
@@ -589,9 +588,8 @@ static long pidfd_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
struct pid_namespace *pid_ns;
pid_ns = task_active_pid_ns(task);
if (!ns_ref_get(pid_ns))
break;
ns_common = to_ns_common(pid_ns);
if (ns_ref_get(pid_ns))
ns_common = to_ns_common(pid_ns);
}
#endif
break;