torvalds/linux
3
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-03-22 07:27:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

cxl/region: Use do_div() for 64-bit modulo operation

Browse Source 
div64_u64_rem() was the wrong choice for doing a modulo operation
and it was used incorrectly, causing a kernel oops by passing NULL
as the remainder parameter. Replace it with the do_div() helper
that does the intended math (gran_offset = offset % gran) and is
architecture safe.

This bug appeared during testing of unaligned address translations.
The visibility to userspace would be limited to folks doing poison
injection or clear by HPA on unaligned regions.

Fixes: 78b50b598462 ("cxl/region: Translate HPA to DPA and memdev in unaligned regions")
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Link: https://patch.msgid.link/20260117044732.567831-1-alison.schofield@intel.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
This commit is contained in:
Alison Schofield
2026-01-16 20:47:30 -08:00
committed by Dave Jiang
parent b51792fd91
commit 064c098790
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/cxl/core/region.c
View File

@@ -3324,6 +3324,7 @@ static int unaligned_region_offset_to_dpa_result(struct cxl_region *cxlr,
u64 interleave_width, interleave_index;
u64 gran, gran_offset, dpa_offset;
u64 hpa = p->res->start + offset;
u64 tmp = offset;
/*
* Unaligned addresses are not algebraically invertible. Calculate
@@ -3333,7 +3334,7 @@ static int unaligned_region_offset_to_dpa_result(struct cxl_region *cxlr,
gran = cxld->interleave_granularity;
interleave_width = gran * cxld->interleave_ways;
interleave_index = div64_u64(offset, interleave_width);
gran_offset = div64_u64_rem(offset, gran, NULL);
gran_offset = do_div(tmp, gran);
dpa_offset = interleave_index * gran + gran_offset;