Paolo Abeni dc010e1b4b
xfrm: reduce struct sec_path size ...
The mentioned struct has an hole and uses unnecessary wide type to
store MAC length and indexes of very small arrays.
It's also embedded into the skb_extensions, and the latter, due
to recent CAN changes, may exceeds the 192 bytes mark (3 cachelines
on x86_64 arch) on some reasonable configurations.
Reordering and the sec_path fields, shrinking xfrm_offload.orig_mac_len
to 16 bits and xfrm_offload.{len,olen,verified_cnt} to u8, we can save
16 bytes and keep skb_extensions size under control.
Before:
struct sec_path {
int len;
int olen;
int verified_cnt;
/* XXX 4 bytes hole, try to pack */$
struct xfrm_state * xvec[6];
struct xfrm_offload ovec[1];
/* size: 88, cachelines: 2, members: 5 */
/* sum members: 84, holes: 1, sum holes: 4 */
/* last cacheline: 24 bytes */
};
After:
struct sec_path {
struct xfrm_state * xvec[6];
struct xfrm_offload ovec[1];
/* typedef u8 -> __u8 */ unsigned char len;
/* typedef u8 -> __u8 */ unsigned char olen;
/* typedef u8 -> __u8 */ unsigned char verified_cnt;
/* size: 72, cachelines: 2, members: 5 */
/* padding: 1 */
/* last cacheline: 8 bytes */
};
Signed-off-by: Paolo Abeni <pabeni@redhat.com >
Reviewed-by: Florian Westphal <fw@strlen.de >
Reviewed-by: Steffen Klassert <steffen.klassert@secunet.com >
Link: https://patch.msgid.link/83846bd2e3fa08899bd0162e41bfadfec95e82ef.1770398071.git.pabeni@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org >
2026-02-10 20:21:48 -08:00
2025-11-03 16:49:53 +09:00
2026-01-29 13:36:35 -05:00
2024-10-08 15:33:49 -07:00
2026-02-04 20:39:58 -08:00
2025-10-29 20:04:55 -07:00
2026-01-13 19:14:36 -08:00
2026-02-06 20:50:03 -08:00
2026-01-27 10:45:38 +01:00
2026-01-28 19:32:26 -08:00
2026-01-20 18:06:01 -08:00
2024-10-24 16:03:40 +02:00
2026-01-12 19:29:11 -08:00
2025-11-07 18:53:57 -08:00
2025-11-14 18:00:34 -08:00
2025-08-28 16:46:23 -07:00
2025-09-02 15:52:24 -07:00
2025-11-03 17:40:46 -08:00
2025-04-24 17:03:45 -07:00
2025-07-08 18:05:25 -07:00
2026-01-27 10:45:38 +01:00
2025-07-02 14:22:02 -07:00
2022-07-22 12:53:22 +01:00
2023-03-21 21:32:18 -07:00
2026-01-30 19:19:39 -08:00
2022-08-09 22:14:02 -07:00
2021-12-13 12:34:09 +00:00
2025-09-09 10:56:02 +02:00
2024-08-26 09:37:22 -07:00
2025-09-09 10:56:02 +02:00
2026-01-29 17:28:54 -08:00
2025-02-27 14:03:14 +01:00
2024-10-02 17:23:23 -04:00
2026-02-05 11:58:39 +01:00
2022-11-16 11:31:47 +02:00
2026-02-02 10:11:07 +01:00
2024-03-06 21:01:26 +01:00
2025-05-30 19:53:51 -07:00
2024-10-02 17:23:23 -04:00
2025-09-14 11:55:04 -07:00
2021-12-22 15:03:47 -08:00
2022-07-22 12:53:22 +01:00
2023-07-14 20:39:29 -07:00
2022-07-24 18:39:17 -06:00
2023-07-27 17:17:32 -07:00
2022-07-22 12:53:22 +01:00
2023-01-20 09:33:22 +00:00
2025-11-20 19:01:22 -08:00
2026-01-13 10:12:11 +01:00
2025-02-11 11:58:17 +01:00
2023-10-24 13:08:14 -07:00
2026-02-10 15:30:11 +01:00
2024-05-08 10:35:09 +01:00
2024-08-26 09:37:23 -07:00
2025-09-14 14:28:12 -07:00
2024-05-29 17:34:49 -07:00
2026-02-02 17:49:29 -08:00
2024-11-13 18:49:50 -08:00
2024-08-26 09:37:23 -07:00
2022-07-22 12:53:22 +01:00
2024-04-01 21:27:08 -07:00
2022-07-22 12:53:22 +01:00
2021-12-06 16:06:02 -08:00
2024-10-11 15:35:05 -07:00
2025-04-15 17:54:56 -07:00
2022-07-28 22:21:54 -07:00
2024-07-15 09:14:39 -07:00
2026-02-10 15:30:11 +01:00
2025-08-26 17:34:31 -07:00
2023-04-12 16:40:39 -07:00
2022-12-01 15:09:10 +01:00
2023-08-08 15:58:23 -07:00
2022-07-22 12:53:22 +01:00
2025-09-03 15:16:49 -07:00
2022-10-31 10:43:04 +00:00
2024-04-01 10:49:28 +01:00
2026-01-21 19:28:32 -08:00
2023-06-10 00:11:41 -07:00
2024-05-07 01:35:55 +02:00
2022-07-22 12:53:22 +01:00
2023-07-28 14:07:59 -07:00
2026-01-13 10:12:11 +01:00
2024-08-26 09:37:23 -07:00
2025-09-11 12:22:38 +02:00
2024-05-08 10:35:09 +01:00
2025-10-30 08:38:51 +01:00
2023-11-20 11:43:03 +01:00
2024-02-26 18:40:34 -08:00
2025-03-24 12:10:13 -07:00
2025-09-22 11:38:43 -07:00
2025-11-04 19:10:33 -08:00
2025-11-25 19:28:29 -08:00
2025-08-26 17:34:31 -07:00
2026-02-03 15:13:24 +01:00
2025-12-10 01:15:27 -08:00
2025-09-23 10:12:15 +02:00
2026-02-02 17:49:30 -08:00
2025-09-23 10:12:15 +02:00
2024-12-17 19:37:00 -08:00
2024-02-28 11:19:41 +00:00
2021-11-16 13:16:54 +00:00
2025-04-24 09:29:56 +02:00
2026-02-02 17:49:29 -08:00
2025-07-02 14:32:30 -07:00
2025-08-26 17:34:31 -07:00
2026-01-08 18:02:35 -08:00
2025-08-13 08:34:33 +02:00
2025-11-04 19:10:33 -08:00
2025-03-21 17:36:49 +08:00
2022-07-22 12:53:22 +01:00
2025-12-10 01:15:27 -08:00
2025-11-04 19:10:33 -08:00
2026-02-06 20:50:13 -08:00
2024-10-09 08:53:01 +02:00
2025-08-13 18:18:33 -07:00
2026-02-02 17:09:11 -08:00
2024-12-06 17:43:08 -08:00
2023-08-04 15:33:17 -07:00
2023-08-04 15:33:17 -07:00
2024-07-15 08:51:01 -07:00
2023-07-20 10:46:28 +02:00
2024-08-26 09:37:23 -07:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2024-07-15 08:51:19 -07:00
2021-11-07 19:25:29 +00:00
2025-07-02 14:32:30 -07:00
2026-02-02 10:11:18 +01:00
2024-10-02 17:23:23 -04:00
2025-01-20 12:20:42 +00:00
2025-07-15 12:08:39 +02:00
2024-11-09 09:04:54 -08:00
2022-07-22 12:53:22 +01:00
2025-04-15 08:21:46 -07:00
2022-11-18 12:14:55 +00:00
2022-07-22 12:53:22 +01:00
2025-07-10 15:27:32 -07:00
2024-11-09 13:22:57 -08:00
2025-10-24 17:57:20 -07:00
2024-11-30 13:41:50 -08:00
2026-02-06 20:01:31 -08:00
2024-10-10 08:30:22 -07:00
2021-12-10 06:38:26 -08:00
2025-05-22 09:42:41 -07:00
2025-03-12 13:32:35 -07:00
2026-01-23 11:49:02 -08:00
2026-01-20 18:06:01 -08:00
2022-07-22 12:53:22 +01:00
2023-11-20 10:15:16 -08:00
2024-11-21 08:28:08 -08:00
2025-07-02 15:39:04 -07:00
2026-01-25 13:18:53 -08:00
2022-07-22 12:53:22 +01:00
2025-04-24 09:29:56 +02:00
2025-10-20 17:13:40 -07:00
2023-07-14 20:39:29 -07:00
2025-06-13 18:17:08 -07:00
2023-07-14 20:39:30 -07:00
2025-11-04 19:10:33 -08:00
2025-11-24 18:53:14 -08:00
2026-02-05 09:32:45 -08:00
2022-07-22 12:53:22 +01:00
2025-10-16 12:04:47 -07:00
2024-03-07 21:12:43 -08:00
2024-07-11 18:11:31 -07:00
2022-07-22 12:53:22 +01:00
2025-09-18 12:32:06 +02:00
2025-09-14 11:35:17 -07:00
2023-03-17 08:56:37 +00:00
2024-08-26 09:37:23 -07:00
2024-08-26 09:37:23 -07:00
2026-02-05 09:23:06 -08:00
2025-08-27 07:43:08 -07:00
2025-08-29 19:36:32 -07:00
2023-06-19 11:32:58 -07:00
2025-09-03 15:08:20 -07:00
2023-07-14 20:39:30 -07:00
2025-04-11 18:58:10 -07:00
2025-02-21 15:28:03 -08:00
2025-11-25 16:10:32 +01:00
2026-01-13 11:54:29 +01:00
2025-07-04 09:32:35 +02:00
2025-04-11 18:58:10 -07:00
2025-08-26 18:11:29 -07:00
2024-06-24 16:41:23 -07:00
2024-05-30 18:29:38 -07:00
2025-11-06 13:38:11 +01:00
2025-11-10 11:19:41 -08:00
2025-09-08 18:06:21 -07:00
2024-08-02 17:16:59 -07:00
2026-01-30 17:15:51 -08:00
2023-10-04 11:49:20 -07:00
2022-07-22 12:53:22 +01:00
2025-05-05 16:48:12 -07:00
2024-02-16 09:36:37 +00:00
2024-02-14 10:49:37 +01:00
2025-09-11 19:05:56 -07:00
2026-02-03 15:13:25 +01:00
2023-12-04 14:45:26 -08:00
2026-02-06 20:12:11 -08:00
2025-07-11 11:00:57 -07:00
2025-08-25 17:53:35 -07:00
2023-07-28 14:07:59 -07:00
2025-10-31 06:46:03 -07:00
2023-08-01 15:06:27 -07:00
2022-12-12 15:04:39 -08:00
2022-07-22 12:53:22 +01:00
2026-01-23 11:31:14 -08:00
2026-01-06 17:06:03 -08:00
2023-09-14 16:16:36 +02:00
2025-11-04 19:10:32 -08:00
2025-06-17 18:18:46 -07:00
2025-07-14 17:19:13 -07:00
2022-07-22 12:53:22 +01:00
2026-01-20 18:06:01 -08:00
2025-11-11 10:21:08 +01:00
2025-09-24 10:22:37 -07:00
2026-02-10 20:21:48 -08:00
2026-01-15 10:07:45 +01:00
dc010e1b4b