mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-04 20:19:47 +08:00

The change in struct file [1] moved f_ref to the 3rd cache line.
It made *(u64 *)file dereference invalid from the verifier point of view,
because btf_struct_walk() walks into f_lock field, which is 4-byte long.
Fix the selftests to deference the file pointer as a 4-byte access.
[1] commit e249056c91
("fs: place f_ref to 3rd cache line in struct file to resolve false sharing")
Reported-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20250327185528.1740787-1-song@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
52 lines
1.1 KiB
C
52 lines
1.1 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
#include "vmlinux.h"
|
|
#include <bpf/bpf_helpers.h>
|
|
#include <bpf/bpf_tracing.h>
|
|
|
|
struct {
|
|
__uint(type, BPF_MAP_TYPE_ARRAY);
|
|
__uint(max_entries, 8);
|
|
__type(key, __u32);
|
|
__type(value, __u64);
|
|
} test_array SEC(".maps");
|
|
|
|
unsigned int triggered;
|
|
|
|
static __u64 test_cb(struct bpf_map *map, __u32 *key, __u64 *val, void *data)
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
SEC("fexit/bpf_testmod_return_ptr")
|
|
int BPF_PROG(handle_fexit_ret_subprogs, int arg, struct file *ret)
|
|
{
|
|
*(volatile int *)ret;
|
|
*(volatile int *)&ret->f_mode;
|
|
bpf_for_each_map_elem(&test_array, test_cb, NULL, 0);
|
|
triggered++;
|
|
return 0;
|
|
}
|
|
|
|
SEC("fexit/bpf_testmod_return_ptr")
|
|
int BPF_PROG(handle_fexit_ret_subprogs2, int arg, struct file *ret)
|
|
{
|
|
*(volatile int *)ret;
|
|
*(volatile int *)&ret->f_mode;
|
|
bpf_for_each_map_elem(&test_array, test_cb, NULL, 0);
|
|
triggered++;
|
|
return 0;
|
|
}
|
|
|
|
SEC("fexit/bpf_testmod_return_ptr")
|
|
int BPF_PROG(handle_fexit_ret_subprogs3, int arg, struct file *ret)
|
|
{
|
|
*(volatile int *)ret;
|
|
*(volatile int *)&ret->f_mode;
|
|
bpf_for_each_map_elem(&test_array, test_cb, NULL, 0);
|
|
triggered++;
|
|
return 0;
|
|
}
|
|
|
|
char _license[] SEC("license") = "GPL";
|