torvalds/linux
torvalds/linux
2
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-04 20:19:47 +08:00
Code
d20e834e13
linux/net/ethtool
History
Maxim Mikityanskiy f01204ec8b ethtool: Don't omit the netlink reply if no features were changed 
The legacy ethtool userspace tool shows an error when no features could
be changed. It's useful to have a netlink reply to be able to show this
error when __netdev_update_features wasn't called, for example:

1. ethtool -k eth0
   large-receive-offload: off
2. ethtool -K eth0 rx-fcs on
3. ethtool -K eth0 lro on
   Could not change any device features
   rx-lro: off [requested on]
4. ethtool -K eth0 lro on
   # The output should be the same, but without this patch the kernel
   # doesn't send the reply, and ethtool is unable to detect the error.

This commit makes ethtool-netlink always return a reply when requested,
and it still avoids unnecessary calls to __netdev_update_features if the
wanted features haven't changed.

Fixes: 0980bfcd69 ("ethtool: set netdev features with FEATURES_SET request")
Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-08-18 16:00:24 -07:00
..
bitset.c ethtool: add ethnl_parse_bitset() helper 2020-03-12 15:32:32 -07:00
bitset.h ethtool: add ethnl_parse_bitset() helper 2020-03-12 15:32:32 -07:00
cabletest.c net: ethtool: Remove PHYLIB direct dependency 2020-07-07 15:41:05 -07:00
channels.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next 2020-05-22 18:30:34 -07:00
coalesce.c ethtool: add COALESCE_NTF notification 2020-03-29 22:32:36 -07:00
common.c ethtool: add tunnel info interface 2020-07-10 13:54:00 -07:00
common.h ethtool: add tunnel info interface 2020-07-10 13:54:00 -07:00
debug.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2020-03-25 18:58:11 -07:00
eee.c ethtool: add EEE_NTF notification 2020-03-29 22:32:36 -07:00
features.c ethtool: Don't omit the netlink reply if no features were changed 2020-08-18 16:00:24 -07:00
ioctl.c net: phy: Uninline PHY ethtool statistics operations 2020-07-08 12:39:05 -07:00
linkinfo.c ethtool: linkinfo: remove an unnecessary NULL check 2020-06-05 13:10:02 -07:00
linkmodes.c ethtool: ethnl_set_linkmodes: remove redundant null check 2020-08-03 15:11:49 -07:00
linkstate.c ethtool: Add link extended state 2020-06-29 17:45:02 -07:00
Makefile ethtool: add tunnel info interface 2020-07-10 13:54:00 -07:00
netlink.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2020-07-11 00:46:00 -07:00
netlink.h ethtool: add tunnel info interface 2020-07-10 13:54:00 -07:00
pause.c ethtool: add PAUSE_NTF notification 2020-03-29 22:32:36 -07:00
privflags.c ethtool: fix reference leak in ethnl_set_privflags() 2020-03-29 22:32:36 -07:00
rings.c ethtool: fix spelling mistake "exceeeds" -> "exceeds" 2020-03-13 11:23:33 -07:00
strset.c ethtool: add tunnel info interface 2020-07-10 13:54:00 -07:00
tsinfo.c ethtool: provide timestamping information with TSINFO_GET request 2020-03-29 22:32:37 -07:00
tunnels.c udp_tunnel: add the ability to hard-code IANA VXLAN 2020-08-03 10:13:54 -07:00
wol.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2020-03-25 18:58:11 -07:00