Guenter Roeck
c15e7c62fe
smb/server: Fix another refcount leak in smb2_open()
...
If ksmbd_override_fsids() fails, we jump to err_out2. At that point, fp is
NULL because it hasn't been assigned dh_info.fp yet, so ksmbd_fd_put(work,
fp) will not be called. However, dh_info.fp was already inserted into the
session file table by ksmbd_reopen_durable_fd(), so it will leak in the
session file table until the session is closed.
Move fp = dh_info.fp; ahead of the ksmbd_override_fsids() check to fix the
problem.
Found by an experimental AI code review agent at Google.
Fixes: c8efcc7861 ("ksmbd: add support for durable handles v1/v2")
Signed-off-by: Guenter Roeck <linux@roeck-us.net >
Reviewed-by: ChenXiaoSong <chenxiaosong@kylinos.cn >
Acked-by: Namjae Jeon <linkinjeon@kernel.org >
Signed-off-by: Steve French <stfrench@microsoft.com >
2026-03-08 21:28:38 -05:00
..
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-22 08:26:33 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-03-03 09:08:00 -08:00
2026-02-21 20:03:00 -08:00
2026-02-22 08:26:33 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-25 17:40:58 +08:00
2026-02-21 20:03:00 -08:00
2026-01-29 10:06:59 +01:00
2026-02-21 20:03:00 -08:00
2026-02-22 08:26:33 -08:00
2026-02-22 13:12:04 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-03-04 14:31:56 +01:00
2026-02-22 08:26:33 -08:00
2026-02-21 20:03:00 -08:00
2026-02-22 08:26:33 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-25 10:34:23 -08:00
2026-02-26 14:44:32 +01:00
2026-02-22 08:26:33 -08:00
2026-01-02 13:43:41 -05:00
2026-03-02 09:05:20 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 01:02:28 -08:00
2026-02-21 20:03:00 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 20:03:00 -08:00
2026-02-21 17:09:51 -08:00
2026-02-25 10:34:23 -08:00
2026-02-22 08:26:33 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-18 20:50:32 -08:00
2026-03-08 21:28:38 -05:00
2026-02-24 11:13:27 -08:00
2026-02-21 17:09:51 -08:00
2026-02-03 17:39:00 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-22 08:26:33 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-03-02 21:05:34 -08:00
2026-02-25 13:58:50 +01:00
2026-02-21 20:03:00 -08:00
2026-02-21 20:03:00 -08:00
2026-01-29 09:39:41 -08:00
2026-01-12 14:01:32 +01:00
2026-02-21 17:09:51 -08:00
2026-02-23 11:19:19 +01:00
2026-02-21 17:09:51 -08:00
2026-01-02 12:04:28 -08:00
2026-02-21 01:02:28 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 20:03:00 -08:00
2025-12-05 13:52:43 -08:00
2026-02-16 13:00:36 -08:00
2026-02-21 17:09:51 -08:00
2026-02-25 10:34:23 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 20:03:00 -08:00
2026-02-25 10:34:23 -08:00
2026-02-09 16:08:40 -08:00
2026-02-21 01:02:28 -08:00
2026-01-16 12:52:04 -05:00
2026-02-21 01:02:28 -08:00
2026-01-14 16:50:37 +01:00
2026-02-25 10:34:23 -08:00
2026-01-13 09:58:01 +01:00
2026-02-21 17:09:51 -08:00
2026-02-09 16:58:28 -08:00
2026-02-12 10:41:34 -08:00
2026-02-09 16:58:28 -08:00
2026-02-21 17:09:51 -08:00
2026-02-12 08:23:53 -08:00
2026-02-09 13:41:34 -08:00
2026-02-21 20:03:00 -08:00
2026-02-21 01:02:28 -08:00
2026-01-12 16:52:09 +01:00
2026-02-21 01:02:28 -08:00
2026-02-25 10:34:23 -08:00
2026-02-27 22:00:11 +01:00
2026-01-12 16:52:09 +01:00
2026-02-09 16:58:28 -08:00
2026-02-25 10:34:23 -08:00
2026-02-21 01:02:28 -08:00
2026-02-21 01:02:28 -08:00
2026-01-12 10:55:45 +01:00
2026-01-12 10:57:34 +01:00
2026-02-21 20:03:00 -08:00
2026-02-21 01:02:28 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-01-16 12:52:04 -05:00
2026-01-16 12:52:04 -05:00
2026-02-21 17:09:51 -08:00
2026-02-21 01:02:28 -08:00
2026-02-21 17:09:51 -08:00
2026-02-21 17:09:51 -08:00
2026-01-16 12:52:03 -05:00
2026-01-16 12:52:03 -05:00