mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-03-23 07:56:50 +08:00
295d8398c6
In Kbuild, two different rules must not write to the same file, but
it happens when compiling rust source files.
For example, set CONFIG_SAMPLE_RUST_MINIMAL=m and run the following:
$ make -j$(nproc) samples/rust/rust_minimal.o samples/rust/rust_minimal.rsi \
samples/rust/rust_minimal.s samples/rust/rust_minimal.ll
[snip]
RUSTC [M] samples/rust/rust_minimal.o
RUSTC [M] samples/rust/rust_minimal.rsi
RUSTC [M] samples/rust/rust_minimal.s
RUSTC [M] samples/rust/rust_minimal.ll
mv: cannot stat 'samples/rust/rust_minimal.d': No such file or directory
make[3]: *** [scripts/Makefile.build:334: samples/rust/rust_minimal.ll] Error 1
make[3]: *** Waiting for unfinished jobs....
mv: cannot stat 'samples/rust/rust_minimal.d': No such file or directory
make[3]: *** [scripts/Makefile.build:309: samples/rust/rust_minimal.o] Error 1
mv: cannot stat 'samples/rust/rust_minimal.d': No such file or directory
make[3]: *** [scripts/Makefile.build:326: samples/rust/rust_minimal.s] Error 1
make[2]: *** [scripts/Makefile.build:504: samples/rust] Error 2
make[1]: *** [scripts/Makefile.build:504: samples] Error 2
make: *** [Makefile:2008: .] Error 2
The reason for the error is that 4 threads running in parallel renames
the same file, samples/rust/rust_minimal.d.
This does not happen when compiling C or assembly files because
-Wp,-MMD,$(depfile) explicitly specifies the dependency filepath.
$(depfile) is a unique path for each target.
Currently, rustc is only given --out-dir and --emit=<list-of-types>
So, all the rust build rules output the dep-info into the default
<CRATE_NAME>.d, which causes the path conflict.
Fortunately, the --emit option is able to specify the output path
individually, with the form --emit=<type>=<path>.
Add --emit=dep-info=$(depfile) to the common part. Also, remove the
redundant --out-dir because the output path is specified for each type.
The code gets much cleaner because we do not need to rename *.d files.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
Tested-by: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
158 lines
5.7 KiB
Makefile
158 lines
5.7 KiB
Makefile
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
# LEX
|
|
# ---------------------------------------------------------------------------
|
|
quiet_cmd_flex = LEX $@
|
|
cmd_flex = $(LEX) -o$@ -L $<
|
|
|
|
$(obj)/%.lex.c: $(src)/%.l FORCE
|
|
$(call if_changed,flex)
|
|
|
|
# YACC
|
|
# ---------------------------------------------------------------------------
|
|
quiet_cmd_bison = YACC $(basename $@).[ch]
|
|
cmd_bison = $(YACC) -o $(basename $@).c --defines=$(basename $@).h -t -l $<
|
|
|
|
$(obj)/%.tab.c $(obj)/%.tab.h: $(src)/%.y FORCE
|
|
$(call if_changed,bison)
|
|
|
|
# ==========================================================================
|
|
# Building binaries on the host system
|
|
# Binaries are used during the compilation of the kernel, for example
|
|
# to preprocess a data file.
|
|
#
|
|
# Both C and C++ are supported, but preferred language is C for such utilities.
|
|
# Rust is also supported, but it may only be used in scenarios where a Rust
|
|
# toolchain is required to be available (e.g. when `CONFIG_RUST` is enabled).
|
|
#
|
|
# Sample syntax (see Documentation/kbuild/makefiles.rst for reference)
|
|
# hostprogs := bin2hex
|
|
# Will compile bin2hex.c and create an executable named bin2hex
|
|
#
|
|
# hostprogs := lxdialog
|
|
# lxdialog-objs := checklist.o lxdialog.o
|
|
# Will compile lxdialog.c and checklist.c, and then link the executable
|
|
# lxdialog, based on checklist.o and lxdialog.o
|
|
#
|
|
# hostprogs := qconf
|
|
# qconf-cxxobjs := qconf.o
|
|
# qconf-objs := menu.o
|
|
# Will compile qconf as a C++ program, and menu as a C program.
|
|
# They are linked as C++ code to the executable qconf
|
|
#
|
|
# hostprogs := target
|
|
# target-rust := y
|
|
# Will compile `target` as a Rust program, using `target.rs` as the crate root.
|
|
# The crate may consist of several source files.
|
|
|
|
# C code
|
|
# Executables compiled from a single .c file
|
|
host-csingle := $(foreach m,$(hostprogs), \
|
|
$(if $($(m)-objs)$($(m)-cxxobjs)$($(m)-rust),,$(m)))
|
|
|
|
# C executables linked based on several .o files
|
|
host-cmulti := $(foreach m,$(hostprogs),\
|
|
$(if $($(m)-cxxobjs)$($(m)-rust),,$(if $($(m)-objs),$(m))))
|
|
|
|
# Object (.o) files compiled from .c files
|
|
host-cobjs := $(sort $(foreach m,$(hostprogs),$($(m)-objs)))
|
|
|
|
# C++ code
|
|
# C++ executables compiled from at least one .cc file
|
|
# and zero or more .c files
|
|
host-cxxmulti := $(foreach m,$(hostprogs),$(if $($(m)-cxxobjs),$(m)))
|
|
|
|
# C++ Object (.o) files compiled from .cc files
|
|
host-cxxobjs := $(sort $(foreach m,$(host-cxxmulti),$($(m)-cxxobjs)))
|
|
|
|
# Rust code
|
|
# Executables compiled from a single Rust crate (which may consist of
|
|
# one or more .rs files)
|
|
host-rust := $(foreach m,$(hostprogs),$(if $($(m)-rust),$(m)))
|
|
|
|
host-csingle := $(addprefix $(obj)/,$(host-csingle))
|
|
host-cmulti := $(addprefix $(obj)/,$(host-cmulti))
|
|
host-cobjs := $(addprefix $(obj)/,$(host-cobjs))
|
|
host-cxxmulti := $(addprefix $(obj)/,$(host-cxxmulti))
|
|
host-cxxobjs := $(addprefix $(obj)/,$(host-cxxobjs))
|
|
host-rust := $(addprefix $(obj)/,$(host-rust))
|
|
|
|
#####
|
|
# Handle options to gcc. Support building with separate output directory
|
|
|
|
hostc_flags = -Wp,-MMD,$(depfile) \
|
|
$(KBUILD_HOSTCFLAGS) $(HOST_EXTRACFLAGS) \
|
|
$(HOSTCFLAGS_$(target-stem).o)
|
|
hostcxx_flags = -Wp,-MMD,$(depfile) \
|
|
$(KBUILD_HOSTCXXFLAGS) $(HOST_EXTRACXXFLAGS) \
|
|
$(HOSTCXXFLAGS_$(target-stem).o)
|
|
hostrust_flags = --emit=dep-info=$(depfile) \
|
|
$(KBUILD_HOSTRUSTFLAGS) $(HOST_EXTRARUSTFLAGS) \
|
|
$(HOSTRUSTFLAGS_$(target-stem))
|
|
|
|
# $(objtree)/$(obj) for including generated headers from checkin source files
|
|
ifeq ($(KBUILD_EXTMOD),)
|
|
ifdef building_out_of_srctree
|
|
hostc_flags += -I $(objtree)/$(obj)
|
|
hostcxx_flags += -I $(objtree)/$(obj)
|
|
endif
|
|
endif
|
|
|
|
#####
|
|
# Compile programs on the host
|
|
|
|
# Create executable from a single .c file
|
|
# host-csingle -> Executable
|
|
quiet_cmd_host-csingle = HOSTCC $@
|
|
cmd_host-csingle = $(HOSTCC) $(hostc_flags) $(KBUILD_HOSTLDFLAGS) -o $@ $< \
|
|
$(KBUILD_HOSTLDLIBS) $(HOSTLDLIBS_$(target-stem))
|
|
$(host-csingle): $(obj)/%: $(src)/%.c FORCE
|
|
$(call if_changed_dep,host-csingle)
|
|
|
|
# Link an executable based on list of .o files, all plain c
|
|
# host-cmulti -> executable
|
|
quiet_cmd_host-cmulti = HOSTLD $@
|
|
cmd_host-cmulti = $(HOSTCC) $(KBUILD_HOSTLDFLAGS) -o $@ \
|
|
$(addprefix $(obj)/, $($(target-stem)-objs)) \
|
|
$(KBUILD_HOSTLDLIBS) $(HOSTLDLIBS_$(target-stem))
|
|
$(host-cmulti): FORCE
|
|
$(call if_changed,host-cmulti)
|
|
$(call multi_depend, $(host-cmulti), , -objs)
|
|
|
|
# Create .o file from a single .c file
|
|
# host-cobjs -> .o
|
|
quiet_cmd_host-cobjs = HOSTCC $@
|
|
cmd_host-cobjs = $(HOSTCC) $(hostc_flags) -c -o $@ $<
|
|
$(host-cobjs): $(obj)/%.o: $(src)/%.c FORCE
|
|
$(call if_changed_dep,host-cobjs)
|
|
|
|
# Link an executable based on list of .o files, a mixture of .c and .cc
|
|
# host-cxxmulti -> executable
|
|
quiet_cmd_host-cxxmulti = HOSTLD $@
|
|
cmd_host-cxxmulti = $(HOSTCXX) $(KBUILD_HOSTLDFLAGS) -o $@ \
|
|
$(foreach o,objs cxxobjs,\
|
|
$(addprefix $(obj)/, $($(target-stem)-$(o)))) \
|
|
$(KBUILD_HOSTLDLIBS) $(HOSTLDLIBS_$(target-stem))
|
|
$(host-cxxmulti): FORCE
|
|
$(call if_changed,host-cxxmulti)
|
|
$(call multi_depend, $(host-cxxmulti), , -objs -cxxobjs)
|
|
|
|
# Create .o file from a single .cc (C++) file
|
|
quiet_cmd_host-cxxobjs = HOSTCXX $@
|
|
cmd_host-cxxobjs = $(HOSTCXX) $(hostcxx_flags) -c -o $@ $<
|
|
$(host-cxxobjs): $(obj)/%.o: $(src)/%.cc FORCE
|
|
$(call if_changed_dep,host-cxxobjs)
|
|
|
|
# Create executable from a single Rust crate (which may consist of
|
|
# one or more `.rs` files)
|
|
# host-rust -> Executable
|
|
quiet_cmd_host-rust = HOSTRUSTC $@
|
|
cmd_host-rust = \
|
|
$(HOSTRUSTC) $(hostrust_flags) --emit=link=$@ $<; \
|
|
sed -i '/^\#/d' $(depfile)
|
|
$(host-rust): $(obj)/%: $(src)/%.rs FORCE
|
|
$(call if_changed_dep,host-rust)
|
|
|
|
targets += $(host-csingle) $(host-cmulti) $(host-cobjs) \
|
|
$(host-cxxmulti) $(host-cxxobjs) $(host-rust)
|