mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-04 20:19:47 +08:00
ba4b39fe4c
Callers that want to create an inode currently pass all possible file attribute values for the new inode into xfs_init_new_inode as ten separate parameters. This causes two code maintenance issues: first, we have large multi-line call sites which programmers must read carefully to make sure they did not accidentally invert a value. Second, all three file id parameters must be passed separately to the quota functions; any discrepancy results in quota count errors. Clean this up by creating a new icreate_args structure to hold all this information, some helpers to initialize them properly, and make the callers pass this structure through to the creation function, whose name we shorten to xfs_icreate. This eliminates the issues, enables us to keep the inode init code in sync with userspace via libxfs, and is needed for future metadata directory tree management. (A subsequent cleanup will also fix the quota alloc calls.) Signed-off-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Christoph Hellwig <hch@lst.de>
39 lines
1.2 KiB
C
39 lines
1.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Copyright (c) 2000-2003,2005 Silicon Graphics, Inc.
|
|
* All Rights Reserved.
|
|
*/
|
|
#ifndef __XFS_INODE_UTIL_H__
|
|
#define __XFS_INODE_UTIL_H__
|
|
|
|
uint16_t xfs_flags2diflags(struct xfs_inode *ip, unsigned int xflags);
|
|
uint64_t xfs_flags2diflags2(struct xfs_inode *ip, unsigned int xflags);
|
|
uint32_t xfs_dic2xflags(struct xfs_inode *ip);
|
|
uint32_t xfs_ip2xflags(struct xfs_inode *ip);
|
|
|
|
prid_t xfs_get_initial_prid(struct xfs_inode *dp);
|
|
|
|
/*
|
|
* File creation context.
|
|
*
|
|
* Due to our only partial reliance on the VFS to propagate uid and gid values
|
|
* according to accepted Unix behaviors, callers must initialize idmap to the
|
|
* correct idmapping structure to get the correct inheritance behaviors when
|
|
* XFS_MOUNT_GRPID is set.
|
|
*
|
|
* To create files detached from the directory tree (e.g. quota inodes), set
|
|
* idmap to NULL. To create a tree root, set pip to NULL.
|
|
*/
|
|
struct xfs_icreate_args {
|
|
struct mnt_idmap *idmap;
|
|
struct xfs_inode *pip; /* parent inode or null */
|
|
dev_t rdev;
|
|
umode_t mode;
|
|
|
|
#define XFS_ICREATE_TMPFILE (1U << 0) /* create an unlinked file */
|
|
#define XFS_ICREATE_INIT_XATTRS (1U << 1) /* will set xattrs immediately */
|
|
uint16_t flags;
|
|
};
|
|
|
|
#endif /* __XFS_INODE_UTIL_H__ */
|