mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-04 20:19:47 +08:00
625f4de23f
The 'perf stat' output on aarch64 machines with topdown events wasn't
counted for in the 'perf stat STD output linter' test case. Add the
topdown metric to the skip_metric list as it is done for topdown events
on other systems.
The Topdown events are also disabled on aarch64 KVM guests because the
value of caps/slots is set to 0 due to the part of the system register
being a stub.
This prevents the metric for the topdown events from being computed,
leaving the 'perf stat' topdown metric without any value at all.
Add the "TopdownL1" to the skip_metric list as well to handle this
possibility.
Before aarch64:
100: perf stat STD output linter:
--- start ---
test child forked, pid 403305
Checking STD output: no args Unknown event name in TopdownL1 # 4.3 percent of slots slots_lost_misspeculation_fraction
---- end(-1) ----
100: perf stat STD output linter : FAILED!
Before aarch64 KVM:
100: perf stat STD output linter:
--- start ---
test child forked, pid 404671
Checking STD output: no args Unknown event name in TopdownL1
---- end(-1) ----
100: perf stat STD output linter : FAILED!
After:
100: perf stat STD output linter:
--- start ---
test child forked, pid 404777
Checking STD output: no args [Success]
Checking STD output: system wide [Success]
Checking STD output: interval [Success]
Checking STD output: per thread [Success]
Checking STD output: per node [Success]
Checking STD output: system wide no aggregation [Success]
Checking STD output: per core [Success]
Checking STD output: per cache instance [Success]
Checking STD output: per cluster [Success]
Checking STD output: per die [Success]
Checking STD output: per socket [Success]
---- end(0) ----
100: perf stat STD output linter : Ok
Signed-off-by: Veronika Molnarova <vmolnaro@redhat.com>
Acked-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Yicong Yang <yangyicong@hisilicon.com>
Link: https://lore.kernel.org/r/20241029144347.25651-1-vmolnaro@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
111 lines
3.0 KiB
Bash
Executable File
111 lines
3.0 KiB
Bash
Executable File
#!/bin/bash
|
|
# perf stat STD output linter
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
# Tests various perf stat STD output commands for
|
|
# default event and metricgroup
|
|
|
|
set -e
|
|
|
|
# shellcheck source=lib/stat_output.sh
|
|
. "$(dirname $0)"/lib/stat_output.sh
|
|
|
|
stat_output=$(mktemp /tmp/__perf_test.stat_output.std.XXXXX)
|
|
|
|
event_name=(cpu-clock task-clock context-switches cpu-migrations page-faults stalled-cycles-frontend stalled-cycles-backend cycles instructions branches branch-misses)
|
|
event_metric=("CPUs utilized" "CPUs utilized" "/sec" "/sec" "/sec" "frontend cycles idle" "backend cycles idle" "GHz" "insn per cycle" "/sec" "of all branches")
|
|
skip_metric=("stalled cycles per insn" "tma_" "retiring" "frontend_bound" "bad_speculation" "backend_bound" "TopdownL1" "percent of slots")
|
|
|
|
cleanup() {
|
|
rm -f "${stat_output}"
|
|
|
|
trap - EXIT TERM INT
|
|
}
|
|
|
|
trap_cleanup() {
|
|
cleanup
|
|
exit 1
|
|
}
|
|
trap trap_cleanup EXIT TERM INT
|
|
|
|
function commachecker()
|
|
{
|
|
local prefix=1
|
|
|
|
case "$1"
|
|
in "--interval") prefix=2
|
|
;; "--per-thread") prefix=2
|
|
;; "--system-wide-no-aggr") prefix=2
|
|
;; "--per-core") prefix=3
|
|
;; "--per-socket") prefix=3
|
|
;; "--per-node") prefix=3
|
|
;; "--per-die") prefix=3
|
|
;; "--per-cache") prefix=3
|
|
;; "--per-cluster") prefix=3
|
|
esac
|
|
|
|
while read line
|
|
do
|
|
# Ignore initial "started on" comment.
|
|
x=${line:0:1}
|
|
[ "$x" = "#" ] && continue
|
|
# Ignore initial blank line.
|
|
[ "$line" = "" ] && continue
|
|
# Ignore "Performance counter stats"
|
|
x=${line:0:25}
|
|
[ "$x" = "Performance counter stats" ] && continue
|
|
# Ignore "seconds time elapsed" and break
|
|
[[ "$line" == *"time elapsed"* ]] && break
|
|
|
|
main_body=$(echo $line | cut -d' ' -f$prefix-)
|
|
x=${main_body%#*}
|
|
[ "$x" = "" ] && continue
|
|
|
|
# Skip metrics without event name
|
|
y=${main_body#*#}
|
|
for i in "${!skip_metric[@]}"; do
|
|
[[ "$y" == *"${skip_metric[$i]}"* ]] && break
|
|
done
|
|
[[ "$y" == *"${skip_metric[$i]}"* ]] && continue
|
|
|
|
# Check default event
|
|
for i in "${!event_name[@]}"; do
|
|
[[ "$x" == *"${event_name[$i]}"* ]] && break
|
|
done
|
|
|
|
[[ ! "$x" == *"${event_name[$i]}"* ]] && {
|
|
echo "Unknown event name in $line" 1>&2
|
|
exit 1;
|
|
}
|
|
|
|
# Check event metric if it exists
|
|
[[ ! "$main_body" == *"#"* ]] && continue
|
|
[[ ! "$main_body" == *"${event_metric[$i]}"* ]] && {
|
|
echo "wrong event metric. expected ${event_metric[$i]} in $line" 1>&2
|
|
exit 1;
|
|
}
|
|
done < "${stat_output}"
|
|
return 0
|
|
}
|
|
|
|
perf_cmd="-o ${stat_output}"
|
|
|
|
skip_test=$(check_for_topology)
|
|
check_no_args "STD" "$perf_cmd"
|
|
check_system_wide "STD" "$perf_cmd"
|
|
check_interval "STD" "$perf_cmd"
|
|
check_per_thread "STD" "$perf_cmd"
|
|
check_per_node "STD" "$perf_cmd"
|
|
if [ $skip_test -ne 1 ]
|
|
then
|
|
check_system_wide_no_aggr "STD" "$perf_cmd"
|
|
check_per_core "STD" "$perf_cmd"
|
|
check_per_cache_instance "STD" "$perf_cmd"
|
|
check_per_cluster "STD" "$perf_cmd"
|
|
check_per_die "STD" "$perf_cmd"
|
|
check_per_socket "STD" "$perf_cmd"
|
|
else
|
|
echo "[Skip] Skipping tests for system_wide_no_aggr, per_core, per_die and per_socket since socket id exposed via topology is invalid"
|
|
fi
|
|
cleanup
|
|
exit 0
|