mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-04 20:19:47 +08:00

Clean up the existing export namespace code along the same lines of
commit 33def8498f
("treewide: Convert macro and uses of __section(foo)
to __section("foo")") and for the same reason, it is not desired for the
namespace argument to be a macro expansion itself.
Scripted using
git grep -l -e MODULE_IMPORT_NS -e EXPORT_SYMBOL_NS | while read file;
do
awk -i inplace '
/^#define EXPORT_SYMBOL_NS/ {
gsub(/__stringify\(ns\)/, "ns");
print;
next;
}
/^#define MODULE_IMPORT_NS/ {
gsub(/__stringify\(ns\)/, "ns");
print;
next;
}
/MODULE_IMPORT_NS/ {
$0 = gensub(/MODULE_IMPORT_NS\(([^)]*)\)/, "MODULE_IMPORT_NS(\"\\1\")", "g");
}
/EXPORT_SYMBOL_NS/ {
if ($0 ~ /(EXPORT_SYMBOL_NS[^(]*)\(([^,]+),/) {
if ($0 !~ /(EXPORT_SYMBOL_NS[^(]*)\(([^,]+), ([^)]+)\)/ &&
$0 !~ /(EXPORT_SYMBOL_NS[^(]*)\(\)/ &&
$0 !~ /^my/) {
getline line;
gsub(/[[:space:]]*\\$/, "");
gsub(/[[:space:]]/, "", line);
$0 = $0 " " line;
}
$0 = gensub(/(EXPORT_SYMBOL_NS[^(]*)\(([^,]+), ([^)]+)\)/,
"\\1(\\2, \"\\3\")", "g");
}
}
{ print }' $file;
done
Requested-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://mail.google.com/mail/u/2/#inbox/FMfcgzQXKWgMmjdFwwdsfgxzKpVHWPlc
Acked-by: Greg KH <gregkh@linuxfoundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
79 lines
2.1 KiB
C
79 lines
2.1 KiB
C
// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
|
|
/*
|
|
* KUnit tests for the iwlwifi device info table
|
|
*
|
|
* Copyright (C) 2023-2024 Intel Corporation
|
|
*/
|
|
#include <kunit/test.h>
|
|
#include <linux/pci.h>
|
|
#include "iwl-drv.h"
|
|
#include "iwl-config.h"
|
|
|
|
MODULE_IMPORT_NS("EXPORTED_FOR_KUNIT_TESTING");
|
|
|
|
static void iwl_pci_print_dev_info(const char *pfx, const struct iwl_dev_info *di)
|
|
{
|
|
printk(KERN_DEBUG "%sdev=%.4x,subdev=%.4x,mac_type=%.4x,mac_step=%.4x,rf_type=%.4x,cdb=%d,jacket=%d,rf_id=%.2x,no_160=%d,cores=%.2x\n",
|
|
pfx, di->device, di->subdevice, di->mac_type, di->mac_step,
|
|
di->rf_type, di->cdb, di->jacket, di->rf_id, di->no_160,
|
|
di->cores);
|
|
}
|
|
|
|
static void devinfo_table_order(struct kunit *test)
|
|
{
|
|
int idx;
|
|
|
|
for (idx = 0; idx < iwl_dev_info_table_size; idx++) {
|
|
const struct iwl_dev_info *di = &iwl_dev_info_table[idx];
|
|
const struct iwl_dev_info *ret;
|
|
|
|
ret = iwl_pci_find_dev_info(di->device, di->subdevice,
|
|
di->mac_type, di->mac_step,
|
|
di->rf_type, di->cdb,
|
|
di->jacket, di->rf_id,
|
|
di->no_160, di->cores, di->rf_step);
|
|
if (ret != di) {
|
|
iwl_pci_print_dev_info("searched: ", di);
|
|
iwl_pci_print_dev_info("found: ", ret);
|
|
KUNIT_FAIL(test,
|
|
"unusable entry at index %d (found index %d instead)\n",
|
|
idx, (int)(ret - iwl_dev_info_table));
|
|
}
|
|
}
|
|
}
|
|
|
|
static void devinfo_pci_ids(struct kunit *test)
|
|
{
|
|
struct pci_dev *dev;
|
|
|
|
dev = kunit_kmalloc(test, sizeof(*dev), GFP_KERNEL);
|
|
KUNIT_ASSERT_NOT_NULL(test, dev);
|
|
|
|
for (int i = 0; iwl_hw_card_ids[i].vendor; i++) {
|
|
const struct pci_device_id *s, *t;
|
|
|
|
s = &iwl_hw_card_ids[i];
|
|
dev->vendor = s->vendor;
|
|
dev->device = s->device;
|
|
dev->subsystem_vendor = s->subvendor;
|
|
dev->subsystem_device = s->subdevice;
|
|
dev->class = s->class;
|
|
|
|
t = pci_match_id(iwl_hw_card_ids, dev);
|
|
KUNIT_EXPECT_PTR_EQ(test, t, s);
|
|
}
|
|
}
|
|
|
|
static struct kunit_case devinfo_test_cases[] = {
|
|
KUNIT_CASE(devinfo_table_order),
|
|
KUNIT_CASE(devinfo_pci_ids),
|
|
{}
|
|
};
|
|
|
|
static struct kunit_suite iwlwifi_devinfo = {
|
|
.name = "iwlwifi-devinfo",
|
|
.test_cases = devinfo_test_cases,
|
|
};
|
|
|
|
kunit_test_suite(iwlwifi_devinfo);
|