mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-04 20:19:47 +08:00
The (re)initializing of the completion object should be done before we
trigger the transfer. Doing this after triggering the hardware opens up
a race window. Without the timeout we would problaly even deadlock. Use
also reinit_completion because we initalize the whole data structure in
csio_scscim_init().
There is only one waiter for the completion, therefore there is no need
to use complete_all(). Let's make that clear by using complete() instead
of complete_all().
The usage pattern of the completion is:
waiter context waker context
csio_eh_abort_handler()
reinit_completion()
wait_for_completion_timeout()
csio_scsi_err_handler()
complete()
[mkp: fix typo]
Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
||
|---|---|---|
| .. | ||
| csio_attr.c | ||
| csio_defs.h | ||
| csio_hw_chip.h | ||
| csio_hw_t5.c | ||
| csio_hw.c | ||
| csio_hw.h | ||
| csio_init.c | ||
| csio_init.h | ||
| csio_isr.c | ||
| csio_lnode.c | ||
| csio_lnode.h | ||
| csio_mb.c | ||
| csio_mb.h | ||
| csio_rnode.c | ||
| csio_rnode.h | ||
| csio_scsi.c | ||
| csio_scsi.h | ||
| csio_wr.c | ||
| csio_wr.h | ||
| Kconfig | ||
| Makefile | ||
| t4fw_api_stor.h | ||