mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-03-21 23:16:50 +08:00
d75ec7e8ba
We look up a netdev during prep of Netlink ops (pre- callbacks)
and take a ref to it. Then later in the body of the callback
we take its lock or RCU which are the actual protections.
The netdev may get unregistered in between the time we take
the ref and the time we lock it. We may allocate the hierarchy
after flush has already run, which would lead to a leak.
Take the instance lock in pre- already, this saves us from the race
and removes the need for dedicated lock/unlock callbacks completely.
After all, if there's any chance of write happening concurrently
with the flush - we're back to leaking the hierarchy.
We may take the lock for devices which don't support shapers but
we're only dealing with SET operations here, not taking the lock
would be optimizing for an error case.
Fixes: 93954b40f6 ("net-shapers: implement NL set and delete operations")
Link: https://lore.kernel.org/20260309173450.538026-1-p@1g4.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Link: https://patch.msgid.link/20260317161014.779569-2-kuba@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
156 lines
5.4 KiB
C
156 lines
5.4 KiB
C
// SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)
|
|
/* Do not edit directly, auto-generated from: */
|
|
/* Documentation/netlink/specs/net_shaper.yaml */
|
|
/* YNL-GEN kernel source */
|
|
/* To regenerate run: tools/net/ynl/ynl-regen.sh */
|
|
|
|
#include <net/netlink.h>
|
|
#include <net/genetlink.h>
|
|
|
|
#include "shaper_nl_gen.h"
|
|
|
|
#include <uapi/linux/net_shaper.h>
|
|
|
|
/* Common nested types */
|
|
const struct nla_policy net_shaper_handle_nl_policy[NET_SHAPER_A_HANDLE_ID + 1] = {
|
|
[NET_SHAPER_A_HANDLE_SCOPE] = NLA_POLICY_MAX(NLA_U32, 3),
|
|
[NET_SHAPER_A_HANDLE_ID] = { .type = NLA_U32, },
|
|
};
|
|
|
|
const struct nla_policy net_shaper_leaf_info_nl_policy[NET_SHAPER_A_WEIGHT + 1] = {
|
|
[NET_SHAPER_A_HANDLE] = NLA_POLICY_NESTED(net_shaper_handle_nl_policy),
|
|
[NET_SHAPER_A_PRIORITY] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_WEIGHT] = { .type = NLA_U32, },
|
|
};
|
|
|
|
/* NET_SHAPER_CMD_GET - do */
|
|
static const struct nla_policy net_shaper_get_do_nl_policy[NET_SHAPER_A_IFINDEX + 1] = {
|
|
[NET_SHAPER_A_IFINDEX] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_HANDLE] = NLA_POLICY_NESTED(net_shaper_handle_nl_policy),
|
|
};
|
|
|
|
/* NET_SHAPER_CMD_GET - dump */
|
|
static const struct nla_policy net_shaper_get_dump_nl_policy[NET_SHAPER_A_IFINDEX + 1] = {
|
|
[NET_SHAPER_A_IFINDEX] = { .type = NLA_U32, },
|
|
};
|
|
|
|
/* NET_SHAPER_CMD_SET - do */
|
|
static const struct nla_policy net_shaper_set_nl_policy[NET_SHAPER_A_IFINDEX + 1] = {
|
|
[NET_SHAPER_A_IFINDEX] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_HANDLE] = NLA_POLICY_NESTED(net_shaper_handle_nl_policy),
|
|
[NET_SHAPER_A_METRIC] = NLA_POLICY_MAX(NLA_U32, 1),
|
|
[NET_SHAPER_A_BW_MIN] = { .type = NLA_UINT, },
|
|
[NET_SHAPER_A_BW_MAX] = { .type = NLA_UINT, },
|
|
[NET_SHAPER_A_BURST] = { .type = NLA_UINT, },
|
|
[NET_SHAPER_A_PRIORITY] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_WEIGHT] = { .type = NLA_U32, },
|
|
};
|
|
|
|
/* NET_SHAPER_CMD_DELETE - do */
|
|
static const struct nla_policy net_shaper_delete_nl_policy[NET_SHAPER_A_IFINDEX + 1] = {
|
|
[NET_SHAPER_A_IFINDEX] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_HANDLE] = NLA_POLICY_NESTED(net_shaper_handle_nl_policy),
|
|
};
|
|
|
|
/* NET_SHAPER_CMD_GROUP - do */
|
|
static const struct nla_policy net_shaper_group_nl_policy[NET_SHAPER_A_LEAVES + 1] = {
|
|
[NET_SHAPER_A_IFINDEX] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_PARENT] = NLA_POLICY_NESTED(net_shaper_handle_nl_policy),
|
|
[NET_SHAPER_A_HANDLE] = NLA_POLICY_NESTED(net_shaper_handle_nl_policy),
|
|
[NET_SHAPER_A_METRIC] = NLA_POLICY_MAX(NLA_U32, 1),
|
|
[NET_SHAPER_A_BW_MIN] = { .type = NLA_UINT, },
|
|
[NET_SHAPER_A_BW_MAX] = { .type = NLA_UINT, },
|
|
[NET_SHAPER_A_BURST] = { .type = NLA_UINT, },
|
|
[NET_SHAPER_A_PRIORITY] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_WEIGHT] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_LEAVES] = NLA_POLICY_NESTED(net_shaper_leaf_info_nl_policy),
|
|
};
|
|
|
|
/* NET_SHAPER_CMD_CAP_GET - do */
|
|
static const struct nla_policy net_shaper_cap_get_do_nl_policy[NET_SHAPER_A_CAPS_SCOPE + 1] = {
|
|
[NET_SHAPER_A_CAPS_IFINDEX] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_CAPS_SCOPE] = NLA_POLICY_MAX(NLA_U32, 3),
|
|
};
|
|
|
|
/* NET_SHAPER_CMD_CAP_GET - dump */
|
|
static const struct nla_policy net_shaper_cap_get_dump_nl_policy[NET_SHAPER_A_CAPS_IFINDEX + 1] = {
|
|
[NET_SHAPER_A_CAPS_IFINDEX] = { .type = NLA_U32, },
|
|
};
|
|
|
|
/* Ops table for net_shaper */
|
|
static const struct genl_split_ops net_shaper_nl_ops[] = {
|
|
{
|
|
.cmd = NET_SHAPER_CMD_GET,
|
|
.pre_doit = net_shaper_nl_pre_doit,
|
|
.doit = net_shaper_nl_get_doit,
|
|
.post_doit = net_shaper_nl_post_doit,
|
|
.policy = net_shaper_get_do_nl_policy,
|
|
.maxattr = NET_SHAPER_A_IFINDEX,
|
|
.flags = GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = NET_SHAPER_CMD_GET,
|
|
.start = net_shaper_nl_pre_dumpit,
|
|
.dumpit = net_shaper_nl_get_dumpit,
|
|
.done = net_shaper_nl_post_dumpit,
|
|
.policy = net_shaper_get_dump_nl_policy,
|
|
.maxattr = NET_SHAPER_A_IFINDEX,
|
|
.flags = GENL_CMD_CAP_DUMP,
|
|
},
|
|
{
|
|
.cmd = NET_SHAPER_CMD_SET,
|
|
.pre_doit = net_shaper_nl_pre_doit_write,
|
|
.doit = net_shaper_nl_set_doit,
|
|
.post_doit = net_shaper_nl_post_doit_write,
|
|
.policy = net_shaper_set_nl_policy,
|
|
.maxattr = NET_SHAPER_A_IFINDEX,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = NET_SHAPER_CMD_DELETE,
|
|
.pre_doit = net_shaper_nl_pre_doit_write,
|
|
.doit = net_shaper_nl_delete_doit,
|
|
.post_doit = net_shaper_nl_post_doit_write,
|
|
.policy = net_shaper_delete_nl_policy,
|
|
.maxattr = NET_SHAPER_A_IFINDEX,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = NET_SHAPER_CMD_GROUP,
|
|
.pre_doit = net_shaper_nl_pre_doit_write,
|
|
.doit = net_shaper_nl_group_doit,
|
|
.post_doit = net_shaper_nl_post_doit_write,
|
|
.policy = net_shaper_group_nl_policy,
|
|
.maxattr = NET_SHAPER_A_LEAVES,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = NET_SHAPER_CMD_CAP_GET,
|
|
.pre_doit = net_shaper_nl_cap_pre_doit,
|
|
.doit = net_shaper_nl_cap_get_doit,
|
|
.post_doit = net_shaper_nl_cap_post_doit,
|
|
.policy = net_shaper_cap_get_do_nl_policy,
|
|
.maxattr = NET_SHAPER_A_CAPS_SCOPE,
|
|
.flags = GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = NET_SHAPER_CMD_CAP_GET,
|
|
.start = net_shaper_nl_cap_pre_dumpit,
|
|
.dumpit = net_shaper_nl_cap_get_dumpit,
|
|
.done = net_shaper_nl_cap_post_dumpit,
|
|
.policy = net_shaper_cap_get_dump_nl_policy,
|
|
.maxattr = NET_SHAPER_A_CAPS_IFINDEX,
|
|
.flags = GENL_CMD_CAP_DUMP,
|
|
},
|
|
};
|
|
|
|
struct genl_family net_shaper_nl_family __ro_after_init = {
|
|
.name = NET_SHAPER_FAMILY_NAME,
|
|
.version = NET_SHAPER_FAMILY_VERSION,
|
|
.netnsok = true,
|
|
.parallel_ops = true,
|
|
.module = THIS_MODULE,
|
|
.split_ops = net_shaper_nl_ops,
|
|
.n_split_ops = ARRAY_SIZE(net_shaper_nl_ops),
|
|
};
|