mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-04 20:19:47 +08:00

If PYLINT=1 is passed to the build then run pylint over python code in perf. Unlike shellcheck this isn't default on as there are currently too many errors. An example of an error: ``` ************* Module setup util/setup.py:19:0: C0301: Line too long (127/100) (line-too-long) util/setup.py:20:0: C0301: Line too long (138/100) (line-too-long) util/setup.py:63:0: C0301: Line too long (106/100) (line-too-long) util/setup.py:1:0: C0114: Missing module docstring (missing-module-docstring) util/setup.py:24:4: W0622: Redefining built-in 'vars' (redefined-builtin) util/setup.py:11:4: C0103: Constant name "cc_options" doesn't conform to UPPER_CASE naming style (invalid-name) util/setup.py:13:4: C0103: Constant name "cc_options" doesn't conform to UPPER_CASE naming style (invalid-name) util/setup.py:15:34: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) util/setup.py:18:0: C0116: Missing function or method docstring (missing-function-docstring) util/setup.py:19:16: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) util/setup.py:44:0: C0413: Import "from setuptools import setup, Extension" should be placed at the top of the module (wrong-import-position) util/setup.py:46:0: C0413: Import "from setuptools.command.build_ext import build_ext as _build_ext" should be placed at the top of the module (wrong-import-position) util/setup.py:47:0: C0413: Import "from setuptools.command.install_lib import install_lib as _install_lib" should be placed at the top of the module (wrong-import-position) util/setup.py:49:0: C0115: Missing class docstring (missing-class-docstring) util/setup.py:49:0: C0103: Class name "build_ext" doesn't conform to PascalCase naming style (invalid-name) util/setup.py:52:8: W0201: Attribute 'build_lib' defined outside __init__ (attribute-defined-outside-init) util/setup.py:53:8: W0201: Attribute 'build_temp' defined outside __init__ (attribute-defined-outside-init) util/setup.py:55:0: C0115: Missing class docstring (missing-class-docstring) util/setup.py:55:0: C0103: Class name "install_lib" doesn't conform to PascalCase naming style (invalid-name) util/setup.py:58:8: W0201: Attribute 'build_dir' defined outside __init__ (attribute-defined-outside-init) *----------------------------------------------------------------- Your code has been rated at 6.67/10 (previous run: 6.51/10, +0.16) make[4]: *** [util/Build:442: util/setup.py.pylint_log] Error 1 ``` Reviewed-by: James Clark <james.clark@linaro.org> Signed-off-by: Ian Rogers <irogers@google.com> Link: https://lore.kernel.org/r/20250311213628.569562-5-irogers@google.com Signed-off-by: Namhyung Kim <namhyung@kernel.org>
120 lines
3.4 KiB
Plaintext
120 lines
3.4 KiB
Plaintext
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
perf-test-y += builtin-test.o
|
|
perf-test-y += tests-scripts.o
|
|
perf-test-y += parse-events.o
|
|
perf-test-y += dso-data.o
|
|
perf-test-y += vmlinux-kallsyms.o
|
|
perf-test-y += openat-syscall.o
|
|
perf-test-y += openat-syscall-all-cpus.o
|
|
perf-test-$(CONFIG_LIBTRACEEVENT) += openat-syscall-tp-fields.o
|
|
perf-test-y += mmap-basic.o
|
|
perf-test-y += perf-record.o
|
|
perf-test-y += evsel-roundtrip-name.o
|
|
perf-test-$(CONFIG_LIBTRACEEVENT) += evsel-tp-sched.o
|
|
perf-test-y += fdarray.o
|
|
perf-test-y += pmu.o
|
|
perf-test-y += pmu-events.o
|
|
perf-test-y += hists_common.o
|
|
perf-test-y += hists_link.o
|
|
perf-test-y += hists_filter.o
|
|
perf-test-y += hists_output.o
|
|
perf-test-y += hists_cumulate.o
|
|
perf-test-y += python-use.o
|
|
perf-test-y += bp_signal.o
|
|
perf-test-y += bp_signal_overflow.o
|
|
perf-test-y += bp_account.o
|
|
perf-test-y += wp.o
|
|
perf-test-y += task-exit.o
|
|
perf-test-y += sw-clock.o
|
|
perf-test-y += mmap-thread-lookup.o
|
|
perf-test-y += thread-maps-share.o
|
|
perf-test-$(CONFIG_LIBTRACEEVENT) += switch-tracking.o
|
|
perf-test-y += keep-tracking.o
|
|
perf-test-y += code-reading.o
|
|
perf-test-y += sample-parsing.o
|
|
perf-test-y += parse-no-sample-id-all.o
|
|
perf-test-y += kmod-path.o
|
|
perf-test-y += thread-map.o
|
|
perf-test-y += topology.o
|
|
perf-test-y += mem.o
|
|
perf-test-y += cpumap.o
|
|
perf-test-y += stat.o
|
|
perf-test-y += event_update.o
|
|
perf-test-y += event-times.o
|
|
perf-test-y += expr.o
|
|
perf-test-y += backward-ring-buffer.o
|
|
perf-test-y += sdt.o
|
|
perf-test-y += is_printable_array.o
|
|
perf-test-y += bitmap.o
|
|
perf-test-y += perf-hooks.o
|
|
perf-test-y += unit_number__scnprintf.o
|
|
perf-test-y += mem2node.o
|
|
perf-test-y += maps.o
|
|
perf-test-y += time-utils-test.o
|
|
perf-test-y += genelf.o
|
|
perf-test-y += api-io.o
|
|
perf-test-y += demangle-java-test.o
|
|
perf-test-y += demangle-ocaml-test.o
|
|
perf-test-y += pfm.o
|
|
perf-test-y += parse-metric.o
|
|
perf-test-y += pe-file-parsing.o
|
|
perf-test-y += expand-cgroup.o
|
|
perf-test-y += perf-time-to-tsc.o
|
|
perf-test-y += dlfilter-test.o
|
|
perf-test-y += sigtrap.o
|
|
perf-test-y += event_groups.o
|
|
perf-test-y += symbols.o
|
|
perf-test-y += util.o
|
|
perf-test-y += hwmon_pmu.o
|
|
perf-test-y += tool_pmu.o
|
|
|
|
ifeq ($(SRCARCH),$(filter $(SRCARCH),x86 arm arm64 powerpc))
|
|
perf-test-$(CONFIG_DWARF_UNWIND) += dwarf-unwind.o
|
|
endif
|
|
|
|
CFLAGS_python-use.o += -DPYTHONPATH="BUILD_STR($(OUTPUT)python)" -DPYTHON="BUILD_STR($(PYTHON_WORD))"
|
|
CFLAGS_dwarf-unwind.o += -fno-optimize-sibling-calls
|
|
|
|
perf-test-y += workloads/
|
|
|
|
ifdef SHELLCHECK
|
|
SHELL_TESTS := $(shell find tests/shell -executable -type f -name '*.sh')
|
|
SHELL_TEST_LOGS := $(SHELL_TESTS:tests/shell/%=shell/%.shellcheck_log)
|
|
else
|
|
SHELL_TESTS :=
|
|
SHELL_TEST_LOGS :=
|
|
endif
|
|
|
|
$(OUTPUT)%.shellcheck_log: %
|
|
$(call rule_mkdir)
|
|
$(Q)$(call echo-cmd,test)shellcheck -a -S warning "$<" > $@ || (cat $@ && rm $@ && false)
|
|
|
|
perf-test-y += $(SHELL_TEST_LOGS)
|
|
|
|
ifdef MYPY
|
|
PY_TESTS := $(shell find tests/shell -type f -name '*.py')
|
|
MYPY_TEST_LOGS := $(PY_TESTS:tests/shell/%=shell/%.mypy_log)
|
|
else
|
|
MYPY_TEST_LOGS :=
|
|
endif
|
|
|
|
$(OUTPUT)%.mypy_log: %
|
|
$(call rule_mkdir)
|
|
$(Q)$(call echo-cmd,test)mypy "$<" > $@ || (cat $@ && rm $@ && false)
|
|
|
|
perf-test-y += $(MYPY_TEST_LOGS)
|
|
|
|
ifdef PYLINT
|
|
PY_TESTS := $(shell find tests/shell -type f -name '*.py')
|
|
PYLINT_TEST_LOGS := $(PY_TESTS:tests/shell/%=shell/%.pylint_log)
|
|
else
|
|
PYLINT_TEST_LOGS :=
|
|
endif
|
|
|
|
$(OUTPUT)%.pylint_log: %
|
|
$(call rule_mkdir)
|
|
$(Q)$(call echo-cmd,test)pylint "$<" > $@ || (cat $@ && rm $@ && false)
|
|
|
|
perf-test-y += $(PYLINT_TEST_LOGS)
|