torvalds/linux
3
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-03-22 07:27:12 +08:00
Code Issues Packages Projects Releases Wiki Activity
Files
9250673cf23572b08c51bcdbb2919e9982bfc36b
linux/drivers/ata
History
Guenter Roeck ee0e6e69a7 ata: libata-eh: Fix detection of deferred qc timeouts 
If the ata_qc_for_each_raw() loop finishes without finding a matching SCSI
command for any QC, the variable qc will hold a pointer to the last element
examined, which has the tag i == ATA_MAX_QUEUE - 1. This qc can match the
port deferred QC (ap->deferred_qc).

If that happens, the condition qc == ap->deferred_qc evaluates to true
despite the loop not breaking with a match on the SCSI command for this QC.
In that case, the error handler mistakenly intercepts a command that has
not been issued yet and that has not timed out, and thus erroneously
returning a timeout error.

Fix the problem by checking for i < ATA_MAX_QUEUE in addition to
qc == ap->deferred_qc.

The problem was found by an experimental code review agent based on
gemini-3.1-pro while reviewing backports into v6.18.y.

Assisted-by: Gemini:gemini-3.1-pro
Fixes: eddb98ad93 ("ata: libata-eh: correctly handle deferred qc timeouts")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
[cassel: modified commit log as suggested by Damien]
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Niklas Cassel <cassel@kernel.org>
2026-03-06 09:58:47 +01:00
..
pata_parport
Convert 'alloc_obj' family to use the new default GFP_KERNEL argument
2026-02-21 17:09:51 -08:00
acard-ahci.c
ata: ahci: Replace deprecated PCI functions
2024-10-30 16:07:36 -05:00
ahci_brcm.c
ahci: Introduce ahci_ignore_port() helper
2025-01-09 17:52:17 +09:00
ahci_ceva.c
ahci: Introduce ahci_ignore_port() helper
2025-01-09 17:52:17 +09:00
ahci_da850.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
ahci_dm816.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
ahci_dwc.c
ata: ahci-dwc: Simplify with scoped for each OF child loop
2026-01-08 17:42:56 +09:00
ahci_imx.c
ata: ahci-imx: Fix Wvoid-pointer-to-enum-cast warning
2026-01-08 17:43:00 +09:00
ahci_mtk.c
ata: Switch back to struct platform_driver::remove()
2024-10-17 09:55:08 +02:00
ahci_mvebu.c
ata: Switch back to struct platform_driver::remove()
2024-10-17 09:55:08 +02:00
ahci_octeon.c
ata: ahci_octeon: Convert to devm_platform_ioremap_resource()
2023-08-02 17:37:06 +09:00
ahci_platform.c
ata: Switch back to struct platform_driver::remove()
2024-10-17 09:55:08 +02:00
ahci_qoriq.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
ahci_seattle.c
ata: Switch back to struct platform_driver::remove()
2024-10-17 09:55:08 +02:00
ahci_st.c
ahci: st: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr()
2025-01-15 15:21:27 +01:00
ahci_sunxi.c
ata: Switch back to struct platform_driver::remove()
2024-10-17 09:55:08 +02:00
ahci_tegra.c
ata: Switch back to struct platform_driver::remove()
2024-10-17 09:55:08 +02:00
ahci_xgene.c
ata: ahci-xgene: Fix Wvoid-pointer-to-enum-cast warning
2026-01-08 17:43:04 +09:00
ahci.c
ata: ahci: Do not read the per port area for unimplemented ports
2026-01-13 22:00:02 +09:00
ahci.h
ata: ahci: Allow ignoring the external/hotplug capability of ports
2025-08-26 07:44:32 +09:00
ata_generic.c
ata: Constify struct pci_device_id
2024-12-03 05:10:20 +01:00
ata_piix.c
ata: libata-sata: Add link_power_management_supported sysfs attribute
2025-07-31 12:56:21 +09:00
Kconfig
ata: pata_legacy: remove VLB support
2026-02-02 13:47:37 +09:00
libahci_platform.c
Convert more 'alloc_obj' cases to default GFP_KERNEL arguments
2026-02-21 20:03:00 -08:00
libahci.c
ata: libata-sata: Add link_power_management_supported sysfs attribute
2025-07-31 12:56:21 +09:00
libata-acpi.c
Convert 'alloc_obj' family to use the new default GFP_KERNEL argument
2026-02-21 17:09:51 -08:00
libata-core.c
ata: libata-core: Add BRIDGE_OK quirk for QEMU drives
2026-03-05 16:49:02 +01:00
libata-eh.c
ata: libata-eh: Fix detection of deferred qc timeouts
2026-03-06 09:58:47 +01:00
libata-pata-timings.c
ata: separate PATA timings code from libata-core.c
2020-03-26 10:28:19 -06:00
libata-pmp.c
treewide: Replace kmalloc with kmalloc_obj for non-scalar types
2026-02-21 01:02:28 -08:00
libata-sata.c
Convert 'alloc_obj' family to use the new default GFP_KERNEL argument
2026-02-21 17:09:51 -08:00
libata-scsi.c
ata: libata: cancel pending work after clearing deferred_qc
2026-03-04 10:42:12 +01:00
libata-sff.c
ata: libata-sff: add WQ_PERCPU to alloc_workqueue users
2025-11-07 09:42:36 +01:00
libata-trace.c
ata: scsi: rename flag ATA_QCFLAG_FAILED to ATA_QCFLAG_EH
2023-01-04 13:36:26 +09:00
libata-transport.c
Convert 'alloc_obj' family to use the new default GFP_KERNEL argument
2026-02-21 17:09:51 -08:00
libata-transport.h
ata,scsi: Remove wrappers ata_sas_tport_{add,delete}()
2024-07-04 11:52:31 +02:00
libata-zpodd.c
Convert 'alloc_obj' family to use the new default GFP_KERNEL argument
2026-02-21 17:09:51 -08:00
libata.h
Merge tag 'ata-6.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux
2026-02-12 17:12:43 -08:00
Makefile
Merge tag 'ata-6.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata
2023-02-22 13:35:51 -08:00
pata_acpi.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_ali.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_amd.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_arasan_cf.c
ata: Switch back to struct platform_driver::remove()
2024-10-17 09:55:08 +02:00
pata_artop.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_atiixp.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_atp867x.c
ata: Constify struct pci_device_id
2024-12-03 05:10:20 +01:00
pata_buddha.c
ata: pata_buddha: Remove #include <asm/ide.h>
2023-08-24 08:09:59 +09:00
pata_cmd64x.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_cmd640.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_cs5520.c
ata: pata_cs5520: Rephrase file header comment
2024-07-30 07:10:30 +09:00
pata_cs5530.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_cs5535.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_cs5536.c
ata: pata_cs5536: fix build on 32-bit UML
2025-06-10 14:26:27 +02:00
pata_cypress.c
ata: pata_cypress: fix typo in error message
2026-02-02 13:47:40 +09:00
pata_efar.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_ep93xx.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_falcon.c
ata: Switch back to struct platform_driver::remove()
2024-10-17 09:55:08 +02:00
pata_ftide010.c
ata: pata_ftide010: Fix some DMA timings
2026-02-04 12:23:23 +01:00
pata_gayle.c
ata: Switch back to struct platform_driver::remove()
2024-10-17 09:55:08 +02:00
pata_hpt3x2n.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_hpt3x3.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_hpt37x.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_hpt366.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_icside.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_imx.c
ata: Switch back to struct platform_driver::remove()
2024-10-17 09:55:08 +02:00
pata_isapnp.c
ata: pata_isapnp: Add missing error check for devm_ioport_map()
2023-11-20 09:22:26 +09:00
pata_it821x.c
ata: pata_it821x: Replace deprecated strcpy with strscpy in it821x_display_disk
2025-10-23 14:23:40 +02:00
pata_it8213.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_ixp4xx_cf.c
ata: Switch back to struct platform_driver::remove()
2024-10-17 09:55:08 +02:00
pata_jmicron.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_legacy.c
ata: pata_legacy: remove VLB support
2026-02-02 13:47:37 +09:00
pata_macio.c
ata: pata_macio: Remove space before newline
2025-08-01 08:43:08 +09:00
pata_marvell.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_mpc52xx.c
ata: Switch back to struct platform_driver::remove()
2024-10-17 09:55:08 +02:00
pata_mpiix.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_netcell.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_ninja32.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_ns87410.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_ns87415.c
ata: pata_ns87415: mark ns87560_tf_read static
2023-07-28 08:52:42 +09:00
pata_octeon_cf.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_of_platform.c
ata: Switch back to struct platform_driver::remove()
2024-10-17 09:55:08 +02:00
pata_oldpiix.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_opti.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_optidma.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_pcmcia.c
ata: pata_pcmcia: Add Iomega Clik! PCMCIA ATA/ATAPI Adapter
2025-11-18 21:58:41 +01:00
pata_pdc202xx_old.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_pdc2027x.c
ata: pata_pdc2027x: Remove space before newline and abbreviations
2025-08-01 08:43:11 +09:00
pata_piccolo.c
ata: Constify struct pci_device_id
2024-12-03 05:10:20 +01:00
pata_platform.c
ata: Switch back to struct platform_driver::remove()
2024-10-17 09:55:08 +02:00
pata_pxa.c
ata: pata_pxa: Fix potential NULL pointer dereference in pxa_ata_probe()
2025-04-08 12:36:03 +09:00
pata_radisys.c
ata: Fix typos in the comment
2024-10-01 09:22:02 +02:00
pata_rb532_cf.c
ata: Switch back to struct platform_driver::remove()
2024-10-17 09:55:08 +02:00
pata_rdc.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_rz1000.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_sc1200.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_sch.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_serverworks.c
ata: pata_serverworks: Do not use the term blacklist
2024-07-30 07:10:08 +09:00
pata_sil680.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_sis.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_sl82c105.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_triflex.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pata_via.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
pdc_adma.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
sata_dwc_460ex.c
Convert 'alloc_obj' family to use the new default GFP_KERNEL argument
2026-02-21 17:09:51 -08:00
sata_fsl.c
Convert 'alloc_obj' family to use the new default GFP_KERNEL argument
2026-02-21 17:09:51 -08:00
sata_gemini.c
ata: sata_gemini: Remove remaining reset glue
2024-12-16 22:36:27 +09:00
sata_gemini.h
ata: sata_gemini: Remove unused gemini_sata_reset_bridge()
2024-12-11 13:18:25 +09:00
sata_highbank.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
sata_inic162x.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
sata_mv.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
sata_nv.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
sata_promise.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
sata_promise.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
sata_qstor.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
sata_rcar.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
sata_sil24.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
sata_sil.c
ata: libata-core: Rename ata_do_set_mode()
2025-07-04 10:36:00 +02:00
sata_sis.c
ata: Use always-managed version of pci_intx()
2025-01-18 14:38:49 -06:00
sata_svw.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
sata_sx4.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
sata_uli.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
sata_via.c
ata: libata-eh: Simplify reset operation management
2025-07-16 09:31:43 +02:00
sata_vsc.c
ata: Use always-managed version of pci_intx()
2025-01-18 14:38:49 -06:00
sis.h
…