mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-04 20:19:47 +08:00
45c21a0e5b
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array
members have incomplete type[1]. There are some instances of code in
which the sizeof operator is being incorrectly/erroneously applied to
zero-length arrays and the result is zero. Such instances may be hiding
some bugs. So, this work (flexible-array member conversions) will also
help to get completely rid of those sorts of issues.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit
|
||
|---|---|---|
| .. | ||
| alive.h | ||
| binding.h | ||
| cmdhdr.h | ||
| coex.h | ||
| commands.h | ||
| config.h | ||
| context.h | ||
| d3.h | ||
| datapath.h | ||
| dbg-tlv.h | ||
| debug.h | ||
| filter.h | ||
| led.h | ||
| location.h | ||
| mac-cfg.h | ||
| mac.h | ||
| nvm-reg.h | ||
| offload.h | ||
| paging.h | ||
| phy-ctxt.h | ||
| phy.h | ||
| power.h | ||
| rs.h | ||
| rx.h | ||
| scan.h | ||
| sf.h | ||
| soc.h | ||
| sta.h | ||
| stats.h | ||
| tdls.h | ||
| time-event.h | ||
| tx.h | ||
| txq.h | ||