Arnd Bergmann a5a056c8d2 HID: intel-thc: fix CONFIG_HID dependency ... In drivers/hid/, most drivers depend on CONFIG_HID, while a couple of the drivers in subdirectories instead depend on CONFIG_HID_SUPPORT and use 'select HID'. With the newly added INTEL_THC_HID, this causes a build warning for a circular dependency: WARNING: unmet direct dependencies detected for HID Depends on [m]: HID_SUPPORT [=y] && INPUT [=m] Selected by [y]: - INTEL_THC_HID [=y] && HID_SUPPORT [=y] && X86_64 [=y] && PCI [=y] && ACPI [=y] WARNING: unmet direct dependencies detected for INPUT_FF_MEMLESS Depends on [m]: INPUT [=m] Selected by [y]: - HID_MICROSOFT [=y] && HID_SUPPORT [=y] && HID [=y] - GREENASIA_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_GREENASIA [=y] - HID_WIIMOTE [=y] && HID_SUPPORT [=y] && HID [=y] && LEDS_CLASS [=y] - ZEROPLUS_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_ZEROPLUS [=y] Selected by [m]: - HID_ACRUX_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_ACRUX [=m] - HID_EMS_FF [=m] && HID_SUPPORT [=y] && HID [=y] - HID_GOOGLE_STADIA_FF [=m] && HID_SUPPORT [=y] && HID [=y] - PANTHERLORD_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_PANTHERLORD [=m] It's better to be consistent and always use 'depends on HID' for HID drivers. The notable exception here is USB_KBD/USB_MOUSE, which are alternative implementations that do not depend on the HID subsystem. Do this by extending the "if HID" section below, which means that a few of the duplicate "depends on HID" and "depends on INPUT" statements can be removed in the process. Fixes: 1b2d05384c ("HID: intel-thc-hid: Add basic THC driver skeleton") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> Reviewed-by: Even Xu <even.xu@intel.com> Signed-off-by: Jiri Kosina <jkosina@suse.com>		2025-02-03 10:56:43 +01:00
..
hid-core.c	Merge branch 'for-6.13/core' into for-linus	2024-11-18 21:58:55 +01:00
hid-pidff.c	HID: pidff: fix error return code in hid_pidff_init()	2021-05-27 15:40:34 +02:00
hiddev.c	USB: make devnode() callback in usb_class_driver take a const *	2022-10-20 12:11:56 +02:00
Kconfig	HID: intel-thc: fix CONFIG_HID dependency	2025-02-03 10:56:43 +01:00
Makefile	HID: core: move the dynamic quirks handling in core	2017-11-21 11:14:48 +01:00
usbhid.h	Revert "HID: usbhid: do not sleep when opening device"	2020-08-18 19:54:04 +02:00
usbkbd.c	HID: move from strlcpy with unused retval to strscpy	2022-08-25 11:44:27 +02:00
usbmouse.c	HID: move from strlcpy with unused retval to strscpy	2022-08-25 11:44:27 +02:00