mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-04 20:19:47 +08:00
532f0d1096
ARCH=arm build fails with:
CC [M] drivers/gpu/drm/bridge/ti-tdp158.o
../drivers/gpu/drm/bridge/ti-tdp158.c: In function ‘tdp158_enable’:
../drivers/gpu/drm/bridge/ti-tdp158.c:31:9: error: implicit declaration of function ‘gpiod_set_value_cansleep’ [-Werror=implicit-function-declaration]
31 | gpiod_set_value_cansleep(tdp158->enable, 1);
| ^~~~~~~~~~~~~~~~~~~~~~~~
../drivers/gpu/drm/bridge/ti-tdp158.c: In function ‘tdp158_probe’:
../drivers/gpu/drm/bridge/ti-tdp158.c:80:26: error: implicit declaration of function ‘devm_gpiod_get_optional’; did you mean ‘devm_regulator_get_optional’? [-Werror=implicit-function-declaration]
80 | tdp158->enable = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
| ^~~~~~~~~~~~~~~~~~~~~~~
| devm_regulator_get_optional
../drivers/gpu/drm/bridge/ti-tdp158.c:80:65: error: ‘GPIOD_OUT_LOW’ undeclared (first use in this function)
80 | tdp158->enable = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
| ^~~~~~~~~~~~~
../drivers/gpu/drm/bridge/ti-tdp158.c:80:65: note: each undeclared identifier is reported only once for each function it appears in
Add the proper gpio consumer #include to fix this, and juggle the
include order to be a bit more pleasant on the eye while at it.
Fixes: a15710027a ("drm/bridge: add support for TI TDP158")
Cc: Marc Gonzalez <mgonzalez@freebox.fr>
Cc: Robert Foss <rfoss@kernel.org>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240904085206.3331553-1-jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
112 lines
3.0 KiB
C
112 lines
3.0 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright 2024 Freebox SAS
|
|
*/
|
|
|
|
#include <linux/gpio/consumer.h>
|
|
#include <linux/i2c.h>
|
|
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_bridge.h>
|
|
|
|
struct tdp158 {
|
|
struct drm_bridge bridge;
|
|
struct drm_bridge *next;
|
|
struct gpio_desc *enable; // Operation Enable - pin 36
|
|
struct regulator *vcc; // 3.3V
|
|
struct regulator *vdd; // 1.1V
|
|
struct device *dev;
|
|
};
|
|
|
|
static void tdp158_enable(struct drm_bridge *bridge, struct drm_bridge_state *prev)
|
|
{
|
|
int err;
|
|
struct tdp158 *tdp158 = bridge->driver_private;
|
|
|
|
err = regulator_enable(tdp158->vcc);
|
|
if (err)
|
|
dev_err(tdp158->dev, "failed to enable vcc: %d", err);
|
|
|
|
err = regulator_enable(tdp158->vdd);
|
|
if (err)
|
|
dev_err(tdp158->dev, "failed to enable vdd: %d", err);
|
|
|
|
gpiod_set_value_cansleep(tdp158->enable, 1);
|
|
}
|
|
|
|
static void tdp158_disable(struct drm_bridge *bridge, struct drm_bridge_state *prev)
|
|
{
|
|
struct tdp158 *tdp158 = bridge->driver_private;
|
|
|
|
gpiod_set_value_cansleep(tdp158->enable, 0);
|
|
regulator_disable(tdp158->vdd);
|
|
regulator_disable(tdp158->vcc);
|
|
}
|
|
|
|
static int tdp158_attach(struct drm_bridge *bridge, enum drm_bridge_attach_flags flags)
|
|
{
|
|
struct tdp158 *tdp158 = bridge->driver_private;
|
|
|
|
return drm_bridge_attach(bridge->encoder, tdp158->next, bridge, flags);
|
|
}
|
|
|
|
static const struct drm_bridge_funcs tdp158_bridge_funcs = {
|
|
.attach = tdp158_attach,
|
|
.atomic_enable = tdp158_enable,
|
|
.atomic_disable = tdp158_disable,
|
|
.atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
|
|
.atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
|
|
.atomic_reset = drm_atomic_helper_bridge_reset,
|
|
};
|
|
|
|
static int tdp158_probe(struct i2c_client *client)
|
|
{
|
|
struct tdp158 *tdp158;
|
|
struct device *dev = &client->dev;
|
|
|
|
tdp158 = devm_kzalloc(dev, sizeof(*tdp158), GFP_KERNEL);
|
|
if (!tdp158)
|
|
return -ENOMEM;
|
|
|
|
tdp158->next = devm_drm_of_get_bridge(dev, dev->of_node, 1, 0);
|
|
if (IS_ERR(tdp158->next))
|
|
return dev_err_probe(dev, PTR_ERR(tdp158->next), "missing bridge");
|
|
|
|
tdp158->vcc = devm_regulator_get(dev, "vcc");
|
|
if (IS_ERR(tdp158->vcc))
|
|
return dev_err_probe(dev, PTR_ERR(tdp158->vcc), "vcc");
|
|
|
|
tdp158->vdd = devm_regulator_get(dev, "vdd");
|
|
if (IS_ERR(tdp158->vdd))
|
|
return dev_err_probe(dev, PTR_ERR(tdp158->vdd), "vdd");
|
|
|
|
tdp158->enable = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
|
|
if (IS_ERR(tdp158->enable))
|
|
return dev_err_probe(dev, PTR_ERR(tdp158->enable), "enable");
|
|
|
|
tdp158->bridge.of_node = dev->of_node;
|
|
tdp158->bridge.funcs = &tdp158_bridge_funcs;
|
|
tdp158->bridge.driver_private = tdp158;
|
|
tdp158->dev = dev;
|
|
|
|
return devm_drm_bridge_add(dev, &tdp158->bridge);
|
|
}
|
|
|
|
static const struct of_device_id tdp158_match_table[] = {
|
|
{ .compatible = "ti,tdp158" },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, tdp158_match_table);
|
|
|
|
static struct i2c_driver tdp158_driver = {
|
|
.probe = tdp158_probe,
|
|
.driver = {
|
|
.name = "tdp158",
|
|
.of_match_table = tdp158_match_table,
|
|
},
|
|
};
|
|
module_i2c_driver(tdp158_driver);
|
|
|
|
MODULE_DESCRIPTION("TI TDP158 driver");
|
|
MODULE_LICENSE("GPL");
|