2
0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-04 20:19:47 +08:00
linux/drivers/gpu/drm/bridge/analogix
Heiko Stuebner fd03f82a02 drm/bridge: analogix_dp: Fix clk-disable removal
Commit 6579a03e68 ("drm/bridge: analogix_dp: Remove the unnecessary
calls to clk_disable_unprepare() during probing") removed the mismatched
clock_disable calls from analogix_dp_probe.

But that patch was created and sent before
commit e5e9fa9f7a ("drm/bridge: analogix_dp: Add support to get panel
from the DP AUX bus") was merged, so couldn't know about this change.

So in the original patch the last change is
    if (ret) {
	dev_err(&pdev->dev, "failed to request irq\n");
-		goto err_disable_clk;
+		return ERR_PTR(ret);
    }
    disable_irq(dp->irq);

    return dp;
-
-err_disable_clk:
-	clk_disable_unprepare(dp->clock);
-	return ERR_PTR(ret);
 }
 EXPORT_SYMBOL_GPL(analogix_dp_probe);

the analogix_dp_core.c actually now has the runtime-pm handling between
disable_irq() and return do introducing another goto err_clk_disable there.

So remove that one too and return an error pointer, to not create build
breakage.

Fixes: 6579a03e68 ("drm/bridge: analogix_dp: Remove the unnecessary calls to clk_disable_unprepare() during probing")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250527225120.3361663-1-heiko@sntech.de
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
2025-05-28 16:53:31 +03:00
..
analogix_dp_core.c drm/bridge: analogix_dp: Fix clk-disable removal 2025-05-28 16:53:31 +03:00
analogix_dp_core.h drm/bridge: analogic_dp: drop panel_lock 2025-04-22 16:49:11 +03:00
analogix_dp_reg.c drm/bridge: analogix_dp: Add support for phy configuration. 2025-04-21 01:26:06 +03:00
analogix_dp_reg.h drm/bridge: analogix_dp: handle AUX transfer timeouts 2024-06-27 11:52:19 +02:00
analogix-anx78xx.c drm/bridge: anx78xx: Switch to common helpers to power up/down dp link 2025-04-02 17:41:27 +03:00
analogix-anx78xx.h drm/bridge: split some definitions of ANX78xx to dedicated headers 2019-11-08 10:27:32 +01:00
analogix-anx6345.c drm/bridge: analogix-anx6345: convert to devm_drm_bridge_alloc() API 2025-04-29 11:21:20 +02:00
analogix-i2c-dptx.c drm: Rename dp/ to display/ 2022-04-25 11:17:45 +02:00
analogix-i2c-dptx.h drm/bridge: Prepare Analogix anx6345 support 2019-11-08 10:27:53 +01:00
analogix-i2c-txcommon.h drm/bridge: Prepare Analogix anx6345 support 2019-11-08 10:27:53 +01:00
anx7625.c drm/bridge: anx7625: change the gpiod_set_value API 2025-05-05 17:23:34 +03:00
anx7625.h drm/bridge: anx7625: use struct drm_edid more 2024-05-13 19:10:55 +02:00
Kconfig Revert "drm: Switch DRM_DISPLAY_HELPER to depends on" 2024-05-02 17:58:23 +02:00
Makefile drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP 2020-10-16 23:35:16 +02:00