mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-04 20:19:47 +08:00
c56c96303e
In line 800 (#1), nfp_cpp_area_alloc() allocates and initializes a
CPP area structure. But in line 807 (#2), when the cache is allocated
failed, this CPP area structure is not freed, which will result in
memory leak.
We can fix it by freeing the CPP area when the cache is allocated
failed (#2).
792 int nfp_cpp_area_cache_add(struct nfp_cpp *cpp, size_t size)
793 {
794 struct nfp_cpp_area_cache *cache;
795 struct nfp_cpp_area *area;
800 area = nfp_cpp_area_alloc(cpp, NFP_CPP_ID(7, NFP_CPP_ACTION_RW, 0),
801 0, size);
// #1: allocates and initializes
802 if (!area)
803 return -ENOMEM;
805 cache = kzalloc(sizeof(*cache), GFP_KERNEL);
806 if (!cache)
807 return -ENOMEM; // #2: missing free
817 return 0;
818 }
Fixes:
|
||
|---|---|---|
| .. | ||
| abm | ||
| bpf | ||
| crypto | ||
| flower | ||
| nfpcore | ||
| nic | ||
| ccm_mbox.c | ||
| ccm.c | ||
| ccm.h | ||
| devlink_param.c | ||
| Makefile | ||
| nfp_abi.h | ||
| nfp_app_nic.c | ||
| nfp_app.c | ||
| nfp_app.h | ||
| nfp_asm.c | ||
| nfp_asm.h | ||
| nfp_devlink.c | ||
| nfp_hwmon.c | ||
| nfp_main.c | ||
| nfp_main.h | ||
| nfp_net_common.c | ||
| nfp_net_ctrl.c | ||
| nfp_net_ctrl.h | ||
| nfp_net_debugdump.c | ||
| nfp_net_debugfs.c | ||
| nfp_net_ethtool.c | ||
| nfp_net_main.c | ||
| nfp_net_repr.c | ||
| nfp_net_repr.h | ||
| nfp_net_sriov.c | ||
| nfp_net_sriov.h | ||
| nfp_net.h | ||
| nfp_netvf_main.c | ||
| nfp_port.c | ||
| nfp_port.h | ||
| nfp_shared_buf.c | ||