mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-04 20:19:47 +08:00
7d49ced808
perf test "perf script tests" fails as below in systems
with python 3.6
File "/home/athira/linux/tools/perf/tests/shell/../../scripts/python/parallel-perf.py", line 442
if line := p.stdout.readline():
^
SyntaxError: invalid syntax
--- Cleaning up ---
---- end(-1) ----
92: perf script tests: FAILED!
This happens because ":=" is a new syntax that assigns values
to variables as part of a larger expression. This is introduced
from python 3.8 and hence fails in setup with python 3.6
Address this by splitting the large expression and check the
value in two steps:
Previous line: if line := p.stdout.readline():
Current change:
line = p.stdout.readline()
if line:
With patch
./perf test "perf script tests"
93: perf script tests: Ok
Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: akanksha@linux.ibm.com
Cc: kjain@linux.ibm.com
Cc: maddy@linux.ibm.com
Cc: disgoel@linux.vnet.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240623064850.83720-3-atrajeev@linux.vnet.ibm.com
|
||
|---|---|---|
| .. | ||
| bin | ||
| Perf-Trace-Util | ||
| arm-cs-trace-disasm.py | ||
| check-perf-trace.py | ||
| compaction-times.py | ||
| event_analyzing_sample.py | ||
| export-to-postgresql.py | ||
| export-to-sqlite.py | ||
| exported-sql-viewer.py | ||
| failed-syscalls-by-pid.py | ||
| flamegraph.py | ||
| futex-contention.py | ||
| gecko.py | ||
| intel-pt-events.py | ||
| libxed.py | ||
| mem-phys-addr.py | ||
| net_dropmonitor.py | ||
| netdev-times.py | ||
| parallel-perf.py | ||
| powerpc-hcalls.py | ||
| sched-migration.py | ||
| sctop.py | ||
| stackcollapse.py | ||
| stat-cpi.py | ||
| syscall-counts-by-pid.py | ||
| syscall-counts.py | ||
| task-analyzer.py | ||