2
0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-04 20:19:47 +08:00
linux/drivers/net/ethernet/intel/igb
Paolo Abeni 8aba27c4a5 igb: cope with large MAX_SKB_FRAGS
Sabrina reports that the igb driver does not cope well with large
MAX_SKB_FRAG values: setting MAX_SKB_FRAG to 45 causes payload
corruption on TX.

An easy reproducer is to run ssh to connect to the machine.  With
MAX_SKB_FRAGS=17 it works, with MAX_SKB_FRAGS=45 it fails.  This has
been reported originally in
https://bugzilla.redhat.com/show_bug.cgi?id=2265320

The root cause of the issue is that the driver does not take into
account properly the (possibly large) shared info size when selecting
the ring layout, and will try to fit two packets inside the same 4K
page even when the 1st fraglist will trump over the 2nd head.

Address the issue by checking if 2K buffers are insufficient.

Fixes: 3948b05950 ("net: introduce a config option to tweak MAX_SKB_FRAGS")
Reported-by: Jan Tluka <jtluka@redhat.com>
Reported-by: Jirka Hladky <jhladky@redhat.com>
Reported-by: Sabrina Dubroca <sd@queasysnail.net>
Tested-by: Sabrina Dubroca <sd@queasysnail.net>
Tested-by: Corinna Vinschen <vinschen@redhat.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
Link: https://patch.msgid.link/20240816152034.1453285-1-vinschen@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2024-08-20 15:46:52 -07:00
..
e1000_82575.c intel: legacy: field get conversion 2023-12-18 11:20:43 -08:00
e1000_82575.h
e1000_defines.h igb: Remove duplicate defines 2022-06-09 10:05:31 -07:00
e1000_hw.h
e1000_i210.c intel: legacy: field get conversion 2023-12-18 11:20:43 -08:00
e1000_i210.h
e1000_mac.c intel: legacy: field get conversion 2023-12-18 11:20:43 -08:00
e1000_mac.h
e1000_mbx.c intel: clean up mismatched header comments 2021-03-23 11:34:02 -07:00
e1000_mbx.h
e1000_nvm.c intel: legacy: field get conversion 2023-12-18 11:20:43 -08:00
e1000_nvm.h
e1000_phy.c intel: legacy: field get conversion 2023-12-18 11:20:43 -08:00
e1000_phy.h
e1000_regs.h igb: Remove duplicate defines 2022-06-09 10:05:31 -07:00
igb_ethtool.c net: Add struct kernel_ethtool_ts_info 2024-07-15 08:02:26 -07:00
igb_hwmon.c
igb_main.c igb: cope with large MAX_SKB_FRAGS 2024-08-20 15:46:52 -07:00
igb_ptp.c igb: extend PTP timestamp adjustments to i211 2024-02-28 20:16:48 -08:00
igb.h igb: Fix string truncation warnings in igb_set_fw_version 2024-02-14 09:43:09 -08:00
Makefile net: intel: Use *-y instead of *-objs in Makefile 2024-06-10 19:52:44 -07:00