mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-04 20:19:47 +08:00

The ice_sq_done function is used to check the control queue head register and determine whether or not the control queue processing is done. This function is called in a loop checking against jiffies for a specified timeout. The pattern of reading a register in a loop until a condition is true or a timeout is reached is a relatively common pattern. In fact, the kernel provides a read_poll_timeout function implementing this behavior in <linux/iopoll.h> Use of read_poll_timeout is preferred over directly coding these loops. However, using it in the ice driver is a bit more difficult because of the rd32 wrapper. Implement a rd32_poll_timeout wrapper based on read_poll_timeout. Refactor ice_sq_done to use rd32_poll_timeout, replacing the loop calling ice_sq_done in ice_sq_send_cmd. This simplifies the logic down to a single ice_sq_done() call. The implementation of rd32_poll_timeout uses microseconds for its timeout value, so update the CQ timeout macros used to be specified in microseconds units as well instead of using HZ for jiffies. Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
86 lines
2.3 KiB
C
86 lines
2.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/* Copyright (c) 2018, Intel Corporation. */
|
|
|
|
#ifndef _ICE_OSDEP_H_
|
|
#define _ICE_OSDEP_H_
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/ctype.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/io.h>
|
|
#include <linux/bitops.h>
|
|
#include <linux/ethtool.h>
|
|
#include <linux/etherdevice.h>
|
|
#include <linux/if_ether.h>
|
|
#include <linux/iopoll.h>
|
|
#include <linux/pci_ids.h>
|
|
#ifndef CONFIG_64BIT
|
|
#include <linux/io-64-nonatomic-lo-hi.h>
|
|
#endif
|
|
#include <net/udp_tunnel.h>
|
|
|
|
#define wr32(a, reg, value) writel((value), ((a)->hw_addr + (reg)))
|
|
#define rd32(a, reg) readl((a)->hw_addr + (reg))
|
|
#define wr64(a, reg, value) writeq((value), ((a)->hw_addr + (reg)))
|
|
#define rd64(a, reg) readq((a)->hw_addr + (reg))
|
|
|
|
#define rd32_poll_timeout(a, addr, val, cond, delay_us, timeout_us) \
|
|
read_poll_timeout(rd32, val, cond, delay_us, timeout_us, false, a, addr)
|
|
|
|
#define ice_flush(a) rd32((a), GLGEN_STAT)
|
|
#define ICE_M(m, s) ((m ## U) << (s))
|
|
|
|
struct ice_dma_mem {
|
|
void *va;
|
|
dma_addr_t pa;
|
|
size_t size;
|
|
};
|
|
|
|
struct ice_hw;
|
|
struct device *ice_hw_to_dev(struct ice_hw *hw);
|
|
|
|
#ifdef CONFIG_DYNAMIC_DEBUG
|
|
#define ice_debug(hw, type, fmt, args...) \
|
|
dev_dbg(ice_hw_to_dev(hw), fmt, ##args)
|
|
|
|
#define ice_debug_array(hw, type, rowsize, groupsize, buf, len) \
|
|
print_hex_dump_debug(KBUILD_MODNAME " ", \
|
|
DUMP_PREFIX_OFFSET, rowsize, \
|
|
groupsize, buf, len, false)
|
|
#else
|
|
#define ice_debug(hw, type, fmt, args...) \
|
|
do { \
|
|
if ((type) & (hw)->debug_mask) \
|
|
dev_info(ice_hw_to_dev(hw), fmt, ##args); \
|
|
} while (0)
|
|
|
|
#ifdef DEBUG
|
|
#define ice_debug_array(hw, type, rowsize, groupsize, buf, len) \
|
|
do { \
|
|
if ((type) & (hw)->debug_mask) \
|
|
print_hex_dump_debug(KBUILD_MODNAME, \
|
|
DUMP_PREFIX_OFFSET, \
|
|
rowsize, groupsize, buf, \
|
|
len, false); \
|
|
} while (0)
|
|
#else
|
|
#define ice_debug_array(hw, type, rowsize, groupsize, buf, len) \
|
|
do { \
|
|
struct ice_hw *hw_l = hw; \
|
|
if ((type) & (hw_l)->debug_mask) { \
|
|
u16 len_l = len; \
|
|
u8 *buf_l = buf; \
|
|
int i; \
|
|
for (i = 0; i < (len_l - 16); i += 16) \
|
|
ice_debug(hw_l, type, "0x%04X %16ph\n",\
|
|
i, ((buf_l) + i)); \
|
|
if (i < len_l) \
|
|
ice_debug(hw_l, type, "0x%04X %*ph\n", \
|
|
i, ((len_l) - i), ((buf_l) + i));\
|
|
} \
|
|
} while (0)
|
|
#endif /* DEBUG */
|
|
#endif /* CONFIG_DYNAMIC_DEBUG */
|
|
|
|
#endif /* _ICE_OSDEP_H_ */
|