mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-04 20:19:47 +08:00
c3d9c17f48
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function
returns the number of the created entries in the DMA address space.
However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and
dma_unmap_sg must be called with the original number of the entries
passed to the dma_map_sg().
struct sg_table is a common structure used for describing a non-contiguous
memory buffer, used commonly in the DRM and graphics subsystems. It
consists of a scatterlist with memory pages and DMA addresses (sgl entry),
as well as the number of scatterlist entries: CPU pages (orig_nents entry)
and DMA mapped pages (nents entry).
It turned out that it was a common mistake to misuse nents and orig_nents
entries, calling DMA-mapping functions with a wrong number of entries or
ignoring the number of mapped entries returned by the dma_map_sg()
function.
To avoid such issues, lets use a common dma-mapping wrappers operating
directly on the struct sg_table objects and use scatterlist page
iterators where possible. This, almost always, hides references to the
nents and orig_nents entries, making the code robust, easier to follow
and copy/paste safe.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| lima_bcast.c | ||
| lima_bcast.h | ||
| lima_ctx.c | ||
| lima_ctx.h | ||
| lima_devfreq.c | ||
| lima_devfreq.h | ||
| lima_device.c | ||
| lima_device.h | ||
| lima_dlbu.c | ||
| lima_dlbu.h | ||
| lima_drv.c | ||
| lima_drv.h | ||
| lima_dump.h | ||
| lima_gem.c | ||
| lima_gem.h | ||
| lima_gp.c | ||
| lima_gp.h | ||
| lima_l2_cache.c | ||
| lima_l2_cache.h | ||
| lima_mmu.c | ||
| lima_mmu.h | ||
| lima_pmu.c | ||
| lima_pmu.h | ||
| lima_pp.c | ||
| lima_pp.h | ||
| lima_regs.h | ||
| lima_sched.c | ||
| lima_sched.h | ||
| lima_trace.c | ||
| lima_trace.h | ||
| lima_vm.c | ||
| lima_vm.h | ||
| Makefile | ||