mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-04 20:19:47 +08:00
b6afeb87ad
When building with Clang we encounter these warnings:
| drivers/net/ethernet/qlogic/qed/qed_dev.c:416:30: error: format
| specifies type 'char' but the argument has type 'u32' (aka 'unsigned
| int') [-Werror,-Wformat] i);
-
| drivers/net/ethernet/qlogic/qed/qed_dev.c:630:13: error: format
| specifies type 'char' but the argument has type 'int' [-Werror,-Wformat]
| p_llh_info->num_ppfid - 1);
For the first warning, `i` is a u32 which is much wider than the format
specifier `%hhd` describes. This results in a loss of bits after 2^7.
The second warning involves implicit integer promotion as the resulting
type of addition cannot be smaller than an int.
example:
``
uint8_t a = 4, b = 7;
int size = sizeof(a + b - 1);
printf("%d\n", size);
// output: 4
```
See more:
(https://wiki.sei.cmu.edu/confluence/display/c/INT02-C.+Understand+integer+conversion+rules)
"Integer types smaller than int are promoted when an operation is
performed on them. If all values of the original type can be represented
as an int, the value of the smaller type is converted to an int;
otherwise, it is converted to an unsigned int."
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Justin Stitt <justinstitt@google.com>
Link: https://lore.kernel.org/r/20220711232404.2189257-1-justinstitt@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
||
|---|---|---|
| .. | ||
| Makefile | ||
| qed_chain.c | ||
| qed_cxt.c | ||
| qed_cxt.h | ||
| qed_dbg_hsi.h | ||
| qed_dcbx.c | ||
| qed_dcbx.h | ||
| qed_debug.c | ||
| qed_debug.h | ||
| qed_dev_api.h | ||
| qed_dev.c | ||
| qed_devlink.c | ||
| qed_devlink.h | ||
| qed_fcoe.c | ||
| qed_fcoe.h | ||
| qed_hsi.h | ||
| qed_hw.c | ||
| qed_hw.h | ||
| qed_init_fw_funcs.c | ||
| qed_init_ops.c | ||
| qed_init_ops.h | ||
| qed_int.c | ||
| qed_int.h | ||
| qed_iro_hsi.h | ||
| qed_iscsi.c | ||
| qed_iscsi.h | ||
| qed_iwarp.c | ||
| qed_iwarp.h | ||
| qed_l2.c | ||
| qed_l2.h | ||
| qed_ll2.c | ||
| qed_ll2.h | ||
| qed_main.c | ||
| qed_mcp.c | ||
| qed_mcp.h | ||
| qed_mfw_hsi.h | ||
| qed_mng_tlv.c | ||
| qed_nvmetcp_fw_funcs.c | ||
| qed_nvmetcp_fw_funcs.h | ||
| qed_nvmetcp.c | ||
| qed_nvmetcp.h | ||
| qed_ooo.c | ||
| qed_ooo.h | ||
| qed_ptp.c | ||
| qed_ptp.h | ||
| qed_rdma.c | ||
| qed_rdma.h | ||
| qed_reg_addr.h | ||
| qed_roce.c | ||
| qed_roce.h | ||
| qed_selftest.c | ||
| qed_selftest.h | ||
| qed_sp_commands.c | ||
| qed_sp.h | ||
| qed_spq.c | ||
| qed_sriov.c | ||
| qed_sriov.h | ||
| qed_vf.c | ||
| qed_vf.h | ||
| qed.h | ||