torvalds/linux
torvalds/linux
2
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-04 20:19:47 +08:00
Code
410e302ea5
linux/drivers/net/can/usb
History
Pavel Skripkin 91c0255717 can: mcba_usb: fix memory leak in mcba_usb 
Syzbot reported memory leak in SocketCAN driver for Microchip CAN BUS
Analyzer Tool. The problem was in unfreed usb_coherent.

In mcba_usb_start() 20 coherent buffers are allocated and there is
nothing, that frees them:

1) In callback function the urb is resubmitted and that's all
2) In disconnect function urbs are simply killed, but URB_FREE_BUFFER
   is not set (see mcba_usb_start) and this flag cannot be used with
   coherent buffers.

Fail log:
| [ 1354.053291][ T8413] mcba_usb 1-1:0.0 can0: device disconnected
| [ 1367.059384][ T8420] kmemleak: 20 new suspected memory leaks (see /sys/kernel/debug/kmem)

So, all allocated buffers should be freed with usb_free_coherent()
explicitly

NOTE:
The same pattern for allocating and freeing coherent buffers
is used in drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c

Fixes: 51f3baad7d ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer")
Link: https://lore.kernel.org/r/20210609215833.30393-1-paskripkin@gmail.com
Cc: linux-stable <stable@vger.kernel.org>
Reported-and-tested-by: syzbot+57281c762a3922e14dfe@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
2021-06-16 12:52:18 +02:00
..
etas_es58x can: etas_es58x: Fix a couple of spelling mistakes 2021-04-24 14:36:50 +02:00
kvaser_usb can: dev: can_free_echo_skb(): extend to return can frame length 2021-03-30 11:14:28 +02:00
peak_usb can: peak_usb: pcan_usb: replace open coded endianness conversion of unaligned data 2021-04-13 10:15:44 +02:00
ems_usb.c can: dev: can_free_echo_skb(): extend to return can frame length 2021-03-30 11:14:28 +02:00
esd_usb2.c can: dev: can_free_echo_skb(): extend to return can frame length 2021-03-30 11:14:28 +02:00
gs_usb.c can: dev: can_free_echo_skb(): extend to return can frame length 2021-03-30 11:14:28 +02:00
Kconfig can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces 2021-04-13 10:15:42 +02:00
Makefile can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces 2021-04-13 10:15:42 +02:00
mcba_usb.c can: mcba_usb: fix memory leak in mcba_usb 2021-06-16 12:52:18 +02:00
ucan.c can: ucan: fix alignment constraints 2021-03-30 11:14:46 +02:00
usb_8dev.c can: dev: can_free_echo_skb(): extend to return can frame length 2021-03-30 11:14:28 +02:00