Files
linux/fs
Miklos Szeredi 2d84a2d19b fuse: fix possibly missed wake-up after abort
In current fuse_drop_waiting() implementation it's possible that
fuse_wait_aborted() will not be woken up in the unlikely case that
fuse_abort_conn() + fuse_wait_aborted() runs in between checking
fc->connected and calling atomic_dec(&fc->num_waiting).

Do the atomic_dec_and_test() unconditionally, which also provides the
necessary barrier against reordering with the fc->connected check.

The explicit smp_mb() in fuse_wait_aborted() is not actually needed, since
the spin_unlock() in fuse_abort_conn() provides the necessary RELEASE
barrier after resetting fc->connected.  However, this is not a performance
sensitive path, and adding the explicit barrier makes it easier to
document.

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: b8f95e5d13 ("fuse: umount should wait for all requests")
Cc: <stable@vger.kernel.org> #v4.19
2018-11-09 15:52:16 +01:00
..
2018-09-04 11:35:03 +08:00
2018-08-21 23:54:17 -04:00
2018-08-17 16:20:28 -07:00
2018-09-29 22:47:48 -04:00
2018-10-26 16:26:33 -07:00
2018-05-22 14:27:52 -04:00
2018-10-21 10:46:42 -04:00
2018-10-12 22:46:50 -04:00
2018-10-31 08:54:15 -07:00
2018-05-22 14:27:52 -04:00
2018-10-23 13:49:02 +02:00
2018-09-07 10:32:23 +02:00
2018-07-03 16:44:45 -04:00
2018-10-24 00:40:44 +01:00
2018-06-05 19:23:26 +02:00
2018-10-31 08:54:16 -07:00
2018-10-24 00:40:44 +01:00
2018-10-21 10:46:42 -04:00
2018-10-31 08:54:16 -07:00
2018-06-11 08:22:34 -07:00
2018-10-31 08:54:16 -07:00
2018-09-03 15:14:01 +02:00