mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-03-21 23:16:50 +08:00
gud_plane_atomic_update() currently handles both crtc state and framebuffer updates - the complexity has led to a few accidental NULL pointer dereferences. Commitdc2d5ddb19("drm/gud: fix NULL fb and crtc dereferences on USB disconnect") [1] fixed an earlier dereference but planes can also be disabled in non-hotplug paths (e.g. display disables via the desktop environment). The drm_dev_enter() call would not cause an early return in those and subsequently oops on dereferencing crtc: BUG: kernel NULL pointer dereference, address: 00000000000005c8 CPU: 6 UID: 1000 PID: 3473 Comm: kwin_wayland Not tainted 6.18.2-200.vanilla.gud.fc42.x86_64 #1 PREEMPT(lazy) RIP: 0010:gud_plane_atomic_update+0x148/0x470 [gud] <TASK> drm_atomic_helper_commit_planes+0x28e/0x310 drm_atomic_helper_commit_tail+0x2a/0x70 commit_tail+0xf1/0x150 drm_atomic_helper_commit+0x13c/0x180 drm_atomic_commit+0xb1/0xe0 info ? __pfx___drm_printfn_info+0x10/0x10 drm_mode_atomic_ioctl+0x70f/0x7c0 ? __pfx_drm_mode_atomic_ioctl+0x10/0x10 drm_ioctl_kernel+0xae/0x100 drm_ioctl+0x2a8/0x550 ? __pfx_drm_mode_atomic_ioctl+0x10/0x10 __x64_sys_ioctl+0x97/0xe0 do_syscall_64+0x7e/0x7f0 ? __ct_user_enter+0x56/0xd0 ? do_syscall_64+0x158/0x7f0 ? __ct_user_enter+0x56/0xd0 ? do_syscall_64+0x158/0x7f0 entry_SYSCALL_64_after_hwframe+0x76/0x7e Split out crtc handling from gud_plane_atomic_update() into atomic_enable() and atomic_disable() functions to delegate crtc state transitioning work to the DRM helpers. To preserve the gud state commit sequence [2], switch to the runtime PM version of drm_atomic_helper_commit_tail() which ensures that crtcs are enabled (hence sending the GUD_REQ_SET_CONTROLLER_ENABLE and GUD_REQ_SET_DISPLAY_ENABLE requests) before a framebuffer update is sent. [1] https://lore.kernel.org/all/20251231055039.44266-1-me@shenghaoyang.info/ [2] https://github.com/notro/gud/wiki/GUD-Protocol#display-state Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/r/202601142159.0v8ilfVs-lkp@intel.com/ Fixes:73cfd166e0("drm/gud: Replace simple display pipe with DRM atomic helpers") Cc: <stable@vger.kernel.org> # 6.19.x Cc: <stable@vger.kernel.org> # 6.18.x Signed-off-by: Shenghao Yang <me@shenghaoyang.info> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Ruben Wauters <rubenru09@aol.com> Signed-off-by: Ruben Wauters <rubenru09@aol.com> Link: https://patch.msgid.link/20260222054551.80864-1-me@shenghaoyang.info
659 lines
17 KiB
C
659 lines
17 KiB
C
// SPDX-License-Identifier: MIT
|
|
/*
|
|
* Copyright 2020 Noralf Trønnes
|
|
*/
|
|
|
|
#include <linux/lz4.h>
|
|
#include <linux/usb.h>
|
|
#include <linux/vmalloc.h>
|
|
#include <linux/workqueue.h>
|
|
|
|
#include <drm/drm_atomic.h>
|
|
#include <drm/drm_connector.h>
|
|
#include <drm/drm_damage_helper.h>
|
|
#include <drm/drm_drv.h>
|
|
#include <drm/drm_format_helper.h>
|
|
#include <drm/drm_fourcc.h>
|
|
#include <drm/drm_framebuffer.h>
|
|
#include <drm/drm_gem.h>
|
|
#include <drm/drm_gem_atomic_helper.h>
|
|
#include <drm/drm_gem_framebuffer_helper.h>
|
|
#include <drm/drm_print.h>
|
|
#include <drm/drm_rect.h>
|
|
#include <drm/gud.h>
|
|
|
|
#include "gud_internal.h"
|
|
|
|
/*
|
|
* Some userspace rendering loops run all displays in the same loop.
|
|
* This means that a fast display will have to wait for a slow one.
|
|
* Such users might want to enable this module parameter.
|
|
*/
|
|
static bool gud_async_flush;
|
|
module_param_named(async_flush, gud_async_flush, bool, 0644);
|
|
MODULE_PARM_DESC(async_flush, "Enable asynchronous flushing [default=0]");
|
|
|
|
/*
|
|
* FIXME: The driver is probably broken on Big Endian machines.
|
|
* See discussion:
|
|
* https://lore.kernel.org/dri-devel/CAKb7UvihLX0hgBOP3VBG7O+atwZcUVCPVuBdfmDMpg0NjXe-cQ@mail.gmail.com/
|
|
*/
|
|
|
|
static bool gud_is_big_endian(void)
|
|
{
|
|
#if defined(__BIG_ENDIAN)
|
|
return true;
|
|
#else
|
|
return false;
|
|
#endif
|
|
}
|
|
|
|
static size_t gud_xrgb8888_to_r124(u8 *dst, const struct drm_format_info *format,
|
|
void *src, struct drm_framebuffer *fb,
|
|
struct drm_rect *rect,
|
|
struct drm_format_conv_state *fmtcnv_state)
|
|
{
|
|
unsigned int block_width = drm_format_info_block_width(format, 0);
|
|
unsigned int bits_per_pixel = 8 / block_width;
|
|
unsigned int x, y, width, height;
|
|
u8 pix, *pix8, *block = dst; /* Assign to silence compiler warning */
|
|
struct iosys_map dst_map, vmap;
|
|
size_t len;
|
|
void *buf;
|
|
|
|
drm_WARN_ON_ONCE(fb->dev, format->char_per_block[0] != 1);
|
|
|
|
/* Start on a byte boundary */
|
|
rect->x1 = ALIGN_DOWN(rect->x1, block_width);
|
|
width = drm_rect_width(rect);
|
|
height = drm_rect_height(rect);
|
|
len = drm_format_info_min_pitch(format, 0, width) * height;
|
|
|
|
buf = kmalloc_array(height, width, GFP_KERNEL);
|
|
if (!buf)
|
|
return 0;
|
|
|
|
iosys_map_set_vaddr(&dst_map, buf);
|
|
iosys_map_set_vaddr(&vmap, src);
|
|
drm_fb_xrgb8888_to_gray8(&dst_map, NULL, &vmap, fb, rect, fmtcnv_state);
|
|
pix8 = buf;
|
|
|
|
for (y = 0; y < height; y++) {
|
|
for (x = 0; x < width; x++) {
|
|
unsigned int pixpos = x % block_width; /* within byte from the left */
|
|
unsigned int pixshift = (block_width - pixpos - 1) * bits_per_pixel;
|
|
|
|
if (!pixpos) {
|
|
block = dst++;
|
|
*block = 0;
|
|
}
|
|
|
|
pix = (*pix8++) >> (8 - bits_per_pixel);
|
|
*block |= pix << pixshift;
|
|
}
|
|
}
|
|
|
|
kfree(buf);
|
|
|
|
return len;
|
|
}
|
|
|
|
static size_t gud_xrgb8888_to_color(u8 *dst, const struct drm_format_info *format,
|
|
void *src, struct drm_framebuffer *fb,
|
|
struct drm_rect *rect)
|
|
{
|
|
unsigned int block_width = drm_format_info_block_width(format, 0);
|
|
unsigned int bits_per_pixel = 8 / block_width;
|
|
u8 r, g, b, pix, *block = dst; /* Assign to silence compiler warning */
|
|
unsigned int x, y, width;
|
|
__le32 *sbuf32;
|
|
u32 pix32;
|
|
size_t len;
|
|
|
|
/* Start on a byte boundary */
|
|
rect->x1 = ALIGN_DOWN(rect->x1, block_width);
|
|
width = drm_rect_width(rect);
|
|
len = drm_format_info_min_pitch(format, 0, width) * drm_rect_height(rect);
|
|
|
|
for (y = rect->y1; y < rect->y2; y++) {
|
|
sbuf32 = src + (y * fb->pitches[0]);
|
|
sbuf32 += rect->x1;
|
|
|
|
for (x = 0; x < width; x++) {
|
|
unsigned int pixpos = x % block_width; /* within byte from the left */
|
|
unsigned int pixshift = (block_width - pixpos - 1) * bits_per_pixel;
|
|
|
|
if (!pixpos) {
|
|
block = dst++;
|
|
*block = 0;
|
|
}
|
|
|
|
pix32 = le32_to_cpu(*sbuf32++);
|
|
r = pix32 >> 16;
|
|
g = pix32 >> 8;
|
|
b = pix32;
|
|
|
|
switch (format->format) {
|
|
case GUD_DRM_FORMAT_XRGB1111:
|
|
pix = ((r >> 7) << 2) | ((g >> 7) << 1) | (b >> 7);
|
|
break;
|
|
default:
|
|
drm_WARN_ON_ONCE(fb->dev, 1);
|
|
return len;
|
|
}
|
|
|
|
*block |= pix << pixshift;
|
|
}
|
|
}
|
|
|
|
return len;
|
|
}
|
|
|
|
static int gud_prep_flush(struct gud_device *gdrm, struct drm_framebuffer *fb,
|
|
const struct iosys_map *src, bool cached_reads,
|
|
const struct drm_format_info *format, struct drm_rect *rect,
|
|
struct gud_set_buffer_req *req,
|
|
struct drm_format_conv_state *fmtcnv_state)
|
|
{
|
|
u8 compression = gdrm->compression;
|
|
struct iosys_map dst;
|
|
void *vaddr, *buf;
|
|
size_t pitch, len;
|
|
|
|
pitch = drm_format_info_min_pitch(format, 0, drm_rect_width(rect));
|
|
len = pitch * drm_rect_height(rect);
|
|
if (len > gdrm->bulk_len)
|
|
return -E2BIG;
|
|
|
|
vaddr = src[0].vaddr;
|
|
retry:
|
|
if (compression)
|
|
buf = gdrm->compress_buf;
|
|
else
|
|
buf = gdrm->bulk_buf;
|
|
iosys_map_set_vaddr(&dst, buf);
|
|
|
|
/*
|
|
* Imported buffers are assumed to be write-combined and thus uncached
|
|
* with slow reads (at least on ARM).
|
|
*/
|
|
if (format != fb->format) {
|
|
if (format->format == GUD_DRM_FORMAT_R1) {
|
|
len = gud_xrgb8888_to_r124(buf, format, vaddr, fb, rect, fmtcnv_state);
|
|
if (!len)
|
|
return -ENOMEM;
|
|
} else if (format->format == DRM_FORMAT_R8) {
|
|
drm_fb_xrgb8888_to_gray8(&dst, NULL, src, fb, rect, fmtcnv_state);
|
|
} else if (format->format == DRM_FORMAT_RGB332) {
|
|
drm_fb_xrgb8888_to_rgb332(&dst, NULL, src, fb, rect, fmtcnv_state);
|
|
} else if (format->format == DRM_FORMAT_RGB565) {
|
|
if (gud_is_big_endian()) {
|
|
drm_fb_xrgb8888_to_rgb565be(&dst, NULL, src, fb, rect,
|
|
fmtcnv_state);
|
|
} else {
|
|
drm_fb_xrgb8888_to_rgb565(&dst, NULL, src, fb, rect,
|
|
fmtcnv_state);
|
|
}
|
|
} else if (format->format == DRM_FORMAT_RGB888) {
|
|
drm_fb_xrgb8888_to_rgb888(&dst, NULL, src, fb, rect, fmtcnv_state);
|
|
} else {
|
|
len = gud_xrgb8888_to_color(buf, format, vaddr, fb, rect);
|
|
}
|
|
} else if (gud_is_big_endian() && format->cpp[0] > 1) {
|
|
drm_fb_swab(&dst, NULL, src, fb, rect, cached_reads, fmtcnv_state);
|
|
} else if (compression && cached_reads && pitch == fb->pitches[0]) {
|
|
/* can compress directly from the framebuffer */
|
|
buf = vaddr + rect->y1 * pitch;
|
|
} else {
|
|
drm_fb_memcpy(&dst, NULL, src, fb, rect);
|
|
}
|
|
|
|
memset(req, 0, sizeof(*req));
|
|
req->x = cpu_to_le32(rect->x1);
|
|
req->y = cpu_to_le32(rect->y1);
|
|
req->width = cpu_to_le32(drm_rect_width(rect));
|
|
req->height = cpu_to_le32(drm_rect_height(rect));
|
|
req->length = cpu_to_le32(len);
|
|
|
|
if (compression & GUD_COMPRESSION_LZ4) {
|
|
int complen;
|
|
|
|
complen = LZ4_compress_default(buf, gdrm->bulk_buf, len, len, gdrm->lz4_comp_mem);
|
|
if (complen <= 0) {
|
|
compression = 0;
|
|
goto retry;
|
|
}
|
|
|
|
req->compression = GUD_COMPRESSION_LZ4;
|
|
req->compressed_length = cpu_to_le32(complen);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
struct gud_usb_bulk_context {
|
|
struct timer_list timer;
|
|
struct usb_sg_request sgr;
|
|
};
|
|
|
|
static void gud_usb_bulk_timeout(struct timer_list *t)
|
|
{
|
|
struct gud_usb_bulk_context *ctx = timer_container_of(ctx, t, timer);
|
|
|
|
usb_sg_cancel(&ctx->sgr);
|
|
}
|
|
|
|
static int gud_usb_bulk(struct gud_device *gdrm, size_t len)
|
|
{
|
|
struct gud_usb_bulk_context ctx;
|
|
int ret;
|
|
|
|
ret = usb_sg_init(&ctx.sgr, gud_to_usb_device(gdrm), gdrm->bulk_pipe, 0,
|
|
gdrm->bulk_sgt.sgl, gdrm->bulk_sgt.nents, len, GFP_KERNEL);
|
|
if (ret)
|
|
return ret;
|
|
|
|
timer_setup_on_stack(&ctx.timer, gud_usb_bulk_timeout, 0);
|
|
mod_timer(&ctx.timer, jiffies + msecs_to_jiffies(3000));
|
|
|
|
usb_sg_wait(&ctx.sgr);
|
|
|
|
if (!timer_delete_sync(&ctx.timer))
|
|
ret = -ETIMEDOUT;
|
|
else if (ctx.sgr.status < 0)
|
|
ret = ctx.sgr.status;
|
|
else if (ctx.sgr.bytes != len)
|
|
ret = -EIO;
|
|
|
|
timer_destroy_on_stack(&ctx.timer);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int gud_flush_rect(struct gud_device *gdrm, struct drm_framebuffer *fb,
|
|
const struct iosys_map *src, bool cached_reads,
|
|
const struct drm_format_info *format, struct drm_rect *rect,
|
|
struct drm_format_conv_state *fmtcnv_state)
|
|
{
|
|
struct gud_set_buffer_req req;
|
|
size_t len, trlen;
|
|
int ret;
|
|
|
|
drm_dbg(&gdrm->drm, "Flushing [FB:%d] " DRM_RECT_FMT "\n", fb->base.id, DRM_RECT_ARG(rect));
|
|
|
|
ret = gud_prep_flush(gdrm, fb, src, cached_reads, format, rect, &req, fmtcnv_state);
|
|
if (ret)
|
|
return ret;
|
|
|
|
len = le32_to_cpu(req.length);
|
|
|
|
if (req.compression)
|
|
trlen = le32_to_cpu(req.compressed_length);
|
|
else
|
|
trlen = len;
|
|
|
|
gdrm->stats_length += len;
|
|
/* Did it wrap around? */
|
|
if (gdrm->stats_length <= len && gdrm->stats_actual_length) {
|
|
gdrm->stats_length = len;
|
|
gdrm->stats_actual_length = 0;
|
|
}
|
|
gdrm->stats_actual_length += trlen;
|
|
|
|
if (!(gdrm->flags & GUD_DISPLAY_FLAG_FULL_UPDATE) || gdrm->prev_flush_failed) {
|
|
ret = gud_usb_set(gdrm, GUD_REQ_SET_BUFFER, 0, &req, sizeof(req));
|
|
if (ret)
|
|
return ret;
|
|
}
|
|
|
|
ret = gud_usb_bulk(gdrm, trlen);
|
|
if (ret)
|
|
gdrm->stats_num_errors++;
|
|
|
|
return ret;
|
|
}
|
|
|
|
void gud_clear_damage(struct gud_device *gdrm)
|
|
{
|
|
gdrm->damage.x1 = INT_MAX;
|
|
gdrm->damage.y1 = INT_MAX;
|
|
gdrm->damage.x2 = 0;
|
|
gdrm->damage.y2 = 0;
|
|
}
|
|
|
|
static void gud_flush_damage(struct gud_device *gdrm, struct drm_framebuffer *fb,
|
|
const struct iosys_map *src, bool cached_reads,
|
|
struct drm_rect *damage)
|
|
{
|
|
struct drm_format_conv_state fmtcnv_state = DRM_FORMAT_CONV_STATE_INIT;
|
|
const struct drm_format_info *format;
|
|
unsigned int i, lines;
|
|
size_t pitch;
|
|
int ret;
|
|
|
|
format = fb->format;
|
|
if (format->format == DRM_FORMAT_XRGB8888 && gdrm->xrgb8888_emulation_format)
|
|
format = gdrm->xrgb8888_emulation_format;
|
|
|
|
/* Split update if it's too big */
|
|
pitch = drm_format_info_min_pitch(format, 0, drm_rect_width(damage));
|
|
lines = drm_rect_height(damage);
|
|
|
|
if (gdrm->bulk_len < lines * pitch)
|
|
lines = gdrm->bulk_len / pitch;
|
|
|
|
for (i = 0; i < DIV_ROUND_UP(drm_rect_height(damage), lines); i++) {
|
|
struct drm_rect rect = *damage;
|
|
|
|
rect.y1 += i * lines;
|
|
rect.y2 = min_t(u32, rect.y1 + lines, damage->y2);
|
|
|
|
ret = gud_flush_rect(gdrm, fb, src, cached_reads, format, &rect, &fmtcnv_state);
|
|
if (ret) {
|
|
if (ret != -ENODEV && ret != -ECONNRESET &&
|
|
ret != -ESHUTDOWN && ret != -EPROTO)
|
|
dev_err_ratelimited(fb->dev->dev,
|
|
"Failed to flush framebuffer: error=%d\n", ret);
|
|
gdrm->prev_flush_failed = true;
|
|
break;
|
|
}
|
|
}
|
|
|
|
drm_format_conv_state_release(&fmtcnv_state);
|
|
}
|
|
|
|
void gud_flush_work(struct work_struct *work)
|
|
{
|
|
struct gud_device *gdrm = container_of(work, struct gud_device, work);
|
|
struct iosys_map shadow_map;
|
|
struct drm_framebuffer *fb;
|
|
struct drm_rect damage;
|
|
int idx;
|
|
|
|
if (!drm_dev_enter(&gdrm->drm, &idx))
|
|
return;
|
|
|
|
mutex_lock(&gdrm->damage_lock);
|
|
fb = gdrm->fb;
|
|
gdrm->fb = NULL;
|
|
iosys_map_set_vaddr(&shadow_map, gdrm->shadow_buf);
|
|
damage = gdrm->damage;
|
|
gud_clear_damage(gdrm);
|
|
mutex_unlock(&gdrm->damage_lock);
|
|
|
|
if (!fb)
|
|
goto out;
|
|
|
|
gud_flush_damage(gdrm, fb, &shadow_map, true, &damage);
|
|
|
|
drm_framebuffer_put(fb);
|
|
out:
|
|
drm_dev_exit(idx);
|
|
}
|
|
|
|
static int gud_fb_queue_damage(struct gud_device *gdrm, struct drm_framebuffer *fb,
|
|
const struct iosys_map *src, struct drm_rect *damage)
|
|
{
|
|
struct drm_framebuffer *old_fb = NULL;
|
|
struct iosys_map shadow_map;
|
|
|
|
mutex_lock(&gdrm->damage_lock);
|
|
|
|
if (!gdrm->shadow_buf) {
|
|
gdrm->shadow_buf = vcalloc(fb->pitches[0], fb->height);
|
|
if (!gdrm->shadow_buf) {
|
|
mutex_unlock(&gdrm->damage_lock);
|
|
return -ENOMEM;
|
|
}
|
|
}
|
|
|
|
iosys_map_set_vaddr(&shadow_map, gdrm->shadow_buf);
|
|
iosys_map_incr(&shadow_map, drm_fb_clip_offset(fb->pitches[0], fb->format, damage));
|
|
drm_fb_memcpy(&shadow_map, fb->pitches, src, fb, damage);
|
|
|
|
if (fb != gdrm->fb) {
|
|
old_fb = gdrm->fb;
|
|
drm_framebuffer_get(fb);
|
|
gdrm->fb = fb;
|
|
}
|
|
|
|
gdrm->damage.x1 = min(gdrm->damage.x1, damage->x1);
|
|
gdrm->damage.y1 = min(gdrm->damage.y1, damage->y1);
|
|
gdrm->damage.x2 = max(gdrm->damage.x2, damage->x2);
|
|
gdrm->damage.y2 = max(gdrm->damage.y2, damage->y2);
|
|
|
|
mutex_unlock(&gdrm->damage_lock);
|
|
|
|
queue_work(system_long_wq, &gdrm->work);
|
|
|
|
if (old_fb)
|
|
drm_framebuffer_put(old_fb);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void gud_fb_handle_damage(struct gud_device *gdrm, struct drm_framebuffer *fb,
|
|
const struct iosys_map *src, struct drm_rect *damage)
|
|
{
|
|
int ret;
|
|
|
|
if (gdrm->flags & GUD_DISPLAY_FLAG_FULL_UPDATE)
|
|
drm_rect_init(damage, 0, 0, fb->width, fb->height);
|
|
|
|
if (gud_async_flush) {
|
|
ret = gud_fb_queue_damage(gdrm, fb, src, damage);
|
|
if (ret != -ENOMEM)
|
|
return;
|
|
}
|
|
|
|
/* Imported buffers are assumed to be WriteCombined with uncached reads */
|
|
gud_flush_damage(gdrm, fb, src, !fb->obj[0]->import_attach, damage);
|
|
}
|
|
|
|
int gud_plane_atomic_check(struct drm_plane *plane,
|
|
struct drm_atomic_state *state)
|
|
{
|
|
struct gud_device *gdrm = to_gud_device(plane->dev);
|
|
struct drm_plane_state *old_plane_state = drm_atomic_get_old_plane_state(state, plane);
|
|
struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state, plane);
|
|
struct drm_crtc *crtc = new_plane_state->crtc;
|
|
struct drm_crtc_state *crtc_state = NULL;
|
|
const struct drm_display_mode *mode;
|
|
struct drm_framebuffer *old_fb = old_plane_state->fb;
|
|
struct drm_connector_state *connector_state = NULL;
|
|
struct drm_framebuffer *fb = new_plane_state->fb;
|
|
const struct drm_format_info *format;
|
|
struct drm_connector *connector;
|
|
unsigned int i, num_properties;
|
|
struct gud_state_req *req;
|
|
int idx, ret;
|
|
size_t len;
|
|
|
|
if (crtc)
|
|
crtc_state = drm_atomic_get_new_crtc_state(state, crtc);
|
|
|
|
ret = drm_atomic_helper_check_plane_state(new_plane_state, crtc_state,
|
|
DRM_PLANE_NO_SCALING,
|
|
DRM_PLANE_NO_SCALING,
|
|
false, false);
|
|
if (ret)
|
|
return ret;
|
|
|
|
if (!new_plane_state->visible)
|
|
return 0;
|
|
|
|
if (old_plane_state->rotation != new_plane_state->rotation)
|
|
crtc_state->mode_changed = true;
|
|
|
|
mode = &crtc_state->mode;
|
|
format = fb->format;
|
|
|
|
if (old_fb && old_fb->format != format)
|
|
crtc_state->mode_changed = true;
|
|
|
|
if (!crtc_state->mode_changed && !crtc_state->connectors_changed)
|
|
return 0;
|
|
|
|
/* Only one connector is supported */
|
|
if (hweight32(crtc_state->connector_mask) != 1)
|
|
return -EINVAL;
|
|
|
|
if (format->format == DRM_FORMAT_XRGB8888 && gdrm->xrgb8888_emulation_format)
|
|
format = gdrm->xrgb8888_emulation_format;
|
|
|
|
for_each_new_connector_in_state(state, connector, connector_state, i) {
|
|
if (connector_state->crtc)
|
|
break;
|
|
}
|
|
|
|
/*
|
|
* DRM_IOCTL_MODE_OBJ_SETPROPERTY on the rotation property will not have
|
|
* the connector included in the state.
|
|
*/
|
|
if (!connector_state) {
|
|
struct drm_connector_list_iter conn_iter;
|
|
|
|
drm_connector_list_iter_begin(plane->dev, &conn_iter);
|
|
drm_for_each_connector_iter(connector, &conn_iter) {
|
|
if (connector->state->crtc) {
|
|
connector_state = connector->state;
|
|
break;
|
|
}
|
|
}
|
|
drm_connector_list_iter_end(&conn_iter);
|
|
}
|
|
|
|
if (drm_WARN_ON_ONCE(plane->dev, !connector_state))
|
|
return -ENOENT;
|
|
|
|
len = struct_size(req, properties,
|
|
size_add(GUD_PROPERTIES_MAX_NUM, GUD_CONNECTOR_PROPERTIES_MAX_NUM));
|
|
req = kzalloc(len, GFP_KERNEL);
|
|
if (!req)
|
|
return -ENOMEM;
|
|
|
|
gud_from_display_mode(&req->mode, mode);
|
|
|
|
req->format = gud_from_fourcc(format->format);
|
|
if (drm_WARN_ON_ONCE(plane->dev, !req->format)) {
|
|
ret = -EINVAL;
|
|
goto out;
|
|
}
|
|
|
|
req->connector = drm_connector_index(connector_state->connector);
|
|
|
|
ret = gud_connector_fill_properties(connector_state, req->properties);
|
|
if (ret < 0)
|
|
goto out;
|
|
|
|
num_properties = ret;
|
|
for (i = 0; i < gdrm->num_properties; i++) {
|
|
u16 prop = gdrm->properties[i];
|
|
u64 val;
|
|
|
|
switch (prop) {
|
|
case GUD_PROPERTY_ROTATION:
|
|
/* DRM UAPI matches the protocol so use value directly */
|
|
val = new_plane_state->rotation;
|
|
break;
|
|
default:
|
|
drm_WARN_ON_ONCE(plane->dev, 1);
|
|
ret = -EINVAL;
|
|
goto out;
|
|
}
|
|
|
|
req->properties[num_properties + i].prop = cpu_to_le16(prop);
|
|
req->properties[num_properties + i].val = cpu_to_le64(val);
|
|
num_properties++;
|
|
}
|
|
|
|
if (drm_dev_enter(fb->dev, &idx)) {
|
|
len = struct_size(req, properties, num_properties);
|
|
ret = gud_usb_set(gdrm, GUD_REQ_SET_STATE_CHECK, 0, req, len);
|
|
drm_dev_exit(idx);
|
|
} else {
|
|
ret = -ENODEV;
|
|
}
|
|
out:
|
|
kfree(req);
|
|
|
|
return ret;
|
|
}
|
|
|
|
void gud_crtc_atomic_enable(struct drm_crtc *crtc,
|
|
struct drm_atomic_state *state)
|
|
{
|
|
struct drm_device *drm = crtc->dev;
|
|
struct gud_device *gdrm = to_gud_device(drm);
|
|
int idx;
|
|
|
|
if (!drm_dev_enter(drm, &idx))
|
|
return;
|
|
|
|
gud_usb_set_u8(gdrm, GUD_REQ_SET_CONTROLLER_ENABLE, 1);
|
|
gud_usb_set(gdrm, GUD_REQ_SET_STATE_COMMIT, 0, NULL, 0);
|
|
gud_usb_set_u8(gdrm, GUD_REQ_SET_DISPLAY_ENABLE, 1);
|
|
|
|
drm_dev_exit(idx);
|
|
}
|
|
|
|
void gud_crtc_atomic_disable(struct drm_crtc *crtc,
|
|
struct drm_atomic_state *state)
|
|
{
|
|
struct drm_device *drm = crtc->dev;
|
|
struct gud_device *gdrm = to_gud_device(drm);
|
|
int idx;
|
|
|
|
if (!drm_dev_enter(drm, &idx))
|
|
return;
|
|
|
|
gud_usb_set_u8(gdrm, GUD_REQ_SET_DISPLAY_ENABLE, 0);
|
|
gud_usb_set_u8(gdrm, GUD_REQ_SET_CONTROLLER_ENABLE, 0);
|
|
|
|
drm_dev_exit(idx);
|
|
}
|
|
|
|
void gud_plane_atomic_update(struct drm_plane *plane,
|
|
struct drm_atomic_state *atomic_state)
|
|
{
|
|
struct drm_device *drm = plane->dev;
|
|
struct gud_device *gdrm = to_gud_device(drm);
|
|
struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(atomic_state, plane);
|
|
struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(atomic_state, plane);
|
|
struct drm_shadow_plane_state *shadow_plane_state = to_drm_shadow_plane_state(new_state);
|
|
struct drm_framebuffer *fb = new_state->fb;
|
|
struct drm_crtc *crtc = new_state->crtc;
|
|
struct drm_rect damage;
|
|
struct drm_atomic_helper_damage_iter iter;
|
|
int ret, idx;
|
|
|
|
if (!crtc || crtc->state->mode_changed || !crtc->state->enable) {
|
|
cancel_work_sync(&gdrm->work);
|
|
mutex_lock(&gdrm->damage_lock);
|
|
if (gdrm->fb) {
|
|
drm_framebuffer_put(gdrm->fb);
|
|
gdrm->fb = NULL;
|
|
}
|
|
gud_clear_damage(gdrm);
|
|
vfree(gdrm->shadow_buf);
|
|
gdrm->shadow_buf = NULL;
|
|
mutex_unlock(&gdrm->damage_lock);
|
|
}
|
|
|
|
if (!crtc || !drm_dev_enter(drm, &idx))
|
|
return;
|
|
|
|
ret = drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE);
|
|
if (ret)
|
|
goto out;
|
|
|
|
drm_atomic_helper_damage_iter_init(&iter, old_state, new_state);
|
|
drm_atomic_for_each_plane_damage(&iter, &damage)
|
|
gud_fb_handle_damage(gdrm, fb, &shadow_plane_state->data[0], &damage);
|
|
|
|
drm_gem_fb_end_cpu_access(fb, DMA_FROM_DEVICE);
|
|
|
|
out:
|
|
drm_dev_exit(idx);
|
|
}
|