2
0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-04 20:19:47 +08:00
linux/drivers/media/platform/nxp/imx-jpeg
Dan Carpenter 1378ffec30 media: imx-jpeg: Fix potential error pointer dereference in detach_pm()
The proble is on the first line:

	if (jpeg->pd_dev[i] && !pm_runtime_suspended(jpeg->pd_dev[i]))

If jpeg->pd_dev[i] is an error pointer, then passing it to
pm_runtime_suspended() will lead to an Oops.  The other conditions
check for both error pointers and NULL, but it would be more clear to
use the IS_ERR_OR_NULL() check for that.

Fixes: fd0af4cd35 ("media: imx-jpeg: Ensure power suppliers be suspended before detach them")
Cc: <stable@vger.kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Ming Qian <ming.qian@nxp.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
2024-12-02 14:05:22 +01:00
..
Kconfig media: Kconfig: cleanup VIDEO_DEV dependencies 2022-03-18 05:58:35 +01:00
Makefile
mxc-jpeg-hw.c media: imx-jpeg: Encoder add support for 12bit jpeg 2023-04-15 09:14:58 +01:00
mxc-jpeg-hw.h media: imx-jpeg: Remove unused declarations 2023-09-27 09:40:01 +02:00
mxc-jpeg.c media: imx-jpeg: Fix potential error pointer dereference in detach_pm() 2024-12-02 14:05:22 +01:00
mxc-jpeg.h media: imx-jpeg: Support for negotiating bytesperline with client 2024-02-16 11:46:32 +01:00