mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-04 20:19:47 +08:00
![]() As stated in [1], dma_set_mask() with a 64-bit mask will never fail if dev->dma_mask is non-NULL. So, if it fails, the 32 bits case will also fail for the same reason. So qlcnic_set_dma_mask(), (in qlcnic_main.c) can be simplified a lot and inlined directly in its only caller. If dma_set_mask_and_coherent() succeeds, 'pci_using_dac' is known to be 1. So it can be removed from all the calling chain. qlcnic_setup_netdev() can finally be simplified as-well. [1]: https://lkml.org/lkml/2021/6/7/398 Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/4996ab0337d62ec6a54b2edf234cd5ced4b4d7ad.1641649611.git.christophe.jaillet@wanadoo.fr Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
||
---|---|---|
.. | ||
Makefile | ||
qlcnic_83xx_hw.c | ||
qlcnic_83xx_hw.h | ||
qlcnic_83xx_init.c | ||
qlcnic_83xx_vnic.c | ||
qlcnic_ctx.c | ||
qlcnic_dcb.c | ||
qlcnic_dcb.h | ||
qlcnic_ethtool.c | ||
qlcnic_hdr.h | ||
qlcnic_hw.c | ||
qlcnic_hw.h | ||
qlcnic_init.c | ||
qlcnic_io.c | ||
qlcnic_main.c | ||
qlcnic_minidump.c | ||
qlcnic_sriov_common.c | ||
qlcnic_sriov_pf.c | ||
qlcnic_sriov.h | ||
qlcnic_sysfs.c | ||
qlcnic.h |