torvalds/linux
torvalds/linux
2
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-04 20:19:47 +08:00
Code

locking/rwsem: Use OWNER_NONSPINNABLE directly instead of OWNER_SPINNABLE

Browse Source 
After commit 7d43f1ce9d ("locking/rwsem: Enable time-based spinning on
reader-owned rwsem"), OWNER_SPINNABLE contains all possible values except
OWNER_NONSPINNABLE, namely OWNER_NULL | OWNER_WRITER | OWNER_READER.

Therefore, it is better to use OWNER_NONSPINNABLE directly to determine
whether to exit optimistic spin.

And, remove useless OWNER_SPINNABLE to simplify the code.

Signed-off-by: Jinliang Zheng <alexjlzheng@tencent.com>
Acked-by: Waiman Long <longman@redhat.com>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20250610130158.4876-1-alexjlzheng@tencent.com
This commit is contained in:
Jinliang Zheng 2025-06-10 21:01:58 +08:00 committed by Boqun Feng
parent 99214efede
commit f84a15b90d
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/locking/rwsem.c
View File

@ -727,8 +727,6 @@ static inline bool rwsem_can_spin_on_owner(struct rw_semaphore *sem)
return ret; return ret;
} }
#define OWNER_SPINNABLE (OWNER_NULL | OWNER_WRITER | OWNER_READER)
static inline enum owner_state static inline enum owner_state
rwsem_owner_state(struct task_struct *owner, unsigned long flags) rwsem_owner_state(struct task_struct *owner, unsigned long flags)
{ {
@ -835,7 +833,7 @@ static bool rwsem_optimistic_spin(struct rw_semaphore *sem)
enum owner_state owner_state; enum owner_state owner_state;
owner_state = rwsem_spin_on_owner(sem); owner_state = rwsem_spin_on_owner(sem);
if (!(owner_state & OWNER_SPINNABLE)) if (owner_state == OWNER_NONSPINNABLE)
break; break;
/* /*