torvalds/linux
torvalds/linux
2
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-04 20:19:47 +08:00
Code

cpuidle: riscv-sbi: Drop redundant sync_state support

Browse Source 
The recent updates to the genpd core, can entirely manage the sync_state
support for the cpuidle-riscv-sbi-domain. More precisely, genpd prevents
our ->power_off() callback from being invoked, until all of our consumers
are ready for it.

Let's therefore drop the sync_state support for the
cpuidle-riscv-sbi-domain as it has become redundant.

Cc: Anup Patel <anup@brainfault.org>
Cc: linux-riscv@lists.infradead.org
Tested-by: Hiago De Franco <hiago.franco@toradex.com> # Colibri iMX8X
Tested-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> # TI AM62A,Xilinx ZynqMP ZCU106
Reviewed-by: Rahul Pathak <rpathak@ventanamicro.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Link: https://lore.kernel.org/r/20250701114733.636510-25-ulf.hansson@linaro.org
This commit is contained in:
Ulf Hansson 2025-07-01 13:47:26 +02:00
parent 039d2b0a1b
commit eb34a0b5fe
1 changed files with 1 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/cpuidle/cpuidle-riscv-sbi.c
View File

@ -44,7 +44,6 @@ static DEFINE_PER_CPU_READ_MOSTLY(struct sbi_cpuidle_data, sbi_cpuidle_data);
static DEFINE_PER_CPU(struct sbi_domain_state, domain_state); static DEFINE_PER_CPU(struct sbi_domain_state, domain_state);
static bool sbi_cpuidle_use_osi; static bool sbi_cpuidle_use_osi;
static bool sbi_cpuidle_use_cpuhp; static bool sbi_cpuidle_use_cpuhp;
static bool sbi_cpuidle_pd_allow_domain_state;
static inline void sbi_set_domain_state(u32 state) static inline void sbi_set_domain_state(u32 state)
{ {
@ -345,20 +344,6 @@ deinit:
return ret; return ret;
} }
static void sbi_cpuidle_domain_sync_state(struct device *dev)
{
struct sbi_pd_provider *pd_provider;
/*
* All devices have now been attached/probed to the PM domain
* topology, hence it's fine to allow domain states to be picked.
*/
sbi_cpuidle_pd_allow_domain_state = true;
list_for_each_entry(pd_provider, &sbi_pd_providers, link)
of_genpd_sync_state(pd_provider->node);
}
#ifdef CONFIG_DT_IDLE_GENPD #ifdef CONFIG_DT_IDLE_GENPD
static int sbi_cpuidle_pd_power_off(struct generic_pm_domain *pd) static int sbi_cpuidle_pd_power_off(struct generic_pm_domain *pd)
@ -369,9 +354,6 @@ static int sbi_cpuidle_pd_power_off(struct generic_pm_domain *pd)
if (!state->data) if (!state->data)
return 0; return 0;
if (!sbi_cpuidle_pd_allow_domain_state)
return -EBUSY;
/* OSI mode is enabled, set the corresponding domain state. */ /* OSI mode is enabled, set the corresponding domain state. */
pd_state = state->data; pd_state = state->data;
sbi_set_domain_state(*pd_state); sbi_set_domain_state(*pd_state);
@ -401,8 +383,7 @@ static int sbi_pd_init(struct device_node *np)
if (!pd_provider) if (!pd_provider)
goto free_pd; goto free_pd;
pd->flags |= GENPD_FLAG_IRQ_SAFE | GENPD_FLAG_CPU_DOMAIN | pd->flags |= GENPD_FLAG_IRQ_SAFE | GENPD_FLAG_CPU_DOMAIN;
GENPD_FLAG_NO_SYNC_STATE;
/* Allow power off when OSI is available. */ /* Allow power off when OSI is available. */
if (sbi_cpuidle_use_osi) if (sbi_cpuidle_use_osi)
@ -570,7 +551,6 @@ static struct platform_driver sbi_cpuidle_driver = {
.probe = sbi_cpuidle_probe, .probe = sbi_cpuidle_probe,
.driver = { .driver = {
.name = "sbi-cpuidle", .name = "sbi-cpuidle",
.sync_state = sbi_cpuidle_domain_sync_state,
}, },
}; };