torvalds/linux
torvalds/linux
2
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-04 20:19:47 +08:00
Code

drm/gem-shmem: Do not map s/g table by default

Browse Source 
The vast majority of drivers that use GEM-SHMEM helpers do not use
an s/g table for imported buffers; specifically all drivers that use
DRM_GEM_SHMEM_DRIVER_OPS. Therefore convert the initializer macro
to DRM_GEM_SHMEM_DRIVER_OPS_NO_MAP_SGT and remove the latter. This
helps to avoid swiotbl errors, such as seen with some Aspeed systems

  ast 0000:07:00.0: swiotlb buffer is full (sz: 3145728 bytes), total 32768 (slots), used 0 (slots)

The error is caused by the system's limited DMA capabilities and can
happen with any GEM-SHMEM-based driver. It results in a performance
penalty.

In the case of vgem and vkms, the devices do not support DMA at all,
which can result in failure to map the buffer object into the kernel's
address space. [1][2] Avoiding the s/g table fixes this problem.

The other drivers based on GEM-SHMEM, imagination, lima, panfrost,
panthor, v3d and virtio, use the s/g table of imported buffers. Neither
driver uses the default initializer, so they won't be affected by
this change.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reported-by: Zenghui Yu <zenghui.yu@linux.dev>
Closes: https://lore.kernel.org/dri-devel/6d22bce3-4533-4cfa-96ba-64352b715741@linux.dev/ # [1]
Reported-by: José Expósito <jose.exposito89@gmail.com>
Closes: https://lore.kernel.org/dri-devel/20250311172054.2903-1-jose.exposito89@gmail.com/ # [2]
Tested-by: Zenghui Yu <zenghui.yu@linux.dev>
Reviewed-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
Link: https://lore.kernel.org/r/20250630143537.309052-1-tzimmermann@suse.de
This commit is contained in:
Thomas Zimmermann 2025-06-30 16:34:11 +02:00
parent cb863540e7
commit e7a1cbca0b
3 changed files with 5 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/ast/ast_drv.c
View File

@ -64,7 +64,7 @@ static const struct drm_driver ast_driver = {
.minor = DRIVER_MINOR, .minor = DRIVER_MINOR,
.patchlevel = DRIVER_PATCHLEVEL, .patchlevel = DRIVER_PATCHLEVEL,
DRM_GEM_SHMEM_DRIVER_OPS_NO_MAP_SGT, DRM_GEM_SHMEM_DRIVER_OPS,
DRM_FBDEV_SHMEM_DRIVER_OPS, DRM_FBDEV_SHMEM_DRIVER_OPS,
}; };

2
drivers/gpu/drm/udl/udl_drv.c
View File

@ -57,7 +57,7 @@ static const struct drm_driver driver = {
/* GEM hooks */ /* GEM hooks */
.fops = &udl_driver_fops, .fops = &udl_driver_fops,
DRM_GEM_SHMEM_DRIVER_OPS_NO_MAP_SGT, DRM_GEM_SHMEM_DRIVER_OPS,
DRM_FBDEV_SHMEM_DRIVER_OPS, DRM_FBDEV_SHMEM_DRIVER_OPS,
.name = DRIVER_NAME, .name = DRIVER_NAME,

18
include/drm/drm_gem_shmem_helper.h
View File

@ -293,23 +293,11 @@ struct drm_gem_object *drm_gem_shmem_prime_import_no_map(struct drm_device *dev,
/** /**
* DRM_GEM_SHMEM_DRIVER_OPS - Default shmem GEM operations * DRM_GEM_SHMEM_DRIVER_OPS - Default shmem GEM operations
* *
* This macro provides a shortcut for setting the shmem GEM operations in * This macro provides a shortcut for setting the shmem GEM operations
* the &drm_driver structure. * in the &drm_driver structure. Drivers that do not require an s/g table
* for imported buffers should use this.
*/ */
#define DRM_GEM_SHMEM_DRIVER_OPS \ #define DRM_GEM_SHMEM_DRIVER_OPS \
.gem_prime_import_sg_table = drm_gem_shmem_prime_import_sg_table, \
.dumb_create = drm_gem_shmem_dumb_create
/**
* DRM_GEM_SHMEM_DRIVER_OPS_NO_MAP_SGT - shmem GEM operations
* without mapping sg_table on
* imported buffer.
*
* This macro provides a shortcut for setting the shmem GEM operations in
* the &drm_driver structure for drivers that do not require a sg_table on
* imported buffers.
*/
#define DRM_GEM_SHMEM_DRIVER_OPS_NO_MAP_SGT \
.gem_prime_import = drm_gem_shmem_prime_import_no_map, \ .gem_prime_import = drm_gem_shmem_prime_import_no_map, \
.dumb_create = drm_gem_shmem_dumb_create .dumb_create = drm_gem_shmem_dumb_create