mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-09-04 20:19:47 +08:00
rust: pci: implement I/O mappable pci::Bar
Implement `pci::Bar`, `pci::Device::iomap_region` and `pci::Device::iomap_region_sized` to allow for I/O mappings of PCI BARs. To ensure that a `pci::Bar`, and hence the I/O memory mapping, can't out-live the PCI device, the `pci::Bar` type is always embedded into a `Devres` container, such that the `pci::Bar` is revoked once the device is unbound and hence the I/O mapped memory is unmapped. A `pci::Bar` can be requested with (`pci::Device::iomap_region_sized`) or without (`pci::Device::iomap_region`) a const generic representing the minimal requested size of the I/O mapped memory region. In case of the latter only runtime checked I/O reads / writes are possible. Co-developed-by: Philipp Stanner <pstanner@redhat.com> Signed-off-by: Philipp Stanner <pstanner@redhat.com> Signed-off-by: Danilo Krummrich <dakr@kernel.org> Tested-by: Dirk Behme <dirk.behme@de.bosch.com> Link: https://lore.kernel.org/r/20241219170425.12036-11-dakr@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
1bd8b6b2c5
commit
bf9651f84b
@ -5,15 +5,19 @@
|
||||
//! C header: [`include/linux/pci.h`](srctree/include/linux/pci.h)
|
||||
|
||||
use crate::{
|
||||
alloc::flags::*,
|
||||
bindings, container_of, device,
|
||||
device_id::RawDeviceId,
|
||||
devres::Devres,
|
||||
driver,
|
||||
error::{to_result, Result},
|
||||
io::Io,
|
||||
io::IoRaw,
|
||||
str::CStr,
|
||||
types::{ARef, ForeignOwnable, Opaque},
|
||||
ThisModule,
|
||||
};
|
||||
use core::ptr::addr_of_mut;
|
||||
use core::{ops::Deref, ptr::addr_of_mut};
|
||||
use kernel::prelude::*;
|
||||
|
||||
/// An adapter for the registration of PCI drivers.
|
||||
@ -235,9 +239,115 @@ pub trait Driver {
|
||||
///
|
||||
/// A PCI device is based on an always reference counted `device:Device` instance. Cloning a PCI
|
||||
/// device, hence, also increments the base device' reference count.
|
||||
///
|
||||
/// # Invariants
|
||||
///
|
||||
/// `Device` hold a valid reference of `ARef<device::Device>` whose underlying `struct device` is a
|
||||
/// member of a `struct pci_dev`.
|
||||
#[derive(Clone)]
|
||||
pub struct Device(ARef<device::Device>);
|
||||
|
||||
/// A PCI BAR to perform I/O-Operations on.
|
||||
///
|
||||
/// # Invariants
|
||||
///
|
||||
/// `Bar` always holds an `IoRaw` inststance that holds a valid pointer to the start of the I/O
|
||||
/// memory mapped PCI bar and its size.
|
||||
pub struct Bar<const SIZE: usize = 0> {
|
||||
pdev: Device,
|
||||
io: IoRaw<SIZE>,
|
||||
num: i32,
|
||||
}
|
||||
|
||||
impl<const SIZE: usize> Bar<SIZE> {
|
||||
fn new(pdev: Device, num: u32, name: &CStr) -> Result<Self> {
|
||||
let len = pdev.resource_len(num)?;
|
||||
if len == 0 {
|
||||
return Err(ENOMEM);
|
||||
}
|
||||
|
||||
// Convert to `i32`, since that's what all the C bindings use.
|
||||
let num = i32::try_from(num)?;
|
||||
|
||||
// SAFETY:
|
||||
// `pdev` is valid by the invariants of `Device`.
|
||||
// `num` is checked for validity by a previous call to `Device::resource_len`.
|
||||
// `name` is always valid.
|
||||
let ret = unsafe { bindings::pci_request_region(pdev.as_raw(), num, name.as_char_ptr()) };
|
||||
if ret != 0 {
|
||||
return Err(EBUSY);
|
||||
}
|
||||
|
||||
// SAFETY:
|
||||
// `pdev` is valid by the invariants of `Device`.
|
||||
// `num` is checked for validity by a previous call to `Device::resource_len`.
|
||||
// `name` is always valid.
|
||||
let ioptr: usize = unsafe { bindings::pci_iomap(pdev.as_raw(), num, 0) } as usize;
|
||||
if ioptr == 0 {
|
||||
// SAFETY:
|
||||
// `pdev` valid by the invariants of `Device`.
|
||||
// `num` is checked for validity by a previous call to `Device::resource_len`.
|
||||
unsafe { bindings::pci_release_region(pdev.as_raw(), num) };
|
||||
return Err(ENOMEM);
|
||||
}
|
||||
|
||||
let io = match IoRaw::new(ioptr, len as usize) {
|
||||
Ok(io) => io,
|
||||
Err(err) => {
|
||||
// SAFETY:
|
||||
// `pdev` is valid by the invariants of `Device`.
|
||||
// `ioptr` is guaranteed to be the start of a valid I/O mapped memory region.
|
||||
// `num` is checked for validity by a previous call to `Device::resource_len`.
|
||||
unsafe { Self::do_release(&pdev, ioptr, num) };
|
||||
return Err(err);
|
||||
}
|
||||
};
|
||||
|
||||
Ok(Bar { pdev, io, num })
|
||||
}
|
||||
|
||||
/// # Safety
|
||||
///
|
||||
/// `ioptr` must be a valid pointer to the memory mapped PCI bar number `num`.
|
||||
unsafe fn do_release(pdev: &Device, ioptr: usize, num: i32) {
|
||||
// SAFETY:
|
||||
// `pdev` is valid by the invariants of `Device`.
|
||||
// `ioptr` is valid by the safety requirements.
|
||||
// `num` is valid by the safety requirements.
|
||||
unsafe {
|
||||
bindings::pci_iounmap(pdev.as_raw(), ioptr as _);
|
||||
bindings::pci_release_region(pdev.as_raw(), num);
|
||||
}
|
||||
}
|
||||
|
||||
fn release(&self) {
|
||||
// SAFETY: The safety requirements are guaranteed by the type invariant of `self.pdev`.
|
||||
unsafe { Self::do_release(&self.pdev, self.io.addr(), self.num) };
|
||||
}
|
||||
}
|
||||
|
||||
impl Bar {
|
||||
fn index_is_valid(index: u32) -> bool {
|
||||
// A `struct pci_dev` owns an array of resources with at most `PCI_NUM_RESOURCES` entries.
|
||||
index < bindings::PCI_NUM_RESOURCES
|
||||
}
|
||||
}
|
||||
|
||||
impl<const SIZE: usize> Drop for Bar<SIZE> {
|
||||
fn drop(&mut self) {
|
||||
self.release();
|
||||
}
|
||||
}
|
||||
|
||||
impl<const SIZE: usize> Deref for Bar<SIZE> {
|
||||
type Target = Io<SIZE>;
|
||||
|
||||
fn deref(&self) -> &Self::Target {
|
||||
// SAFETY: By the type invariant of `Self`, the MMIO range in `self.io` is properly mapped.
|
||||
unsafe { Io::from_raw(&self.io) }
|
||||
}
|
||||
}
|
||||
|
||||
impl Device {
|
||||
/// Create a PCI Device instance from an existing `device::Device`.
|
||||
///
|
||||
@ -283,6 +393,36 @@ impl Device {
|
||||
// SAFETY: `self.as_raw` is guaranteed to be a pointer to a valid `struct pci_dev`.
|
||||
unsafe { bindings::pci_set_master(self.as_raw()) };
|
||||
}
|
||||
|
||||
/// Returns the size of the given PCI bar resource.
|
||||
pub fn resource_len(&self, bar: u32) -> Result<bindings::resource_size_t> {
|
||||
if !Bar::index_is_valid(bar) {
|
||||
return Err(EINVAL);
|
||||
}
|
||||
|
||||
// SAFETY:
|
||||
// - `bar` is a valid bar number, as guaranteed by the above call to `Bar::index_is_valid`,
|
||||
// - by its type invariant `self.as_raw` is always a valid pointer to a `struct pci_dev`.
|
||||
Ok(unsafe { bindings::pci_resource_len(self.as_raw(), bar.try_into()?) })
|
||||
}
|
||||
|
||||
/// Mapps an entire PCI-BAR after performing a region-request on it. I/O operation bound checks
|
||||
/// can be performed on compile time for offsets (plus the requested type size) < SIZE.
|
||||
pub fn iomap_region_sized<const SIZE: usize>(
|
||||
&self,
|
||||
bar: u32,
|
||||
name: &CStr,
|
||||
) -> Result<Devres<Bar<SIZE>>> {
|
||||
let bar = Bar::<SIZE>::new(self.clone(), bar, name)?;
|
||||
let devres = Devres::new(self.as_ref(), bar, GFP_KERNEL)?;
|
||||
|
||||
Ok(devres)
|
||||
}
|
||||
|
||||
/// Mapps an entire PCI-BAR after performing a region-request on it.
|
||||
pub fn iomap_region(&self, bar: u32, name: &CStr) -> Result<Devres<Bar>> {
|
||||
self.iomap_region_sized::<0>(bar, name)
|
||||
}
|
||||
}
|
||||
|
||||
impl AsRef<device::Device> for Device {
|
||||
|
Loading…
Reference in New Issue
Block a user