torvalds/linux
torvalds/linux
2
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-04 20:19:47 +08:00
Code

drm/nouveau/nvif: Fix potential memory leak in nvif_vmm_ctor().

Browse Source 
When the nvif_vmm_type is invalid, we will return error directly
without freeing the args in nvif_vmm_ctor(), which leading a memory
leak. Fix it by setting the ret -EINVAL and goto done.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/all/202312040659.4pJpMafN-lkp@intel.com/
Fixes: 6b252cf422 ("drm/nouveau: nvkm/vmm: implement raw ops to manage uvmm")
Signed-off-by: Fanhua Li <lifanhua5@huawei.com>
Link: https://lore.kernel.org/r/20250728115027.50878-1-lifanhua5@huawei.com
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
This commit is contained in:
Fanhua Li 2025-07-28 19:50:27 +08:00 committed by Danilo Krummrich
parent 038d61fd64
commit bb8aeaa319
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/gpu/drm/nouveau/nvif/vmm.c
View File

@ -219,7 +219,8 @@ nvif_vmm_ctor(struct nvif_mmu *mmu, const char *name, s32 oclass,
case RAW: args->type = NVIF_VMM_V0_TYPE_RAW; break; case RAW: args->type = NVIF_VMM_V0_TYPE_RAW; break;
default: default:
WARN_ON(1); WARN_ON(1);
return -EINVAL; ret = -EINVAL;
goto done;
} }
memcpy(args->data, argv, argc); memcpy(args->data, argv, argc);