mirror of
				git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
				synced 2025-09-04 20:19:47 +08:00 
			
		
		
		
	RDMA/rtrs: Do not signal for heatbeat
For HB, there is no need to generate signal for completion.
Also remove a comment accordingly.
Fixes: c0894b3ea6 ("RDMA/rtrs: core: lib functions shared between client and server modules")
Link: https://lore.kernel.org/r/20201217141915.56989-16-jinpu.wang@cloud.ionos.com
Signed-off-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Reported-by: Gioh Kim <gi-oh.kim@cloud.ionos.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
			
			
This commit is contained in:
		
							parent
							
								
									eab0982466
								
							
						
					
					
						commit
						b38041d50a
					
				| @ -664,7 +664,6 @@ static void rtrs_clt_rdma_done(struct ib_cq *cq, struct ib_wc *wc) | ||||
| 	case IB_WC_RDMA_WRITE: | ||||
| 		/*
 | ||||
| 		 * post_send() RDMA write completions of IO reqs (read/write) | ||||
| 		 * and hb | ||||
| 		 */ | ||||
| 		break; | ||||
| 
 | ||||
|  | ||||
| @ -1242,7 +1242,6 @@ static void rtrs_srv_rdma_done(struct ib_cq *cq, struct ib_wc *wc) | ||||
| 	case IB_WC_SEND: | ||||
| 		/*
 | ||||
| 		 * post_send() RDMA write completions of IO reqs (read/write) | ||||
| 		 * and hb | ||||
| 		 */ | ||||
| 		atomic_add(srv->queue_depth, &con->sq_wr_avail); | ||||
| 
 | ||||
|  | ||||
| @ -310,7 +310,7 @@ void rtrs_send_hb_ack(struct rtrs_sess *sess) | ||||
| 
 | ||||
| 	imm = rtrs_to_imm(RTRS_HB_ACK_IMM, 0); | ||||
| 	err = rtrs_post_rdma_write_imm_empty(usr_con, sess->hb_cqe, imm, | ||||
| 					      IB_SEND_SIGNALED, NULL); | ||||
| 					     0, NULL); | ||||
| 	if (err) { | ||||
| 		sess->hb_err_handler(usr_con); | ||||
| 		return; | ||||
| @ -339,7 +339,7 @@ static void hb_work(struct work_struct *work) | ||||
| 	} | ||||
| 	imm = rtrs_to_imm(RTRS_HB_MSG_IMM, 0); | ||||
| 	err = rtrs_post_rdma_write_imm_empty(usr_con, sess->hb_cqe, imm, | ||||
| 					      IB_SEND_SIGNALED, NULL); | ||||
| 					     0, NULL); | ||||
| 	if (err) { | ||||
| 		sess->hb_err_handler(usr_con); | ||||
| 		return; | ||||
|  | ||||
		Loading…
	
		Reference in New Issue
	
	Block a user
	 Jack Wang
						Jack Wang