torvalds/linux
torvalds/linux
2
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-04 20:19:47 +08:00
Code

drm/dp_mst: Fix GUID DPCD write to non-root MST branch devices

Browse Source 
The return value on success of drm_dp_send_dpcd_write() called for
non-root MST branch devices from drm_dp_check_mstb_guid() is the number
of bytes transferred. Atm this return value (in case of a complete read)
will be regarded incorrectly as an error by the caller of
drm_dp_check_mstb_guid(). Fix this by converting the return value for a
complete read to the expected success code (0) and for a partial read to
a failure code (-EPROTO).

Fixes: 2554da0de3 ("drm/display: dp-mst-topology: use new DCPD access helpers")
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Lyude Paul <lyude@redhat.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://lore.kernel.org/r/20250401103846.686408-1-imre.deak@intel.com
This commit is contained in:
Imre Deak 2025-04-01 13:38:45 +03:00
parent 8abaa80b40
commit aea007741b
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/display/drm_dp_mst_topology.c
View File

@ -2200,6 +2200,8 @@ static int drm_dp_check_mstb_guid(struct drm_dp_mst_branch *mstb, guid_t *guid)
ret = drm_dp_send_dpcd_write(mstb->mgr, ret = drm_dp_send_dpcd_write(mstb->mgr,
mstb->port_parent, mstb->port_parent,
DP_GUID, sizeof(buf), buf); DP_GUID, sizeof(buf), buf);
if (ret >= 0)
ret = ret == sizeof(buf) ? 0 : -EPROTO;
} else { } else {
ret = drm_dp_dpcd_write_data(mstb->mgr->aux, ret = drm_dp_dpcd_write_data(mstb->mgr->aux,
DP_GUID, buf, sizeof(buf)); DP_GUID, buf, sizeof(buf));