torvalds/linux
torvalds/linux
2
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-04 20:19:47 +08:00
Code

ubsan: Fix incorrect hand-side used in handle

Browse Source 
__ubsan_handle_divrem_overflow() incorrectly uses the RHS to report.
It always reports the same log: division of -1 by -1. But it should
report division of LHS by -1.

Signed-off-by: Junhui Pei <paradoxskin233@gmail.com>
Fixes: c6d308534a ("UBSAN: run-time undefined behavior sanity checker")
Link: https://lore.kernel.org/r/20250602153841.62935-1-paradoxskin233@gmail.com
Signed-off-by: Kees Cook <kees@kernel.org>
This commit is contained in:
Junhui Pei 2025-06-02 23:38:41 +08:00 committed by Kees Cook
parent c17b750b3a
commit ae91aea2d2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/ubsan.c
View File

@ -333,18 +333,18 @@ EXPORT_SYMBOL(__ubsan_handle_implicit_conversion);
void __ubsan_handle_divrem_overflow(void *_data, void *lhs, void *rhs) void __ubsan_handle_divrem_overflow(void *_data, void *lhs, void *rhs)
{ {
struct overflow_data *data = _data; struct overflow_data *data = _data;
char rhs_val_str[VALUE_LENGTH]; char lhs_val_str[VALUE_LENGTH];
if (suppress_report(&data->location)) if (suppress_report(&data->location))
return; return;
ubsan_prologue(&data->location, "division-overflow"); ubsan_prologue(&data->location, "division-overflow");
val_to_string(rhs_val_str, sizeof(rhs_val_str), data->type, rhs); val_to_string(lhs_val_str, sizeof(lhs_val_str), data->type, lhs);
if (type_is_signed(data->type) && get_signed_val(data->type, rhs) == -1) if (type_is_signed(data->type) && get_signed_val(data->type, rhs) == -1)
pr_err("division of %s by -1 cannot be represented in type %s\n", pr_err("division of %s by -1 cannot be represented in type %s\n",
rhs_val_str, data->type->type_name); lhs_val_str, data->type->type_name);
else else
pr_err("division by zero\n"); pr_err("division by zero\n");