torvalds/linux
torvalds/linux
2
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-04 20:19:47 +08:00
Code

firmware: thead,th1520-aon: Fix use after free in th1520_aon_init()

Browse Source 
Record the error code before freeing "aon_chan" to avoid a
use after free.

Fixes: e4b3cbd840 ("firmware: thead: Add AON firmware protocol driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/f19be994-d355-48a6-ab45-d0f7e5955daf@stanley.mountain
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
Dan Carpenter 2025-03-15 13:04:24 +03:00 committed by Ulf Hansson
parent 6cf5db71dc
commit ae85dabcef
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/firmware/thead,th1520-aon.c
View File

@ -203,6 +203,7 @@ struct th1520_aon_chan *th1520_aon_init(struct device *dev)
{ {
struct th1520_aon_chan *aon_chan; struct th1520_aon_chan *aon_chan;
struct mbox_client *cl; struct mbox_client *cl;
int ret;
aon_chan = kzalloc(sizeof(*aon_chan), GFP_KERNEL); aon_chan = kzalloc(sizeof(*aon_chan), GFP_KERNEL);
if (!aon_chan) if (!aon_chan)
@ -217,8 +218,9 @@ struct th1520_aon_chan *th1520_aon_init(struct device *dev)
aon_chan->ch = mbox_request_channel_byname(cl, "aon"); aon_chan->ch = mbox_request_channel_byname(cl, "aon");
if (IS_ERR(aon_chan->ch)) { if (IS_ERR(aon_chan->ch)) {
dev_err(dev, "Failed to request aon mbox chan\n"); dev_err(dev, "Failed to request aon mbox chan\n");
ret = PTR_ERR(aon_chan->ch);
kfree(aon_chan); kfree(aon_chan);
return ERR_CAST(aon_chan->ch); return ERR_PTR(ret);
} }
mutex_init(&aon_chan->transaction_lock); mutex_init(&aon_chan->transaction_lock);