torvalds/linux
torvalds/linux
2
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-04 20:19:47 +08:00
Code

generic-adc-battery: Pointer math issue in gab_probe()

Browse Source 
psy->properties is an enum (32 bit type) so adding sizeof() puts us four
times further along than we intended.  It should be cast to a char pointer
before doing the math.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
This commit is contained in:
Dan Carpenter 2012-09-29 10:13:46 +03:00 committed by Anton Vorontsov
parent a5af092245
commit a77d60aec7
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/power/generic-adc-battery.c
View File

@ -279,7 +279,8 @@ static int __devinit gab_probe(struct platform_device *pdev)
} }
memcpy(psy->properties, gab_props, sizeof(gab_props)); memcpy(psy->properties, gab_props, sizeof(gab_props));
properties = psy->properties + sizeof(gab_props); properties = (enum power_supply_property *)
((char *)psy->properties + sizeof(gab_props));
/* /*
* getting channel from iio and copying the battery properties * getting channel from iio and copying the battery properties