mirror of
				git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
				synced 2025-09-04 20:19:47 +08:00 
			
		
		
		
	iwlwifi: move SnJ and So rules to the new tables
We were hardcoding the SnJ and So IDs already at the trans_cfg selection, instead of doing it in a more generic way. Use the generic trans_cfg selection for these devices and move the hardcoded IDs to the new table. Signed-off-by: Luca Coelho <luciano.coelho@intel.com> Link: https://lore.kernel.org/r/iwlwifi.20210205110447.7e11dcb7b04e.I6f65126175d54b73834c2896013d00ce114ff601@changeid Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
This commit is contained in:
		
							parent
							
								
									85b7eb490e
								
							
						
					
					
						commit
						6f60fb03c8
					
				| @ -238,6 +238,44 @@ const struct iwl_cfg_trans_params iwl_qu_long_latency_trans_cfg = { | ||||
| 	.ltr_delay = IWL_CFG_TRANS_LTR_DELAY_2500US, | ||||
| }; | ||||
| 
 | ||||
| const struct iwl_cfg_trans_params iwl_snj_trans_cfg = { | ||||
| 	.mq_rx_supported = true, | ||||
| 	.use_tfh = true, | ||||
| 	.rf_id = true, | ||||
| 	.gen2 = true, | ||||
| 	.device_family = IWL_DEVICE_FAMILY_AX210, | ||||
| 	.base_params = &iwl_ax210_base_params, | ||||
| 	.umac_prph_offset = 0x300000, | ||||
| }; | ||||
| 
 | ||||
| const struct iwl_cfg_trans_params iwl_so_trans_cfg = { | ||||
| 	.mq_rx_supported = true, | ||||
| 	.use_tfh = true, | ||||
| 	.rf_id = true, | ||||
| 	.gen2 = true, | ||||
| 	.device_family = IWL_DEVICE_FAMILY_AX210, | ||||
| 	.base_params = &iwl_ax210_base_params, | ||||
| 	.umac_prph_offset = 0x300000, | ||||
| 	.integrated = true, | ||||
| 	/* TODO: the following values need to be checked */ | ||||
| 	.xtal_latency = 500, | ||||
| 	.ltr_delay = IWL_CFG_TRANS_LTR_DELAY_200US, | ||||
| }; | ||||
| 
 | ||||
| const struct iwl_cfg_trans_params iwl_so_long_latency_trans_cfg = { | ||||
| 	.mq_rx_supported = true, | ||||
| 	.use_tfh = true, | ||||
| 	.rf_id = true, | ||||
| 	.gen2 = true, | ||||
| 	.device_family = IWL_DEVICE_FAMILY_AX210, | ||||
| 	.base_params = &iwl_ax210_base_params, | ||||
| 	.umac_prph_offset = 0x300000, | ||||
| 	.integrated = true, | ||||
| 	/* TODO: the following values need to be checked */ | ||||
| 	.xtal_latency = 12000, | ||||
| 	.ltr_delay = IWL_CFG_TRANS_LTR_DELAY_2500US, | ||||
| }; | ||||
| 
 | ||||
| /*
 | ||||
|  * If the device doesn't support HE, no need to have that many buffers. | ||||
|  * 22000 devices can split multiple frames into a single RB, so fewer are | ||||
|  | ||||
| @ -418,6 +418,7 @@ struct iwl_cfg { | ||||
| #define IWL_CFG_MAC_TYPE_QU		0x33 | ||||
| #define IWL_CFG_MAC_TYPE_QUZ		0x35 | ||||
| #define IWL_CFG_MAC_TYPE_QNJ		0x36 | ||||
| #define IWL_CFG_MAC_TYPE_SO		0x37 | ||||
| #define IWL_CFG_MAC_TYPE_SNJ		0x42 | ||||
| #define IWL_CFG_MAC_TYPE_MA		0x44 | ||||
| 
 | ||||
| @ -473,6 +474,9 @@ extern const struct iwl_cfg_trans_params iwl_qu_trans_cfg; | ||||
| extern const struct iwl_cfg_trans_params iwl_qu_medium_latency_trans_cfg; | ||||
| extern const struct iwl_cfg_trans_params iwl_qu_long_latency_trans_cfg; | ||||
| extern const struct iwl_cfg_trans_params iwl_ax200_trans_cfg; | ||||
| extern const struct iwl_cfg_trans_params iwl_snj_trans_cfg; | ||||
| extern const struct iwl_cfg_trans_params iwl_so_trans_cfg; | ||||
| extern const struct iwl_cfg_trans_params iwl_so_long_latency_trans_cfg; | ||||
| extern const struct iwl_cfg_trans_params iwl_ma_trans_cfg; | ||||
| extern const char iwl9162_name[]; | ||||
| extern const char iwl9260_name[]; | ||||
|  | ||||
| @ -478,40 +478,13 @@ static const struct pci_device_id iwl_hw_card_ids[] = { | ||||
| 
 | ||||
| 	{IWL_PCI_DEVICE(0x2723, PCI_ANY_ID, iwl_ax200_trans_cfg)}, | ||||
| 
 | ||||
| 	{IWL_PCI_DEVICE(0x2725, 0x0090, iwlax211_2ax_cfg_so_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2725, 0x0020, iwlax210_2ax_cfg_ty_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2725, 0x0024, iwlax210_2ax_cfg_ty_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2725, 0x0310, iwlax210_2ax_cfg_ty_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2725, 0x0510, iwlax210_2ax_cfg_ty_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2725, 0x0A10, iwlax210_2ax_cfg_ty_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2725, 0xE020, iwlax210_2ax_cfg_ty_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2725, 0xE024, iwlax210_2ax_cfg_ty_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2725, 0x4020, iwlax210_2ax_cfg_ty_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2725, 0x6020, iwlax210_2ax_cfg_ty_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2725, 0x6024, iwlax210_2ax_cfg_ty_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2725, 0x00B0, iwlax411_2ax_cfg_sosnj_gf4_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2726, 0x0070, iwlax201_cfg_snj_hr_b0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2726, 0x0074, iwlax201_cfg_snj_hr_b0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2726, 0x0078, iwlax201_cfg_snj_hr_b0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2726, 0x007C, iwlax201_cfg_snj_hr_b0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2726, 0x0090, iwlax211_cfg_snj_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2726, 0x0098, iwlax211_cfg_snj_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2726, 0x00B0, iwlax411_2ax_cfg_sosnj_gf4_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2726, 0x0510, iwlax211_cfg_snj_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2726, 0x2074, iwlax201_cfg_snj_hr_b0)}, | ||||
| 	{IWL_PCI_DEVICE(0x2726, 0x4070, iwlax201_cfg_snj_hr_b0)}, | ||||
| 	{IWL_PCI_DEVICE(0x7A70, 0x0090, iwlax211_2ax_cfg_so_gf_a0_long)}, | ||||
| 	{IWL_PCI_DEVICE(0x7A70, 0x0098, iwlax211_2ax_cfg_so_gf_a0_long)}, | ||||
| 	{IWL_PCI_DEVICE(0x7A70, 0x00B0, iwlax411_2ax_cfg_so_gf4_a0_long)}, | ||||
| 	{IWL_PCI_DEVICE(0x7A70, 0x0310, iwlax211_2ax_cfg_so_gf_a0_long)}, | ||||
| 	{IWL_PCI_DEVICE(0x7A70, 0x0510, iwlax211_2ax_cfg_so_gf_a0_long)}, | ||||
| 	{IWL_PCI_DEVICE(0x7A70, 0x0A10, iwlax211_2ax_cfg_so_gf_a0_long)}, | ||||
| 	{IWL_PCI_DEVICE(0x7AF0, 0x0090, iwlax211_2ax_cfg_so_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x7AF0, 0x0098, iwlax211_2ax_cfg_so_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x7AF0, 0x00B0, iwlax411_2ax_cfg_so_gf4_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x7AF0, 0x0310, iwlax211_2ax_cfg_so_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x7AF0, 0x0510, iwlax211_2ax_cfg_so_gf_a0)}, | ||||
| 	{IWL_PCI_DEVICE(0x7AF0, 0x0A10, iwlax211_2ax_cfg_so_gf_a0)}, | ||||
| /* So devices */ | ||||
| 	{IWL_PCI_DEVICE(0x2725, PCI_ANY_ID, iwl_so_trans_cfg)}, | ||||
| 	{IWL_PCI_DEVICE(0x2726, PCI_ANY_ID, iwl_snj_trans_cfg)}, | ||||
| 	{IWL_PCI_DEVICE(0x7A70, PCI_ANY_ID, iwl_so_long_latency_trans_cfg)}, | ||||
| 	{IWL_PCI_DEVICE(0x7AF0, PCI_ANY_ID, iwl_so_trans_cfg)}, | ||||
| 	{IWL_PCI_DEVICE(0x51F0, PCI_ANY_ID, iwl_so_long_latency_trans_cfg)}, | ||||
| 	{IWL_PCI_DEVICE(0x54F0, PCI_ANY_ID, iwl_so_long_latency_trans_cfg)}, | ||||
| 
 | ||||
| /* Ma devices */ | ||||
| 	{IWL_PCI_DEVICE(0x2729, PCI_ANY_ID, iwl_ma_trans_cfg)}, | ||||
| @ -558,12 +531,6 @@ static const struct iwl_dev_info iwl_dev_info_table[] = { | ||||
| 	/* QnJ with Hr */ | ||||
| 	IWL_DEV_INFO(0x2720, IWL_CFG_ANY, iwl_qnj_b0_hr_b0_cfg, iwl_ax201_name), | ||||
| 
 | ||||
| 	/* SnJ with HR*/ | ||||
| 	IWL_DEV_INFO(0x2726, 0x0244, iwlax201_cfg_snj_hr_b0, iwl_ax101_name), | ||||
| 	IWL_DEV_INFO(0x2726, 0x1651, iwlax201_cfg_snj_hr_b0, iwl_ax201_killer_1650s_name), | ||||
| 	IWL_DEV_INFO(0x2726, 0x1652, iwlax201_cfg_snj_hr_b0, iwl_ax201_killer_1650i_name), | ||||
| 	IWL_DEV_INFO(0x2726, 0x4244, iwlax201_cfg_snj_hr_b0, iwl_ax101_name), | ||||
| 
 | ||||
| 	/* Qu with Hr */ | ||||
| 	IWL_DEV_INFO(0x43F0, 0x0070, iwl_ax201_cfg_qu_hr, NULL), | ||||
| 	IWL_DEV_INFO(0x43F0, 0x0074, iwl_ax201_cfg_qu_hr, NULL), | ||||
| @ -629,6 +596,42 @@ static const struct iwl_dev_info iwl_dev_info_table[] = { | ||||
| 	IWL_DEV_INFO(0x4DF0, 0x2074, iwl_ax201_cfg_qu_hr, NULL), | ||||
| 	IWL_DEV_INFO(0x4DF0, 0x4070, iwl_ax201_cfg_qu_hr, NULL), | ||||
| 
 | ||||
| 	/* So with HR */ | ||||
| 	IWL_DEV_INFO(0x2725, 0x0090, iwlax211_2ax_cfg_so_gf_a0, NULL), | ||||
| 	IWL_DEV_INFO(0x2725, 0x0020, iwlax210_2ax_cfg_ty_gf_a0, NULL), | ||||
| 	IWL_DEV_INFO(0x2725, 0x0310, iwlax210_2ax_cfg_ty_gf_a0, NULL), | ||||
| 	IWL_DEV_INFO(0x2725, 0x0510, iwlax210_2ax_cfg_ty_gf_a0, NULL), | ||||
| 	IWL_DEV_INFO(0x2725, 0x0A10, iwlax210_2ax_cfg_ty_gf_a0, NULL), | ||||
| 	IWL_DEV_INFO(0x7A70, 0x0090, iwlax211_2ax_cfg_so_gf_a0_long, NULL), | ||||
| 	IWL_DEV_INFO(0x7A70, 0x0098, iwlax211_2ax_cfg_so_gf_a0_long, NULL), | ||||
| 	IWL_DEV_INFO(0x7A70, 0x00B0, iwlax411_2ax_cfg_so_gf4_a0_long, NULL), | ||||
| 	IWL_DEV_INFO(0x7A70, 0x0310, iwlax211_2ax_cfg_so_gf_a0_long, NULL), | ||||
| 	IWL_DEV_INFO(0x7A70, 0x0510, iwlax211_2ax_cfg_so_gf_a0_long, NULL), | ||||
| 	IWL_DEV_INFO(0x7A70, 0x0A10, iwlax211_2ax_cfg_so_gf_a0_long, NULL), | ||||
| 	IWL_DEV_INFO(0x7AF0, 0x0090, iwlax211_2ax_cfg_so_gf_a0, NULL), | ||||
| 	IWL_DEV_INFO(0x7AF0, 0x0098, iwlax211_2ax_cfg_so_gf_a0, NULL), | ||||
| 	IWL_DEV_INFO(0x7AF0, 0x00B0, iwlax411_2ax_cfg_so_gf4_a0, NULL), | ||||
| 	IWL_DEV_INFO(0x7AF0, 0x0310, iwlax211_2ax_cfg_so_gf_a0, NULL), | ||||
| 	IWL_DEV_INFO(0x7AF0, 0x0510, iwlax211_2ax_cfg_so_gf_a0, NULL), | ||||
| 	IWL_DEV_INFO(0x7AF0, 0x0A10, iwlax211_2ax_cfg_so_gf_a0, NULL), | ||||
| 
 | ||||
| 	/* SnJ with HR */ | ||||
| 	IWL_DEV_INFO(0x2725, 0x00B0, iwlax411_2ax_cfg_sosnj_gf4_a0, NULL), | ||||
| 	IWL_DEV_INFO(0x2726, 0x0070, iwlax201_cfg_snj_hr_b0, NULL), | ||||
| 	IWL_DEV_INFO(0x2726, 0x0074, iwlax201_cfg_snj_hr_b0, NULL), | ||||
| 	IWL_DEV_INFO(0x2726, 0x0078, iwlax201_cfg_snj_hr_b0, NULL), | ||||
| 	IWL_DEV_INFO(0x2726, 0x007C, iwlax201_cfg_snj_hr_b0, NULL), | ||||
| 	IWL_DEV_INFO(0x2726, 0x0090, iwlax211_cfg_snj_gf_a0, NULL), | ||||
| 	IWL_DEV_INFO(0x2726, 0x0098, iwlax211_cfg_snj_gf_a0, NULL), | ||||
| 	IWL_DEV_INFO(0x2726, 0x00B0, iwlax411_2ax_cfg_sosnj_gf4_a0, NULL), | ||||
| 	IWL_DEV_INFO(0x2726, 0x0510, iwlax211_cfg_snj_gf_a0, NULL), | ||||
| 	IWL_DEV_INFO(0x2726, 0x2074, iwlax201_cfg_snj_hr_b0, NULL), | ||||
| 	IWL_DEV_INFO(0x2726, 0x4070, iwlax201_cfg_snj_hr_b0, NULL), | ||||
| 	IWL_DEV_INFO(0x2726, 0x0244, iwlax201_cfg_snj_hr_b0, iwl_ax101_name), | ||||
| 	IWL_DEV_INFO(0x2726, 0x1651, iwlax201_cfg_snj_hr_b0, iwl_ax201_killer_1650s_name), | ||||
| 	IWL_DEV_INFO(0x2726, 0x1652, iwlax201_cfg_snj_hr_b0, iwl_ax201_killer_1650i_name), | ||||
| 	IWL_DEV_INFO(0x2726, 0x4244, iwlax201_cfg_snj_hr_b0, iwl_ax101_name), | ||||
| 
 | ||||
| 	_IWL_DEV_INFO(IWL_CFG_ANY, IWL_CFG_ANY, | ||||
| 		      IWL_CFG_MAC_TYPE_PU, IWL_CFG_ANY, | ||||
| 		      IWL_CFG_RF_TYPE_JF1, IWL_CFG_RF_ID_JF1, | ||||
|  | ||||
		Loading…
	
		Reference in New Issue
	
	Block a user
	 Luca Coelho
						Luca Coelho