torvalds/linux
3
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-03-22 07:27:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

ASoC: simple-card-utils: Make simple_util_remove() return void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code.  However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

simple_util_remove() returned zero unconditionally. Make it return void
instead and convert all users to struct platform_device::remove_new().

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Herve Codina <herve.codina@bootlin.com>
Link: https://lore.kernel.org/r/20231013221945.1489203-13-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Uwe Kleine-König
2023-10-14 00:19:50 +02:00
committed by Mark Brown
parent 6b02f5a6f1
commit 393df6f321
7 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sound/soc/generic/simple-card-utils.c
View File

@@ -958,13 +958,11 @@ int simple_util_init_priv(struct simple_util_priv *priv,
}
EXPORT_SYMBOL_GPL(simple_util_init_priv);
int simple_util_remove(struct platform_device *pdev)
void simple_util_remove(struct platform_device *pdev)
{
struct snd_soc_card *card = platform_get_drvdata(pdev);
simple_util_clean_reference(card);
return 0;
}
EXPORT_SYMBOL_GPL(simple_util_remove);