torvalds/linux
torvalds/linux
2
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-04 20:19:47 +08:00
Code

HID: replace scnprintf() with sysfs_emit()

Browse Source 
Documentation/filesystems/sysfs.rst mentions that show() should only
use sysfs_emit() or sysfs_emit_at() when formating the value to be
returned to user space. So replace scnprintf() with sysfs_emit().

Signed-off-by: Chelsy Ratnawat <chelsyratnawat2001@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
This commit is contained in:
Chelsy Ratnawat 2025-06-19 08:46:27 -07:00 committed by Jiri Kosina
parent d3db1ce9bf
commit 37a9acb971
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/hid/hid-core.c
View File

@ -2797,7 +2797,7 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *a,
{ {
struct hid_device *hdev = container_of(dev, struct hid_device, dev); struct hid_device *hdev = container_of(dev, struct hid_device, dev);
return scnprintf(buf, PAGE_SIZE, "hid:b%04Xg%04Xv%08Xp%08X\n", return sysfs_emit(buf, "hid:b%04Xg%04Xv%08Xp%08X\n",
hdev->bus, hdev->group, hdev->vendor, hdev->product); hdev->bus, hdev->group, hdev->vendor, hdev->product);
} }
static DEVICE_ATTR_RO(modalias); static DEVICE_ATTR_RO(modalias);

6
drivers/hid/hid-lg4ff.c
View File

@ -956,7 +956,7 @@ static ssize_t lg4ff_combine_show(struct device *dev, struct device_attribute *a
return 0; return 0;
} }
count = scnprintf(buf, PAGE_SIZE, "%u\n", entry->wdata.combine); count = sysfs_emit(buf, "%u\n", entry->wdata.combine);
return count; return count;
} }
@ -1009,7 +1009,7 @@ static ssize_t lg4ff_range_show(struct device *dev, struct device_attribute *att
return 0; return 0;
} }
count = scnprintf(buf, PAGE_SIZE, "%u\n", entry->wdata.range); count = sysfs_emit(buf, "%u\n", entry->wdata.range);
return count; return count;
} }
@ -1073,7 +1073,7 @@ static ssize_t lg4ff_real_id_show(struct device *dev, struct device_attribute *a
return 0; return 0;
} }
count = scnprintf(buf, PAGE_SIZE, "%s: %s\n", entry->wdata.real_tag, entry->wdata.real_name); count = sysfs_emit(buf, "%s: %s\n", entry->wdata.real_tag, entry->wdata.real_name);
return count; return count;
} }