torvalds/linux
torvalds/linux
2
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-04 20:19:47 +08:00
Code

soundwire: debugfs: move debug statement outside of error handling

Browse Source 
The start_t and finish_t variables are not properly initialized
if errors happens over request_firmware actions.
This was also detected by smatch:

drivers/soundwire/debugfs.c:301 cmd_go() error: uninitialized symbol 'finish_t'.
drivers/soundwire/debugfs.c:301 cmd_go() error: uninitialized symbol 'start_t'.

Move the debug statement outside of firmware error handling.

Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-sound/0db6d0bf-7bac-43a7-b624-a00d3d2bf829@stanley.mountain/
Fixes: bb5cb09eed ("soundwire: debugfs: add interface for BPT/BRA transfers")
Link: https://lore.kernel.org/r/20250626213628.9575-1-rodrigo.gobbi.7@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Rodrigo Gobbi 2025-06-26 18:33:14 -03:00 committed by Vinod Koul
parent 72bbf6e866
commit 06f77ff9d8
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/soundwire/debugfs.c
View File

@ -291,6 +291,9 @@ static int cmd_go(void *data, u64 value)
finish_t = ktime_get(); finish_t = ktime_get();
dev_dbg(&slave->dev, "command completed, num_byte %zu status %d, time %lld ms\n",
num_bytes, ret, div_u64(finish_t - start_t, NSEC_PER_MSEC));
out: out:
if (fw) if (fw)
release_firmware(fw); release_firmware(fw);
@ -298,9 +301,6 @@ out:
pm_runtime_mark_last_busy(&slave->dev); pm_runtime_mark_last_busy(&slave->dev);
pm_runtime_put(&slave->dev); pm_runtime_put(&slave->dev);
dev_dbg(&slave->dev, "command completed, num_byte %zu status %d, time %lld ms\n",
num_bytes, ret, div_u64(finish_t - start_t, NSEC_PER_MSEC));
return ret; return ret;
} }
DEFINE_DEBUGFS_ATTRIBUTE(cmd_go_fops, NULL, DEFINE_DEBUGFS_ATTRIBUTE(cmd_go_fops, NULL,